luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-07-24 02:47:52 +02:00
Code Issues Packages Projects Releases Wiki Activity

tests: Cope with having CAP_DAC_OVERRIDE, even if not euid 0

Browse Source 
Some CI platforms invoke these tests with euid != 0 but with
capabilities. Detect whether we have Linux CAP_DAC_OVERRIDE or other
OSs' equivalents, and skip tests that rely on DAC permissions being
denied if we do have that privilege.

Signed-off-by: Simon McVittie <smcv@collabora.com>
Fixes: https://gitlab.gnome.org/GNOME/glib/issues/2027
Fixes: https://gitlab.gnome.org/GNOME/glib/issues/2028
This commit is contained in:
Simon McVittie
2020-02-13 12:53:13 +00:00
parent 6e28ce2860
commit b9d04b37b0
2 changed files with 172 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

88
gio/tests/live-g-file.c
View File

@@ -22,6 +22,7 @@
#include <glib/glib.h>
#include <gio/gio.h>
#include <errno.h>
#include <stdlib.h>
#include <stdio.h>
#include <unistd.h>
@@ -115,6 +116,65 @@ static gboolean write_test;
static gboolean verbose;
static gboolean posix_compat;
#ifdef G_OS_UNIX
/*
* check_cap_dac_override:
* @tmpdir: A temporary directory in which we can create and delete files
*
* Check whether the current process can bypass DAC permissions.
*
* Traditionally, "privileged" processes (those with effective uid 0)
* could do this (and bypass many other checks), and "unprivileged"
* processes could not.
*
* In Linux, the special powers of euid 0 are divided into many
* capabilities: see `capabilities(7)`. The one we are interested in
* here is `CAP_DAC_OVERRIDE`.
*
* We do this generically instead of actually looking at the capability
* bits, so that the right thing will happen on non-Linux Unix
* implementations, in particular if they have something equivalent to
* but not identical to Linux permissions.
*
* Returns: %TRUE if we have Linux `CAP_DAC_OVERRIDE` or equivalent
* privileges
*/
static gboolean
check_cap_dac_override (const char *tmpdir)
{
gchar *dac_denies_write;
gchar *inside;
gboolean have_cap;
dac_denies_write = g_build_filename (tmpdir, "dac-denies-write", NULL);
inside = g_build_filename (dac_denies_write, "inside", NULL);
g_assert_cmpint (mkdir (dac_denies_write, S_IRWXU) == 0 ? 0 : errno, ==, 0);
g_assert_cmpint (chmod (dac_denies_write, 0) == 0 ? 0 : errno, ==, 0);
if (mkdir (inside, S_IRWXU) == 0)
{
g_test_message ("Looks like we have CAP_DAC_OVERRIDE or equivalent");
g_assert_cmpint (rmdir (inside) == 0 ? 0 : errno, ==, 0);
have_cap = TRUE;
}
else
{
int saved_errno = errno;
g_test_message ("We do not have CAP_DAC_OVERRIDE or equivalent");
g_assert_cmpint (saved_errno, ==, EACCES);
have_cap = FALSE;
}
g_assert_cmpint (chmod (dac_denies_write, S_IRWXU) == 0 ? 0 : errno, ==, 0);
g_assert_cmpint (rmdir (dac_denies_write) == 0 ? 0 : errno, ==, 0);
g_free (dac_denies_write);
g_free (inside);
return have_cap;
}
#endif
#ifdef G_HAVE_ISO_VARARGS
#define log(...) if (verbose) g_printerr (__VA_ARGS__)
#elif defined(G_HAVE_GNUC_VARARGS)
@@ -708,6 +768,9 @@ do_copy_move (GFile * root, struct StructureItem item, const char *target_dir,
GFile *dst_dir, *src_file, *dst_file;
gboolean res;
GError *error;
#ifdef G_OS_UNIX
gboolean have_cap_dac_override = check_cap_dac_override (g_file_peek_path (root));
#endif
log (" do_copy_move: '%s' --> '%s'\n", item.filename, target_dir);
@@ -768,12 +831,17 @@ do_copy_move (GFile * root, struct StructureItem item, const char *target_dir,
(extra_flags == TEST_NO_ACCESS))
{
/* This works for root, see bug #552912 */
if (test_suite && getuid () == 0)
#ifdef G_OS_UNIX
if (have_cap_dac_override)
{
g_test_message ("Unable to exercise g_file_copy() or g_file_move() "
"failing with EACCES: we probably have "
"CAP_DAC_OVERRIDE");
g_assert_true (res);
g_assert_no_error (error);
}
else
#endif
{
g_assert_false (res);
g_assert_error (error, G_IO_ERROR, G_IO_ERROR_PERMISSION_DENIED);
@@ -1121,6 +1189,9 @@ test_make_directory_with_parents (gconstpointer test_data)
GFile *root, *child, *grandchild, *greatgrandchild;
gboolean res;
GError *error = NULL;
#ifdef G_OS_UNIX
gboolean have_cap_dac_override = check_cap_dac_override (test_data);
#endif
g_assert_nonnull (test_data);
@@ -1171,9 +1242,16 @@ test_make_directory_with_parents (gconstpointer test_data)
if (!posix_compat)
goto out;
#ifndef G_PLATFORM_WIN32
if (getuid() == 0) /* permissions are ignored for root */
goto out;
#ifdef G_OS_UNIX
/* Permissions are ignored if we have CAP_DAC_OVERRIDE or equivalent,
* and in particular if we're root */
if (have_cap_dac_override)
{
g_test_skip ("Unable to exercise g_file_make_directory_with_parents "
"failing with EACCES: we probably have "
"CAP_DAC_OVERRIDE");
goto out;
}
#endif
g_file_make_directory (child, NULL, NULL);
@@ -1343,7 +1421,7 @@ main (int argc, char *argv[])
}
g_option_context_free (context);
/* Write test - clean target directory first */
/* this can be also considered as a test - enumerate + delete */
if (write_test || only_create_struct)