luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-07-31 22:23:39 +02:00
Code Issues Packages Projects Releases Wiki Activity

Avoid property notification during g_object_set

Browse Source 
If we have no nontrivial notify vfunc, and no signal
handlers for notify, we don't need to maintain the
notify queue. No need to notify if nobody's listening.
This commit is contained in:
Matthias Clasen
2022-05-15 07:56:43 -04:00
parent 701ef1191b
commit bbd170a223
1 changed files with 18 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
gobject/gobject.c
View File

@@ -1343,7 +1343,8 @@ g_object_notify_by_spec_internal (GObject *object,
if (redirected != NULL) if (redirected != NULL)
pspec = redirected; pspec = redirected;
if (pspec != NULL) if (pspec != NULL &&
_g_object_has_notify_handler (object))
{ {
GObjectNotifyQueue *nqueue; GObjectNotifyQueue *nqueue;
@@ -2510,7 +2511,7 @@ g_object_setv (GObject *object,
const GValue values[]) const GValue values[])
{ {
guint i; guint i;
GObjectNotifyQueue *nqueue; GObjectNotifyQueue *nqueue = NULL;
GParamSpec *pspec; GParamSpec *pspec;
GType obj_type; GType obj_type;
@@ -2521,7 +2522,10 @@ g_object_setv (GObject *object,
g_object_ref (object); g_object_ref (object);
obj_type = G_OBJECT_TYPE (object); obj_type = G_OBJECT_TYPE (object);
nqueue = g_object_notify_queue_freeze (object, FALSE);
if (_g_object_has_notify_handler (object))
nqueue = g_object_notify_queue_freeze (object, FALSE);
for (i = 0; i < n_properties; i++) for (i = 0; i < n_properties; i++)
{ {
pspec = g_param_spec_pool_lookup (pspec_pool, names[i], obj_type, TRUE); pspec = g_param_spec_pool_lookup (pspec_pool, names[i], obj_type, TRUE);
@@ -2532,7 +2536,9 @@ g_object_setv (GObject *object,
object_set_property (object, pspec, &values[i], nqueue); object_set_property (object, pspec, &values[i], nqueue);
} }
g_object_notify_queue_thaw (object, nqueue); if (nqueue)
g_object_notify_queue_thaw (object, nqueue);
g_object_unref (object); g_object_unref (object);
} }
@@ -2550,13 +2556,15 @@ g_object_set_valist (GObject *object,
const gchar *first_property_name, const gchar *first_property_name,
va_list var_args) va_list var_args)
{ {
GObjectNotifyQueue *nqueue; GObjectNotifyQueue *nqueue = NULL;
const gchar *name; const gchar *name;
g_return_if_fail (G_IS_OBJECT (object)); g_return_if_fail (G_IS_OBJECT (object));
g_object_ref (object); g_object_ref (object);
nqueue = g_object_notify_queue_freeze (object, FALSE);
if (_g_object_has_notify_handler (object))
nqueue = g_object_notify_queue_freeze (object, FALSE);
name = first_property_name; name = first_property_name;
while (name) while (name)
@@ -2594,7 +2602,9 @@ g_object_set_valist (GObject *object,
name = va_arg (var_args, gchar*); name = va_arg (var_args, gchar*);
} }
g_object_notify_queue_thaw (object, nqueue); if (nqueue)
g_object_notify_queue_thaw (object, nqueue);
g_object_unref (object); g_object_unref (object);
} }