luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-03-03 14:42:10 +01:00
Code Issues Packages Projects Releases Wiki Activity

gobject: add 'explicit notify' GParamSpec flag

Browse Source 
Add a flag to prevent the automatic emission of the "notify" signal
during g_object_set_property().

If this flag is set then the class must explicitly emit the notify
for themselves.  This is already standard practice on most classes, but
we cannot simply remove the existing behaviour because there are surely
many cases where it is needed.

https://bugzilla.gnome.org/show_bug.cgi?id=731200
This commit is contained in:
Ryan Lortie 2014-06-04 08:59:50 -04:00
parent dc496ac764
commit bbdb2345fc
2 changed files with 13 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
gobject/gobject.c
View File

@ -1380,14 +1380,17 @@ object_set_property (GObject *object,
} }
else else
{ {
GParamSpec *notify_pspec;
class->set_property (object, param_id, &tmp_value, pspec); class->set_property (object, param_id, &tmp_value, pspec);
notify_pspec = get_notify_pspec (pspec); if (~pspec->flags & G_PARAM_EXPLICIT_NOTIFY)
{
GParamSpec *notify_pspec;
if (notify_pspec != NULL) notify_pspec = get_notify_pspec (pspec);
g_object_notify_queue_add (object, nqueue, notify_pspec);
if (notify_pspec != NULL)
g_object_notify_queue_add (object, nqueue, notify_pspec);
}
} }
g_value_unset (&tmp_value); g_value_unset (&tmp_value);
} }

5
gobject/gparam.h
View File

@ -130,6 +130,10 @@ G_BEGIN_DECLS
* parameter is guaranteed to remain valid and * parameter is guaranteed to remain valid and
* unmodified for the lifetime of the parameter. * unmodified for the lifetime of the parameter.
* Since 2.8 * Since 2.8
* @G_PARAM_EXPLICIT_NOTIFY: calls to g_object_set_property() for this
* property will not automatically result in a "notify" signal being
* emitted: the implementation must call g_object_notify() themselves
* in case the property actually changes. Since: 2.42.
* @G_PARAM_PRIVATE: internal * @G_PARAM_PRIVATE: internal
* @G_PARAM_DEPRECATED: the parameter is deprecated and will be removed * @G_PARAM_DEPRECATED: the parameter is deprecated and will be removed
* in a future version. A warning will be generated if it is used * in a future version. A warning will be generated if it is used
@ -153,6 +157,7 @@ typedef enum
#endif #endif
G_PARAM_STATIC_NICK = 1 << 6, G_PARAM_STATIC_NICK = 1 << 6,
G_PARAM_STATIC_BLURB = 1 << 7, G_PARAM_STATIC_BLURB = 1 << 7,
G_PARAM_EXPLICIT_NOTIFY = 1 << 8,
/* User defined flags go up to 30 */ /* User defined flags go up to 30 */
G_PARAM_DEPRECATED = 1 << 31 G_PARAM_DEPRECATED = 1 << 31
} GParamFlags; } GParamFlags;