From bc01109618009ad748abdc58bdc0c64891b84db0 Mon Sep 17 00:00:00 2001 From: Philip Withnall Date: Tue, 21 Apr 2015 23:57:17 +0100 Subject: [PATCH] gdbusmessage: Fix a minor memory leak on an error path MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit If g_dbus_message_to_blob() fails at all, it will leak its mbuf. Spotted by running the gdbus-serialization test under Valgrind — so there is a justification for leak-free tests after all! --- gio/gdbusmessage.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/gio/gdbusmessage.c b/gio/gdbusmessage.c index 766609ec8..d9d8f3726 100644 --- a/gio/gdbusmessage.c +++ b/gio/gdbusmessage.c @@ -2745,6 +2745,9 @@ g_dbus_message_to_blob (GDBusMessage *message, ret = (guchar *)mbuf.data; out: + if (ret == NULL) + g_free (mbuf.data); + return ret; }