From bc81b2c4cbdcc24af02105910508b1580e264a9a Mon Sep 17 00:00:00 2001 From: Philip Withnall Date: Fri, 12 Apr 2019 17:08:22 +0100 Subject: [PATCH] tests: Unmark several gdbus-* tests as flaky MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit After repeated local testing, I can’t reproduce failures with them: meson test --repeat 5000 gdbus-auth meson test --repeat 5000 gdbus-bz627724 meson test --repeat 5000 gdbus-connection The FreeBSD failures from pthread calls mentioned in #1614 should probably manifest as use-after-free for GMutex or pthread_mutex_t on Linux. Failing that, I haven’t seen any relevant FreeBSD failures on CI for at least a month, so if it’s not fixed, the chances of debugging are very low. Signed-off-by: Philip Withnall https://gitlab.gnome.org/GNOME/glib/issues/1614 --- gio/tests/meson.build | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/gio/tests/meson.build b/gio/tests/meson.build index a3efd33ab..e774721b4 100644 --- a/gio/tests/meson.build +++ b/gio/tests/meson.build @@ -248,10 +248,10 @@ if host_machine.system() != 'windows' 'extra_sources' : extra_sources, 'suite' : ['slow'], }, - 'gdbus-auth' : {'extra_sources' : extra_sources, 'suite': ['flaky']}, - 'gdbus-bz627724' : {'extra_sources' : extra_sources, 'suite': ['flaky']}, + 'gdbus-auth' : {'extra_sources' : extra_sources}, + 'gdbus-bz627724' : {'extra_sources' : extra_sources}, 'gdbus-close-pending' : {'extra_sources' : extra_sources}, - 'gdbus-connection' : {'extra_sources' : extra_sources, 'suite': ['flaky']}, + 'gdbus-connection' : {'extra_sources' : extra_sources}, 'gdbus-connection-loss' : {'extra_sources' : extra_sources}, 'gdbus-connection-slow' : {'extra_sources' : extra_sources}, 'gdbus-error' : {'extra_sources' : extra_sources},