luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2024-11-11 20:06:18 +01:00
Code Issues Packages Projects Releases Wiki Activity

main: document notify function gets called during g_source_destroy()

Browse Source 
This seems non-obvious to me. Document it.

It also seems important to know, because it means that the data pointer
might already be destroyed, before the source is unreferenced for good.
For example, if the data pointer keeps a reference to the GSource,
and it might seem sensible to call:

    g_source_destroy(data->source);
    g_source_unref(data->source); /* <<< data is already destroyed? */

This leads to a crash, if the source was attached to a context.
This commit is contained in:
Thomas Haller 2021-04-18 21:01:19 +02:00
parent b0157af9a6
commit bdd6b753ca
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
glib/gmain.c
View File

@ -1370,6 +1370,10 @@ g_source_destroy_internal (GSource *source,
* *
* This function is safe to call from any thread, regardless of which thread * This function is safe to call from any thread, regardless of which thread
* the #GMainContext is running in. * the #GMainContext is running in.
*
* If the source is currently attached to a #GMainContext, destroying it
* will effectively unset the callback similar to calling g_source_set_callback().
* This can mean, that the data's #GDestroyNotify gets called right away.
*/ */
void void
g_source_destroy (GSource *source) g_source_destroy (GSource *source)
@ -1761,6 +1765,9 @@ g_source_set_callback_indirect (GSource *source,
* It is safe to call this function multiple times on a source which has already * It is safe to call this function multiple times on a source which has already
* been attached to a context. The changes will take effect for the next time * been attached to a context. The changes will take effect for the next time
* the source is dispatched after this call returns. * the source is dispatched after this call returns.
*
* Note that g_source_destroy() for a currently attached source has the effect
* of also unsetting the callback.
**/ **/
void void
g_source_set_callback (GSource *source, g_source_set_callback (GSource *source,