From c2a828772b30a0c10a8f4b15d7fc841f26b807b8 Mon Sep 17 00:00:00 2001 From: Chun-wei Fan Date: Tue, 18 Mar 2014 12:54:10 +0800 Subject: [PATCH] gio/gtestdbus.c: Fix write_config_file() for Windows Windows does not like g_unlink() to be called on files whose file descriptor is still open, so doing that would cause a permission denied error. Since the fd is not used in that function after acquiring the temp file, close it earlier before g_file_set_contents(), so that it can complete successfully. This fixes a number of GTK+ tests on Windows. https://bugzilla.gnome.org/show_bug.cgi?id=719344 --- gio/gtestdbus.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/gio/gtestdbus.c b/gio/gtestdbus.c index 17a949675..4b51d29bb 100644 --- a/gio/gtestdbus.c +++ b/gio/gtestdbus.c @@ -566,13 +566,12 @@ write_config_file (GTestDBus *self) " \n" "\n"); + close (fd); g_file_set_contents (path, contents->str, contents->len, &error); g_assert_no_error (error); g_string_free (contents, TRUE); - close (fd); - return path; }