luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-02-23 18:52:09 +01:00
Code Issues Packages Projects Releases Wiki Activity

Take a reference on the gio file monitors while signaling pending file changes

Browse Source 
It was possible for a signal handler to remove the last reference and
dispose the monitor.  If there were remaining pending_file_changes they
tried to dereference the disposed monitor.

This patch simply calls g_object_{ref,unref} around the loop that signals
the changes.
This commit is contained in:
Robert Bragg 2009-05-06 09:20:43 +01:00 committed by Matthias Clasen
parent eb6c59bc48
commit c2ed17a1a7
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
gio/gfilemonitor.c
View File

@ -364,6 +364,7 @@ emit_cb (gpointer data)
monitor->priv->pending_file_changes = NULL; monitor->priv->pending_file_changes = NULL;
monitor->priv->pending_file_change_id = 0; monitor->priv->pending_file_change_id = 0;
g_object_ref (monitor);
for (iter = pending; iter; iter = iter->next) for (iter = pending; iter; iter = iter->next)
{ {
FileChange *change = iter->data; FileChange *change = iter->data;
@ -372,6 +373,8 @@ emit_cb (gpointer data)
file_change_free (change); file_change_free (change);
} }
g_slist_free (pending); g_slist_free (pending);
g_object_unref (monitor);
return FALSE; return FALSE;
} }