luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-10-31 00:12:19 +01:00
Code Issues Packages Projects Releases Wiki Activity

gfilenamecompleter: Fix g_object_unref() of undefined value

Browse Source 
If the first `goto out` is taken, `file` has not yet been initialised,
but `g_clear_object (&file)` is called on it, and things get unhappy.

Fix that by following standard convention and initialising
‘autoptr’-like variables at declaration time.

Spotted by scan-build in
https://gitlab.gnome.org/GNOME/glib/-/jobs/5321883.

Signed-off-by: Philip Withnall <pwithnall@gnome.org>
This commit is contained in:
Philip Withnall
2025-07-22 12:57:14 +01:00
parent f5a5c2a9b3
commit c537ffd4a5
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gio/gfilenamecompleter.c
View File

@@ -342,7 +342,7 @@ init_completion (GFilenameCompleter *completer,
char **basename_out) char **basename_out)
{ {
gboolean should_escape; gboolean should_escape;
GFile *file, *parent; GFile *file = NULL, *parent = NULL;
char *basename; char *basename;
char *t; char *t;
size_t len; size_t len;