luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2024-12-25 15:06:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

gnetworkmonitornm: Set a GError properly on an error handling path

Browse Source 
All the other initialisation failure paths set a GError, but this one
didn’t. Set a GError to avoid breaking the invariant that returning
FALSE should always have a GError set.

Signed-off-by: Philip Withnall <withnall@endlessm.com>

https://gitlab.gnome.org/GNOME/glib/issues/1523
This commit is contained in:
Philip Withnall 2018-09-13 10:25:05 +01:00
parent 5bc35a7245
commit c5761146bc
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
gio/gnetworkmonitornm.c
View File

@ -309,6 +309,8 @@ g_network_monitor_nm_initable_init (GInitable *initable,
if (!name_owner) if (!name_owner)
{ {
g_set_error (error, G_IO_ERROR, G_IO_ERROR_FAILED,
_("NetworkManager not running"));
g_object_unref (proxy); g_object_unref (proxy);
return FALSE; return FALSE;
} }