luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2024-12-25 23:16:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

gsignal: add assert on closure invalidate path

Browse Source 
It's theoretically possible that we could have a case where this would
actually return NULL, but it's difficult to imagine a valid program that
would contain such a case.

Add an explicit assert here to quiet up static analysis.

See the bug for more discussion.

Coverity CID: 1159477

https://bugzilla.gnome.org/show_bug.cgi?id=730296
This commit is contained in:
Ryan Lortie 2014-06-06 12:15:22 -04:00 committed by Philip Withnall
parent ed78f30c5e
commit c64b6da33c
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
gobject/gsignal.c
View File

@ -3804,6 +3804,8 @@ invalid_closure_notify (gpointer instance,
SIGNAL_LOCK ();
handler = handler_lookup (instance, 0, closure, &signal_id);
/* See https://bugzilla.gnome.org/show_bug.cgi?id=730296 for discussion about this... */
g_assert (handler != NULL);
g_assert (handler->closure == closure);
handler->sequential_number = 0;