luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2024-12-27 07:56:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

Check for prefix/suffix smaller than string and check for non-inlined function

Browse Source 
* Add a test to check that smaller string than prefix/suffix are
  handled in g_str_has_*() functions.

* Add a tests on macro prefixed function and ensure that function
  itselves are tested as well.
This commit is contained in:
Emmanuel Fleury 2022-08-19 16:47:30 +02:00
parent bbd3ad8c00
commit c7f24df744
1 changed files with 90 additions and 45 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

135
glib/tests/strfuncs.c
View File

@ -1200,89 +1200,132 @@ test_strdelimit (void)
g_free (string); g_free (string);
} }
/* Testing g_str_has_prefix() */ /* Testing g_str_has_prefix() function avoiding the optimizing macro */
static void static void
test_has_prefix (void) test_has_prefix (void)
{ {
gboolean res;
if (g_test_undefined ()) if (g_test_undefined ())
{ {
g_test_expect_message (G_LOG_DOMAIN, G_LOG_LEVEL_CRITICAL, g_test_expect_message (G_LOG_DOMAIN, G_LOG_LEVEL_CRITICAL,
"*assertion*!= NULL*"); "*assertion*!= NULL*");
res = g_str_has_prefix ("foo", NULL); g_assert_false ((g_str_has_prefix) ("foo", NULL));
g_test_assert_expected_messages (); g_test_assert_expected_messages ();
g_assert_false (res);
g_test_expect_message (G_LOG_DOMAIN, G_LOG_LEVEL_CRITICAL, g_test_expect_message (G_LOG_DOMAIN, G_LOG_LEVEL_CRITICAL,
"*assertion*!= NULL*"); "*assertion*!= NULL*");
res = g_str_has_prefix (NULL, "foo"); g_assert_false ((g_str_has_prefix) (NULL, "foo"));
g_test_assert_expected_messages (); g_test_assert_expected_messages ();
g_assert_false (res);
} }
res = g_str_has_prefix ("foo", "bar"); /* Having a string smaller than the prefix */
g_assert_cmpint (res, ==, FALSE); g_assert_false ((g_str_has_prefix) ("aa", "aaa"));
res = g_str_has_prefix ("foo", "foobar"); /* Negative tests */
g_assert_cmpint (res, ==, FALSE); g_assert_false ((g_str_has_prefix) ("foo", "bar"));
g_assert_false ((g_str_has_prefix) ("foo", "foobar"));
g_assert_false ((g_str_has_prefix) ("foobar", "bar"));
res = g_str_has_prefix ("foobar", "bar"); /* Positive tests */
g_assert_cmpint (res, ==, FALSE); g_assert_true ((g_str_has_prefix) ("foobar", "foo"));
g_assert_true ((g_str_has_prefix) ("foo", ""));
res = g_str_has_prefix ("foobar", "foo"); g_assert_true ((g_str_has_prefix) ("foo", "foo"));
g_assert_cmpint (res, ==, TRUE); g_assert_true ((g_str_has_prefix) ("", ""));
res = g_str_has_prefix ("foo", "");
g_assert_cmpint (res, ==, TRUE);
res = g_str_has_prefix ("foo", "foo");
g_assert_cmpint (res, ==, TRUE);
res = g_str_has_prefix ("", "");
g_assert_cmpint (res, ==, TRUE);
} }
/* Testing g_str_has_prefix() optimized macro */
static void
test_has_prefix_macro (void)
{
if (g_test_undefined ())
{
g_test_expect_message (G_LOG_DOMAIN, G_LOG_LEVEL_CRITICAL,
"*assertion*!= NULL*");
g_assert_false (g_str_has_prefix ("foo", NULL));
g_test_assert_expected_messages ();
g_test_expect_message (G_LOG_DOMAIN, G_LOG_LEVEL_CRITICAL,
"*assertion*!= NULL*");
g_assert_false (g_str_has_prefix (NULL, "foo"));
g_test_assert_expected_messages ();
}
/* Having a string smaller than the prefix */
g_assert_false (g_str_has_prefix ("aa", "aaa"));
/* Negative tests */
g_assert_false (g_str_has_prefix ("foo", "bar"));
g_assert_false (g_str_has_prefix ("foo", "foobar"));
g_assert_false (g_str_has_prefix ("foobar", "bar"));
/* Positive tests */
g_assert_true (g_str_has_prefix ("foobar", "foo"));
g_assert_true (g_str_has_prefix ("foo", ""));
g_assert_true (g_str_has_prefix ("foo", "foo"));
g_assert_true (g_str_has_prefix ("", ""));
}
/* Testing g_str_has_suffix() function avoiding the optimizing macro */
static void static void
test_has_suffix (void) test_has_suffix (void)
{ {
gboolean res;
if (g_test_undefined ()) if (g_test_undefined ())
{ {
g_test_expect_message (G_LOG_DOMAIN, G_LOG_LEVEL_CRITICAL, g_test_expect_message (G_LOG_DOMAIN, G_LOG_LEVEL_CRITICAL,
"*assertion*!= NULL*"); "*assertion*!= NULL*");
res = g_str_has_suffix ("foo", NULL); g_assert_false ((g_str_has_suffix) ("foo", NULL));
g_test_assert_expected_messages (); g_test_assert_expected_messages ();
g_assert_false (res);
g_test_expect_message (G_LOG_DOMAIN, G_LOG_LEVEL_CRITICAL, g_test_expect_message (G_LOG_DOMAIN, G_LOG_LEVEL_CRITICAL,
"*assertion*!= NULL*"); "*assertion*!= NULL*");
res = g_str_has_suffix (NULL, "foo"); g_assert_false ((g_str_has_suffix) (NULL, "foo"));
g_test_assert_expected_messages (); g_test_assert_expected_messages ();
g_assert_false (res);
} }
res = g_str_has_suffix ("foo", "bar"); /* Having a string smaller than the suffix */
g_assert_false (res); g_assert_false ((g_str_has_suffix) ("aa", "aaa"));
res = g_str_has_suffix ("bar", "foobar"); /* Negative tests */
g_assert_false (res); g_assert_false ((g_str_has_suffix) ("foo", "bar"));
g_assert_false ((g_str_has_suffix) ("bar", "foobar"));
g_assert_false ((g_str_has_suffix) ("foobar", "foo"));
res = g_str_has_suffix ("foobar", "foo"); /* Positive tests */
g_assert_false (res); g_assert_true ((g_str_has_suffix) ("foobar", "bar"));
g_assert_true ((g_str_has_suffix) ("foo", ""));
g_assert_true ((g_str_has_suffix) ("foo", "foo"));
g_assert_true ((g_str_has_suffix) ("", ""));
}
res = g_str_has_suffix ("foobar", "bar"); /* Testing g_str_has_prefix() optimized macro */
g_assert_true (res); static void
test_has_suffix_macro (void)
{
if (g_test_undefined ())
{
g_test_expect_message (G_LOG_DOMAIN, G_LOG_LEVEL_CRITICAL,
"*assertion*!= NULL*");
g_assert_false (g_str_has_suffix ("foo", NULL));
g_test_assert_expected_messages ();
res = g_str_has_suffix ("foo", ""); g_test_expect_message (G_LOG_DOMAIN, G_LOG_LEVEL_CRITICAL,
g_assert_true (res); "*assertion*!= NULL*");
g_assert_false (g_str_has_suffix (NULL, "foo"));
g_test_assert_expected_messages ();
}
res = g_str_has_suffix ("foo", "foo"); /* Having a string smaller than the suffix */
g_assert_true (res); g_assert_false (g_str_has_suffix ("aa", "aaa"));
res = g_str_has_suffix ("", ""); /* Negative tests */
g_assert_true (res); g_assert_false (g_str_has_suffix ("foo", "bar"));
g_assert_false (g_str_has_suffix ("bar", "foobar"));
g_assert_false (g_str_has_suffix ("foobar", "foo"));
/* Positive tests */
g_assert_true (g_str_has_suffix ("foobar", "bar"));
g_assert_true (g_str_has_suffix ("foo", ""));
g_assert_true (g_str_has_suffix ("foo", "foo"));
g_assert_true (g_str_has_suffix ("", ""));
} }
static void static void
@ -2587,7 +2630,9 @@ main (int argc,
g_test_add_func ("/strfuncs/ascii_strtod", test_ascii_strtod); g_test_add_func ("/strfuncs/ascii_strtod", test_ascii_strtod);
g_test_add_func ("/strfuncs/bounds-check", test_bounds); g_test_add_func ("/strfuncs/bounds-check", test_bounds);
g_test_add_func ("/strfuncs/has-prefix", test_has_prefix); g_test_add_func ("/strfuncs/has-prefix", test_has_prefix);
g_test_add_func ("/strfuncs/has-prefix-macro", test_has_prefix_macro);
g_test_add_func ("/strfuncs/has-suffix", test_has_suffix); g_test_add_func ("/strfuncs/has-suffix", test_has_suffix);
g_test_add_func ("/strfuncs/has-suffix-macro", test_has_suffix_macro);
g_test_add_func ("/strfuncs/memdup", test_memdup); g_test_add_func ("/strfuncs/memdup", test_memdup);
g_test_add_func ("/strfuncs/memdup2", test_memdup2); g_test_add_func ("/strfuncs/memdup2", test_memdup2);
g_test_add_func ("/strfuncs/set_str", test_set_str); g_test_add_func ("/strfuncs/set_str", test_set_str);