luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-10-23 21:42:16 +02:00
Code Issues Packages Projects Releases Wiki Activity

glocalfile: Fix an uninitialized variable

Browse Source 
Clang says:

../gio/glocalfile.c:2090:11: warning: variable 'success' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
      if (trashdir == NULL)
          ^~~~~~~~~~~~~~~~
../gio/glocalfile.c:2133:12: note: uninitialized use occurs here
      if (!success)
           ^~~~~~~
../gio/glocalfile.c:2090:7: note: remove the 'if' if its condition is always true
      if (trashdir == NULL)
      ^~~~~~~~~~~~~~~~~~~~~
../gio/glocalfile.c:2041:23: note: initialize the variable 'success' to silence this warning
      gboolean success;
                      ^
                       = 0

So just do that.
This commit is contained in:
Timm Bäder
2021-01-06 17:36:32 +01:00
parent 8a5cc02142
commit c983ded09f
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gio/glocalfile.c
View File

@@ -2038,7 +2038,7 @@ g_local_file_trash (GFile *file,
{ {
uid_t uid; uid_t uid;
char uid_str[32]; char uid_str[32];
gboolean success; gboolean success = FALSE;
uid = geteuid (); uid = geteuid ();
g_snprintf (uid_str, sizeof (uid_str), "%lu", (unsigned long)uid); g_snprintf (uid_str, sizeof (uid_str), "%lu", (unsigned long)uid);