From cb185c22bcfc2cfeb878223a0234d13600b23aa8 Mon Sep 17 00:00:00 2001 From: Simon McVittie Date: Wed, 18 Sep 2024 14:02:46 +0100 Subject: [PATCH] GDBus: Don't log a message for G_DBUS_CONNECTION_FLAGS_CROSS_NAMESPACE This was intended to make it feasible to debug connection failures where a modern GDBus client connects to a GDBusServer that is missing glib!2826, but those GDBusServers should be increasingly rare: we have had the fixed version of GDBusServer for 5 GNOME stable releases (2 years), long enough to get into stable releases of Debian and Ubuntu and a service-pack release of SUSE. This debug message can be very noisy, especially when unit-testing GLib code (which is frequently done with G_MESSAGES_DEBUG=all) or when a third-party GLogFunc ignores the log_level parameter and logs all messages as though they indicated a serious problem. I think it has served its purpose now. Signed-off-by: Simon McVittie --- gio/gdbusauthmechanismexternal.c | 1 - 1 file changed, 1 deletion(-) diff --git a/gio/gdbusauthmechanismexternal.c b/gio/gdbusauthmechanismexternal.c index 3df55b9d2..f7cb1b1b9 100644 --- a/gio/gdbusauthmechanismexternal.c +++ b/gio/gdbusauthmechanismexternal.c @@ -382,7 +382,6 @@ mechanism_client_initiate (GDBusAuthMechanism *mechanism, * no way to express an empty authorization identity this way. * Instead, we'll reply to the server's first (empty) challenge * with an empty authorization identity in our first response. */ - g_debug ("Using cross-namespace EXTERNAL authentication (this will deadlock if server is GDBus < 2.73.3)"); } else {