luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-04-28 10:06:53 +02:00
Code Issues Packages Projects Releases Wiki Activity

convert: Improve test coverage

Browse Source 
Add a test that excercises the 'no conversion' code path.
This uncovered that we don't treat errno properly in this path,
and as a consequence, the returned error code is unreliable.
This commit is contained in:
Matthias Clasen 2012-04-07 11:23:47 -04:00
parent 7d489acecc
commit cbeecdc4ae
1 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
glib/tests/convert.c
View File

@ -685,11 +685,28 @@ test_filename_display (void)
g_free (display); g_free (display);
} }
static void
test_no_conv (void)
{
gchar *in = "";
gchar *out G_GNUC_UNUSED;
gsize bytes_read = 0;
gsize bytes_written = 0;
GError *error = NULL;
out = g_convert (in, -1, "XXX", "UVZ",
&bytes_read, &bytes_written, &error);
/* error code is unreliable, since we mishandle errno there */
g_assert (error && error->domain == G_CONVERT_ERROR);
}
int int
main (int argc, char *argv[]) main (int argc, char *argv[])
{ {
g_test_init (&argc, &argv, NULL); g_test_init (&argc, &argv, NULL);
g_test_add_func ("/conversion/no-conv", test_no_conv);
g_test_add_func ("/conversion/iconv-state", test_iconv_state); g_test_add_func ("/conversion/iconv-state", test_iconv_state);
g_test_add_func ("/conversion/illegal-sequence", test_one_half); g_test_add_func ("/conversion/illegal-sequence", test_one_half);
g_test_add_func ("/conversion/byte-order", test_byte_order); g_test_add_func ("/conversion/byte-order", test_byte_order);