luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-08-09 18:54:04 +02:00
Code Issues Packages Projects Releases Wiki Activity

guri: Clear return values on error from g_uri_params_iter_next()

Browse Source 
This reduces the chance of the caller accidentally double-freeing or
use-after-free-ing something.

Signed-off-by: Philip Withnall <withnall@endlessm.com>
This commit is contained in:
Philip Withnall
2020-08-06 14:03:54 +01:00
parent 83597b9e57
commit ceda9755de
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
glib/guri.c
View File

@@ -1973,6 +1973,12 @@ g_uri_params_iter_next (GUriParamsIter *iter,
g_return_val_if_fail (iter != NULL, FALSE); g_return_val_if_fail (iter != NULL, FALSE);
g_return_val_if_fail (error == NULL || *error == NULL, FALSE); g_return_val_if_fail (error == NULL || *error == NULL, FALSE);
/* Pre-clear these in case of failure or finishing. */
if (attribute)
*attribute = NULL;
if (value)
*value = NULL;
if (ri->attr >= ri->end) if (ri->attr >= ri->end)
return FALSE; return FALSE;