From d1eb463ce24fc6044516830aa3ea01b60e212e16 Mon Sep 17 00:00:00 2001 From: Philip Withnall Date: Wed, 1 Nov 2023 16:03:08 +0000 Subject: [PATCH] gio-tool: Remove unnecessary exit() call MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit All the calls to `usage()` are immediately followed by a `return` from `main()` which sets an appropriate exit status. Calling `exit()` early means that running `gio --help` returns exit status 1, which is incorrect — it should (by convention) return 0. Signed-off-by: Philip Withnall --- gio/gio-tool.c | 1 - 1 file changed, 1 deletion(-) diff --git a/gio/gio-tool.c b/gio/gio-tool.c index a9701090d..855cf85cb 100644 --- a/gio/gio-tool.c +++ b/gio/gio-tool.c @@ -247,7 +247,6 @@ usage (void) g_printerr (" tree %s\n", _("Lists the contents of locations in a tree")); g_printerr ("\n"); g_printerr (_("Use %s to get detailed help.\n"), "“gio help COMMAND”"); - exit (1); } int