From d50caa8fb9b747a240b72ffc10f406fface5998b Mon Sep 17 00:00:00 2001 From: Philip Withnall Date: Fri, 28 Jun 2019 12:57:00 +0100 Subject: [PATCH] =?UTF-8?q?tests:=20Don=E2=80=99t=20spawn=20test=20process?= =?UTF-8?q?es=20via=20the=20terminal=20in=20the=20appinfo=20test?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit There seems to be no reason to do so, and since the `appinfo` test was ported to use `G_TEST_OPTION_ISOLATE_DIRS`, it has been causing coredumps to accumulate. `gnome-terminal` was chosen as the terminal, but it couldn’t find its GSettings schemas due to all the XDG environment variables being cleared to `/dev/null` by `G_TEST_OPTION_ISOLATE_DIRS`. In order to keep using `gnome-terminal` as a subprocess in the tests, we’d need to explicitly set up its environment so it can load the right GSettings schemas. That’s a lot of work for not much gain. Signed-off-by: Philip Withnall Helps: #436 --- gio/tests/appinfo-test.desktop.in | 2 +- gio/tests/appinfo.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/gio/tests/appinfo-test.desktop.in b/gio/tests/appinfo-test.desktop.in index bc292b135..1f6ff7144 100644 --- a/gio/tests/appinfo-test.desktop.in +++ b/gio/tests/appinfo-test.desktop.in @@ -9,7 +9,7 @@ Comment=GAppInfo example Comment[de]=GAppInfo Beispiel Exec=@installed_tests_dir@/appinfo-test --option %U %i --name %c --filename %k %m %% Icon=testicon.svg -Terminal=true +Terminal=false StartupNotify=true StartupWMClass=appinfo-class MimeType=image/png;image/jpeg; diff --git a/gio/tests/appinfo.c b/gio/tests/appinfo.c index f13698d70..4fec6b379 100644 --- a/gio/tests/appinfo.c +++ b/gio/tests/appinfo.c @@ -87,7 +87,7 @@ test_launch_no_app_id (void) "Comment=GAppInfo example\n" "Comment[de]=GAppInfo Beispiel\n" "Icon=testicon.svg\n" - "Terminal=true\n" + "Terminal=false\n" "StartupNotify=true\n" "StartupWMClass=appinfo-class\n" "MimeType=image/png;image/jpeg;\n"