luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-03-28 18:40:03 +01:00
Code Issues Packages Projects Releases Wiki Activity

Revert "GThread: Don't g_error() if setting the thread scheduler settings fails"

Browse Source 
This reverts commit 965061797d74847d2e2d1237bb7a63328608e28c.

We are having trouble tracking down the cause of #2769. When the bug
occurs, we fail to set scheduler settings for the new thread pool
thread. This can have serious consequences and should not be ignored. In
retrospect, making this a critical instead of a fatal error has made it
more difficult to notice, debug, and fix. This operation needs to always
work, so let's crash when it fails.

This does not fix #2769, but will hopefully help.
This commit is contained in:
Michael Catanzaro 2022-12-12 12:39:46 -06:00
parent 4d172a2015
commit d900d0efce
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
glib/gthread-posix.c
View File

@ -1261,7 +1261,7 @@ linux_pthread_proxy (void *data)
res = syscall (SYS_sched_setattr, tid, thread->scheduler_settings->attr, flags);
errsv = errno;
if (res == -1)
g_critical ("Failed to set scheduler settings: %s", g_strerror (errsv));
g_error ("Failed to set scheduler settings: %s", g_strerror (errsv));
}
return thread->proxy (data);