luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-11-04 18:18:56 +01:00
Code Issues Packages Projects Releases Wiki Activity

gmappedfile: Avoid calling mmap() with a length of zero

Browse Source 
We were previously relying on it returning `EINVAL` so we could return
an error message, but scan-build doesn’t like that, so let’s just
explicitly return the same error anyway to shut scan-build up.

Signed-off-by: Philip Withnall <pwithnall@gnome.org>
This commit is contained in:
Philip Withnall
2025-10-17 00:03:04 +01:00
parent ca1e32f067
commit daf3bd7f0a
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
glib/gmappedfile.c
View File

@@ -155,6 +155,13 @@ mapped_file_new_from_fd (int fd,
file->contents = NULL; file->contents = NULL;
return file; return file;
} }
else if (st.st_size == 0)
{
errno = EINVAL;
file->length = 0;
file->contents = MAP_FAILED;
goto error;
}
file->contents = MAP_FAILED; file->contents = MAP_FAILED;
@@ -192,7 +199,7 @@ mapped_file_new_from_fd (int fd,
} }
#endif #endif
error:
if (file->contents == MAP_FAILED) if (file->contents == MAP_FAILED)
{ {
if (error != NULL) if (error != NULL)