luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-04-01 21:33:09 +02:00
Code Issues Packages Projects Releases Wiki Activity

gdatalist: rework g_datalist_clear() to return early

Browse Source 
g_datalist_unlock() is probably faster than g_datalist_unlock_and_set().
Move the "if (data)" check (that we anyway had) earlier, so we can
call g_datalist_unlock() and return early.
This commit is contained in:
Thomas Haller 2024-02-02 18:17:33 +01:00
parent 759ebf3663
commit dbae6b3484
1 changed files with 12 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
glib/gdataset.c
View File

@ -234,18 +234,22 @@ g_datalist_clear (GData **datalist)
g_return_if_fail (datalist != NULL); g_return_if_fail (datalist != NULL);
data = g_datalist_lock_and_get (datalist); data = g_datalist_lock_and_get (datalist);
if (!data)
{
g_datalist_unlock (datalist);
return;
}
g_datalist_unlock_and_set (datalist, NULL); g_datalist_unlock_and_set (datalist, NULL);
if (data) for (i = 0; i < data->len; i++)
{ {
for (i = 0; i < data->len; i++) if (data->data[i].data && data->data[i].destroy)
{ data->data[i].destroy (data->data[i].data);
if (data->data[i].data && data->data[i].destroy)
data->data[i].destroy (data->data[i].data);
}
g_free (data);
} }
g_free (data);
} }
/* HOLDS: g_dataset_global_lock */ /* HOLDS: g_dataset_global_lock */