luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2024-11-10 19:36:18 +01:00
Code Issues Packages Projects Releases Wiki Activity

Don't return FALSE when a pointer is expected

Browse Source 
Pointed out in bug 623956
This commit is contained in:
Matthias Clasen 2010-07-12 07:50:36 -04:00
parent 90285b0643
commit dc8cf867c8
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
glib/gvariant-parser.c
View File

@ -1218,7 +1218,7 @@ dictionary_get_value (AST *ast,
if (!(subvalue = ast_get_value (dict->keys[0], subtype, error))) if (!(subvalue = ast_get_value (dict->keys[0], subtype, error)))
{ {
g_variant_builder_clear (&builder); g_variant_builder_clear (&builder);
return FALSE; return NULL;
} }
g_variant_builder_add_value (&builder, subvalue); g_variant_builder_add_value (&builder, subvalue);
@ -1226,7 +1226,7 @@ dictionary_get_value (AST *ast,
if (!(subvalue = ast_get_value (dict->values[0], subtype, error))) if (!(subvalue = ast_get_value (dict->values[0], subtype, error)))
{ {
g_variant_builder_clear (&builder); g_variant_builder_clear (&builder);
return FALSE; return NULL;
} }
g_variant_builder_add_value (&builder, subvalue); g_variant_builder_add_value (&builder, subvalue);
@ -1256,14 +1256,14 @@ dictionary_get_value (AST *ast,
if (!(subvalue = ast_get_value (dict->keys[i], key, error))) if (!(subvalue = ast_get_value (dict->keys[i], key, error)))
{ {
g_variant_builder_clear (&builder); g_variant_builder_clear (&builder);
return FALSE; return NULL;
} }
g_variant_builder_add_value (&builder, subvalue); g_variant_builder_add_value (&builder, subvalue);
if (!(subvalue = ast_get_value (dict->values[i], val, error))) if (!(subvalue = ast_get_value (dict->values[i], val, error)))
{ {
g_variant_builder_clear (&builder); g_variant_builder_clear (&builder);
return FALSE; return NULL;
} }
g_variant_builder_add_value (&builder, subvalue); g_variant_builder_add_value (&builder, subvalue);
g_variant_builder_close (&builder); g_variant_builder_close (&builder);

2
glib/tests/markup-subparser.c
View File

@ -149,7 +149,7 @@ replay_parser_end (GMarkupParseContext *ctx,
g_string_free (string, TRUE); g_string_free (string, TRUE);
strings_allocated--; strings_allocated--;
return FALSE; return NULL;
} }
result = string->str; result = string->str;