luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-02-22 10:12:10 +01:00
Code Issues Packages Projects Releases Wiki Activity

gdbus-proxy test: Wait before asserting name owner has gone away

Browse Source 
GDBusConnection sends each signal to recipients in a separate idle
callback, and there's no particular guarantee about the order in which
they're scheduled or dispatched. For the NameOwnerChanged signal that
reports the name becoming unowned, it's possible that g_bus_watch_name()
gets its idle callback called before the GDBusProxy:g-name-owner
machinery has updated the name owner, in which case the assertion
will fail.

Fixing GNOME/glib#3268 introduced a new subscription to NameOwnerChanged
which can alter the order of delivery, particularly in the case where
G_DBUS_PROXY_FLAGS_NO_MATCH_RULE was used (as tested in
/gdbus/proxy/no-match-rule). The resulting test failure is intermittent,
but reliably appears within 100 repetitions of that test.

Fixes: 511c5f5b "tests: Wait for gdbus-testserver to die when killing it"
Signed-off-by: Simon McVittie <smcv@debian.org>
This commit is contained in:
Simon McVittie 2024-05-06 21:24:53 +01:00
parent 2b9ede6293
commit ded4e7e025
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gio/tests/gdbus-proxy.c
View File

@ -780,6 +780,12 @@ kill_test_service (GDBusConnection *connection)
while (!name_disappeared) while (!name_disappeared)
g_main_context_iteration (NULL, TRUE); g_main_context_iteration (NULL, TRUE);
/* GDBusConnection doesn't guarantee that different subscriptions to the
* same signal will get their callbacks scheduled in any particular order,
* so make sure they have all happened */
while (g_main_context_iteration (NULL, FALSE))
continue;
g_bus_unwatch_name (watch_id); g_bus_unwatch_name (watch_id);
#else #else
g_warning ("Can't kill com.example.TestService"); g_warning ("Can't kill com.example.TestService");