luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-05-17 11:11:58 +02:00
Code Issues Packages Projects Releases Wiki Activity

gdbus-tool: Don't repeatedly complete --signal

Browse Source 
In this situation:

  $ gdbus emit --session --object-path /org/foo/bar --sig<tab><tab><tab>

We will currently insert --signal three times.

We should only do that once.

https://bugzilla.gnome.org/show_bug.cgi?id=793597
This commit is contained in:
Iain Lane 2018-02-21 12:23:17 +00:00 committed by Philip Withnall
parent 2a2717062b
commit e2d9884958
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
gio/gdbus-tool.c
View File

@ -715,10 +715,17 @@ handle_emit (gint *argc,
} }
if (opt_emit_signal == NULL) if (opt_emit_signal == NULL)
{ {
/* don't keep repeatedly completing --signal */
if (request_completion) if (request_completion)
g_print ("--signal \n"); {
if (g_strcmp0 ("--signal", completion_prev) != 0)
g_print ("--signal \n");
}
else else
g_printerr (_("Error: Signal name is not specified\n")); {
g_printerr (_("Error: Signal name is not specified\n"));
}
goto out; goto out;
} }
if (request_completion && opt_emit_dest != NULL && opt_emit_object_path != NULL && if (request_completion && opt_emit_dest != NULL && opt_emit_object_path != NULL &&