luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-02-23 10:42:11 +01:00
Code Issues Packages Projects Releases Wiki Activity

gtlscertificate: Hold a ref on the root certificate when building chains

Browse Source 
This is unlikely to be a bug in practice, as the certificate pointed to
by `root` should have a ref held on it as the issuer of another
certificate in the chain.

However, we can’t guarantee that’s how the `GTlsCertificate`
implementation behaves, so keep a temporary ref on `root` until it’s no
longer needed.

Signed-off-by: Philip Withnall <pwithnall@endlessos.org>

Coverity CID: #1489985

(cherry-picked from commit 2c75c392eb76a12c3fd18b63508b1f971a3afecd)
This commit is contained in:
Philip Withnall 2022-06-21 12:10:06 +01:00 committed by Marco Trevisan (Treviño)
parent 8434e704f1
commit e52494c49b
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gio/gtlscertificate.c
View File

@ -624,7 +624,7 @@ create_certificate_chain_from_list (GSList *pem_list,
/* root will point to the last certificate in the file. */
if (!root)
root = cert;
root = g_object_ref (cert);
pem = g_slist_next (pem);
}
@ -639,6 +639,8 @@ create_certificate_chain_from_list (GSList *pem_list,
g_clear_object (&cert);
}
g_clear_object (&root);
return cert;
}