luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-01-27 14:36:16 +01:00
Code Issues Packages Projects Releases Wiki Activity

threadpool: Simplify pool thread naming

Browse Source 
In my experience, it isn't actually useful to have the program
name as part of the thread name (we don't do that for other threads
that we create: pool-spawner, gmain, gdbus, ...) and the size limit
of 16 means that there really isn't enough space for it.

But what is somewhat useful is to have different threads have different
names, so number the pool threads: pool-0, pool-1, ...
This commit is contained in:
Matthias Clasen 2024-11-27 21:56:16 +00:00 committed by Philip Withnall
parent 4f7ba235ea
commit eea697d523
1 changed files with 8 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
glib/gthreadpool.c
View File

@ -103,6 +103,8 @@ static gint max_unused_threads = 8;
static gint kill_unused_threads = 0;
static guint max_idle_time = 15 * 1000;
static int thread_counter = 0;
typedef struct
{
/* Either thread or error are set in the end. Both transfer-full. */
@ -283,11 +285,9 @@ g_thread_pool_spawn_thread (gpointer data)
SpawnThreadData *spawn_thread_data;
GThread *thread = NULL;
GError *error = NULL;
const gchar *prgname = g_get_prgname ();
gchar name[16] = "pool";
gchar name[16];
if (prgname)
g_snprintf (name, sizeof (name), "pool-%s", prgname);
g_snprintf (name, sizeof (name), "pool-%d", g_atomic_int_add (&thread_counter, 1));
g_async_queue_lock (spawn_thread_queue);
/* Spawn a new thread for the given pool and wake the requesting thread
@ -434,13 +434,8 @@ g_thread_pool_start_thread (GRealThreadPool *pool,
if (!success)
{
const gchar *prgname = g_get_prgname ();
gchar name[16] = "pool";
GThread *thread;
if (prgname)
g_snprintf (name, sizeof (name), "pool-%s", prgname);
/* No thread was found, we have to start a new one */
if (pool->pool.exclusive)
{
@ -448,6 +443,10 @@ g_thread_pool_start_thread (GRealThreadPool *pool,
* we simply start new threads that inherit the scheduler settings
* from the current thread.
*/
char name[16];
g_snprintf (name, sizeof (name), "pool-%d", g_atomic_int_add (&thread_counter, 1));
thread = g_thread_try_new (name, g_thread_pool_thread_proxy, pool, error);
}
else