luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-06-10 23:00:07 +02:00
Code Issues Packages Projects Releases Wiki Activity

Remove more read locks usage

Browse Source 
g_type_default_interface_peek() and g_type_value_table_peek() don't need
to acquire read locks anymore when they test the refcount instead of
node->data.
This commit is contained in:
Benjamin Otte 2009-09-24 15:04:20 +02:00 committed by Alexander Larsson
parent 5cac5c828b
commit f0f32a7ef0
1 changed files with 4 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
gobject/gtype.c
View File

@ -2950,7 +2950,7 @@ g_type_class_peek (GType type)
gpointer class; gpointer class;
node = lookup_type_node_I (type); node = lookup_type_node_I (type);
if (node && node->is_classed && NODE_REFCOUNT (node) > 0 && if (node && node->is_classed && NODE_REFCOUNT (node) &&
g_atomic_int_get (&node->data->class.init_state) == INITIALIZED) g_atomic_int_get (&node->data->class.init_state) == INITIALIZED)
/* ref_count _may_ be 0 */ /* ref_count _may_ be 0 */
class = node->data->class.class; class = node->data->class.class;
@ -3175,12 +3175,10 @@ g_type_default_interface_peek (GType g_type)
gpointer vtable; gpointer vtable;
node = lookup_type_node_I (g_type); node = lookup_type_node_I (g_type);
G_READ_LOCK (&type_rw_lock); if (node && NODE_IS_IFACE (node) && NODE_REFCOUNT (node))
if (node && NODE_IS_IFACE (node) && node->data && node->data->iface.dflt_vtable)
vtable = node->data->iface.dflt_vtable; vtable = node->data->iface.dflt_vtable;
else else
vtable = NULL; vtable = NULL;
G_READ_UNLOCK (&type_rw_lock);
return vtable; return vtable;
} }
@ -4101,14 +4099,9 @@ g_type_value_table_peek (GType type)
GTypeValueTable *vtable = NULL; GTypeValueTable *vtable = NULL;
TypeNode *node = lookup_type_node_I (type); TypeNode *node = lookup_type_node_I (type);
gboolean has_refed_data, has_table; gboolean has_refed_data, has_table;
TypeData *data;
/* speed up common code path, we're not 100% safe here, if (node && NODE_REFCOUNT (node) && node->mutatable_check_cache)
* but we should only get called with referenced types anyway return node->data->common.value_table;
*/
data = node ? node->data : NULL;
if (node && node->mutatable_check_cache)
return data->common.value_table;
G_READ_LOCK (&type_rw_lock); G_READ_LOCK (&type_rw_lock);