luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2024-12-26 15:36:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

gvariant-parser: add some comments

Browse Source 
I just spent several hours convinced that there was a memory safety
issue in string_parse() and bytestring_parse(). There isn't. (At least,
I think so.) Add some comments to save the next person some time.
This commit is contained in:
Michael Catanzaro 2024-08-22 16:01:29 -05:00 committed by Philip Withnall
parent 343081becc
commit f64d4aad6e
1 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
glib/gvariant-parser.c
View File

@ -1618,7 +1618,11 @@ string_free (AST *ast)
}
/* Accepts exactly @length hexadecimal digits. No leading sign or `0x`/`0X` prefix allowed.
* No leading/trailing space allowed. */
* No leading/trailing space allowed.
*
* It's OK to pass a length greater than the actual length of the src buffer,
* provided src must be null-terminated.
*/
static gboolean
unicode_unescape (const gchar *src,
gint *src_ofs,
@ -1692,6 +1696,9 @@ string_parse (TokenStream *stream,
length = strlen (token);
quote = token[0];
/* The output will always be at least one byte smaller than the input,
* because we skip over the initial quote character.
*/
str = g_malloc (length);
g_assert (quote == '"' || quote == '\'');
j = 0;
@ -1823,6 +1830,9 @@ bytestring_parse (TokenStream *stream,
length = strlen (token);
quote = token[1];
/* The output will always be smaller than the input, because we skip over the
* initial b and the quote character.
*/
str = g_malloc (length);
g_assert (quote == '"' || quote == '\'');
j = 0;