luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2024-11-10 11:26:16 +01:00
Code Issues Packages Projects Releases Wiki Activity

gkeyfile: Avoid an unnecessary strcmp()

Browse Source 
As the groups are disambiguated by name via the `groups` hash table,
there is guaranteed to be at most one `GKeyFileGroup` instance per group
name, which means they can be compared for equality by `GKeyFileGroup`
pointer, rather than needing a `strcmp()`.

This speeds up key file parsing in all cases.

oss-fuzz#31796

Signed-off-by: Philip Withnall <pwithnall@endlessos.org>
This commit is contained in:
Philip Withnall 2021-03-14 13:49:28 +00:00
parent 960030712d
commit f71db39284
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
glib/gkeyfile.c
View File

@ -1404,8 +1404,7 @@ g_key_file_parse_key_value_pair (GKeyFile *key_file,
if (key_file->current_group if (key_file->current_group
&& key_file->current_group->name && key_file->current_group->name
&& strcmp (key_file->start_group->name, && key_file->start_group == key_file->current_group
key_file->current_group->name) == 0
&& strcmp (key, "Encoding") == 0) && strcmp (key, "Encoding") == 0)
{ {
if (g_ascii_strcasecmp (value, "UTF-8") != 0) if (g_ascii_strcasecmp (value, "UTF-8") != 0)