luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-01-13 15:56:23 +01:00
Code Issues Packages Projects Releases Wiki Activity

xdgmime: fix double free

Browse Source 
We free xdg_dirs[i] twice, but fail to free xdg_dirs itself.

Also, since free() is NULL-safe, there is no need for the second check
here.

Discovered in: https://gitlab.freedesktop.org/xdg/xdgmime/-/merge_requests/16#note_1432025
This commit is contained in:
Michael Catanzaro 2022-06-17 08:48:10 -05:00
parent 4a8120ec22
commit f95ca6cb71
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
gio/xdgmime/xdgmime.c
View File

@ -350,8 +350,7 @@ xdg_mime_set_dirs (const char * const *dirs)
for (i = 0; xdg_dirs != NULL && xdg_dirs[i] != NULL; i++) for (i = 0; xdg_dirs != NULL && xdg_dirs[i] != NULL; i++)
free (xdg_dirs[i]); free (xdg_dirs[i]);
if (xdg_dirs != NULL) free (xdg_dirs);
free (xdg_dirs[i]);
xdg_dirs = NULL; xdg_dirs = NULL;
if (dirs != NULL) if (dirs != NULL)