From fa58cef826d8f3b6b3eb0cad230b0421ee35f8a2 Mon Sep 17 00:00:00 2001 From: Dan Winship Date: Fri, 24 Aug 2012 17:06:46 -0400 Subject: [PATCH] GDesktopAppInfo: fix leaks g_desktop_app_info_ensure_saved() was leaking the file contents. _g_desktop_app_info_launch_uris_internal() was leaking the session bus on error. https://bugzilla.gnome.org/show_bug.cgi?id=682560 --- gio/gdesktopappinfo.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gio/gdesktopappinfo.c b/gio/gdesktopappinfo.c index cde2d4a43..1bac191af 100644 --- a/gio/gdesktopappinfo.c +++ b/gio/gdesktopappinfo.c @@ -1373,12 +1373,12 @@ _g_desktop_app_info_launch_uris_internal (GAppInfo *appinfo, * the connection if we were the initial owner. */ g_dbus_connection_flush (session_bus, NULL, NULL, NULL); - g_object_unref (session_bus); } completed = TRUE; out: + g_clear_object (&session_bus); g_strfreev (argv); g_strfreev (envp); @@ -2078,6 +2078,7 @@ g_desktop_app_info_ensure_saved (GDesktopAppInfo *info, close (fd); res = g_file_set_contents (filename, data, data_size, error); + g_free (data); if (!res) { g_free (desktop_id);