From fea050d9d5a961c87366aa2290161f44a865cf77 Mon Sep 17 00:00:00 2001 From: Philip Withnall Date: Fri, 13 Apr 2018 17:02:23 +0100 Subject: [PATCH] tests: Drop a slightly suspect GResolver test MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This test will only work on machines which have IPv6 enabled and have a local IPv6 interface with ID 1. On machines which don’t (such as AWS servers, which we run CI tests on), the GResolver tests will fail with G_RESOLVER_ERROR_INVALID. We can’t differentiate this kind of failure (where we’d want to skip the test) from an actual failure (where we’d want to fail the test), so the only other option is to drop this particular test vector. I don’t think it’s a significant loss. This is the last fix needed to get our CI tests working reliably on jenkins.gnome.org. Signed-off-by: Philip Withnall https://bugzilla.gnome.org/show_bug.cgi?id=795234 --- gio/tests/network-address.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/gio/tests/network-address.c b/gio/tests/network-address.c index 622af17b1..da1b92413 100644 --- a/gio/tests/network-address.c +++ b/gio/tests/network-address.c @@ -123,11 +123,6 @@ static ResolveTest address_tests[] = { { "192.168.1.2", TRUE, TRUE, TRUE }, { "fe80::42", TRUE, TRUE, TRUE }, - /* GResolver accepts this by ignoring the scope ID. This was not - * intentional, but it's best to not "fix" it at this point. - */ - { "fe80::42%1", TRUE, TRUE, FALSE }, - /* g_network_address_parse() accepts these, but they are not * (just) IP addresses. */