luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-02-04 10:16:17 +01:00
Code Issues Packages Projects Releases Wiki Activity

Don't freeze/thaw notification during construction if no properties

Browse Source 
If the class has no properties there could be no notification anyway.
This is an important optimization for construction of simple objects.

Object construction performance improvement:
         Non-Threaded   Threaded
Simple:           84%        91%
Complex:        -1.4%      -0.6%

Other tests stable.

https://bugzilla.gnome.org/show_bug.cgi?id=557100
This commit is contained in:
Alexander Larsson 2009-08-19 17:22:32 +02:00
parent 302d13a757
commit ffc625ec9b
1 changed files with 25 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
gobject/gobject.c
View File

@ -138,7 +138,8 @@ enum {
static void g_object_base_class_init (GObjectClass *class); static void g_object_base_class_init (GObjectClass *class);
static void g_object_base_class_finalize (GObjectClass *class); static void g_object_base_class_finalize (GObjectClass *class);
static void g_object_do_class_init (GObjectClass *class); static void g_object_do_class_init (GObjectClass *class);
static void g_object_init (GObject *object); static void g_object_init (GObject *object,
GObjectClass *class);
static GObject* g_object_constructor (GType type, static GObject* g_object_constructor (GType type,
guint n_construct_properties, guint n_construct_properties,
GObjectConstructParam *construct_params); GObjectConstructParam *construct_params);
@ -702,13 +703,18 @@ g_object_interface_list_properties (gpointer g_iface,
} }
static void static void
g_object_init (GObject *object) g_object_init (GObject *object,
GObjectClass *class)
{ {
object->ref_count = 1; object->ref_count = 1;
g_datalist_init (&object->qdata); g_datalist_init (&object->qdata);
/* freeze object's notification queue, g_object_newv() preserves pairedness */ if (CLASS_HAS_PROPS (class))
g_object_notify_queue_freeze (object, &property_notify_context); {
/* freeze object's notification queue, g_object_newv() preserves pairedness */
g_object_notify_queue_freeze (object, &property_notify_context);
}
/* enter construction list for notify_queue_thaw() and to allow construct-only properties */ /* enter construction list for notify_queue_thaw() and to allow construct-only properties */
G_LOCK (construction_mutex); G_LOCK (construction_mutex);
construction_objects = g_slist_prepend (construction_objects, object); construction_objects = g_slist_prepend (construction_objects, object);
@ -1243,10 +1249,14 @@ g_object_newv (GType object_type,
G_LOCK (construction_mutex); G_LOCK (construction_mutex);
newly_constructed = slist_maybe_remove (&construction_objects, object); newly_constructed = slist_maybe_remove (&construction_objects, object);
G_UNLOCK (construction_mutex); G_UNLOCK (construction_mutex);
if (newly_constructed || n_oparams)
nqueue = g_object_notify_queue_freeze (object, &property_notify_context); if (CLASS_HAS_PROPS (class))
if (newly_constructed) {
g_object_notify_queue_thaw (object, nqueue); if (newly_constructed || n_oparams)
nqueue = g_object_notify_queue_freeze (object, &property_notify_context);
if (newly_constructed)
g_object_notify_queue_thaw (object, nqueue);
}
/* run 'constructed' handler if there is one */ /* run 'constructed' handler if there is one */
if (newly_constructed && class->constructed) if (newly_constructed && class->constructed)
@ -1257,9 +1267,12 @@ g_object_newv (GType object_type,
object_set_property (object, oparams[i].pspec, oparams[i].value, nqueue); object_set_property (object, oparams[i].pspec, oparams[i].value, nqueue);
g_free (oparams); g_free (oparams);
/* release our own freeze count and handle notifications */ if (CLASS_HAS_PROPS (class))
if (newly_constructed || n_oparams) {
g_object_notify_queue_thaw (object, nqueue); /* release our own freeze count and handle notifications */
if (newly_constructed || n_oparams)
g_object_notify_queue_thaw (object, nqueue);
}
if (unref_class) if (unref_class)
g_type_class_unref (unref_class); g_type_class_unref (unref_class);