5 Commits

Author	SHA1	Message	Date
Iain Lane	1152d99ded	Fix trashing on overlayfs ... In order to determine whether to trash a file to the home directory, we compare its st_dev to our home directory's st_dev field. This is the wrong thing to do on overlayfs when deleting files, because st_dev contains the ID of the filesystem providing the file (which can be the lower or upper filesystem), but directories always return the ID of the overlayfs. Thus the comparison fails and we are unable to trash the file. Fix this by checking st_dev of the parent directory when we are deleting a file. Also adjust `test_trash_not_supported` for this - make its st_dev check look at the parent directory's `st_dev` rather than the temporary file's own. Fixes #1027.	2018-08-13 17:41:59 +01:00
Mohammed Sadiq	24f5dbca2c	gio/tests: Use the right format specifier ... dev_t - the type of st_dev - is always 8 byte. Use G_GUINT64_FORMAT to ensure 8 byte and thus not fail on i386.	2018-07-30 20:53:15 +05:30
Ondrej Holy	83ca61a421	glocalfile: Add test case for g_file_trash ... g_local_file_trash has been changed to return G_IO_ERROR_NOT_SUPPORTED for locations on system-internal mounts. Let's verify that. https://gitlab.gnome.org/GNOME/glib/issues/251	2018-06-08 13:27:13 +02:00
Philip Withnall	da3daf2803	Revert "Merge branch 'wip/oholy/trashing-locations' into 'master'" ... This reverts merge request !49	2018-06-07 16:42:57 +00:00
Ondrej Holy	f7e80f8d0c	glocalfile: Add test case for g_file_trash ... g_local_file_trash has been changed to return G_IO_ERROR_NOT_SUPPORTED for locations on system-internal mounts. Let's verify that. https://gitlab.gnome.org/GNOME/glib/issues/251	2018-06-06 12:18:30 +02:00