Commit Graph

14649 Commits

Author SHA1 Message Date
Ryan Lortie
76584e7ae3 Fix races in unix signal dispatch
Fix some races introduced in be2c7b83c4
while keeping the property that multiple handlers for the same unix
signal all get dispatched.

Also fix the behaviour of the source checking for pending signals when
it's created.  No matter what we do here (clear the pending flag or not)
there is something that can go wrong.

If we clear the flag, we may prevent other sources from being
dispatched.  If we don't clear it, we may end up dispatching the same
source twice (if we manage to dispatch it from its own thread before the
GLib worker has a chance to run).

Instead, run the full dispatch procedure when a new source is added.  It
actually doesn't matter what thread this runs in since the lock is held.

https://bugzilla.gnome.org/show_bug.cgi?id=711090
2014-01-01 19:19:59 -05:00
Colin Walters
97d9138f6c gio/tests: Fix usage of BUILT_SOURCES 2014-01-01 19:05:34 -05:00
Yosef Or Boczko
52cefa239d Fix doc build 2014-01-02 01:40:26 +02:00
Matthias Clasen
f9f7ad2557 Improve gutils.c test coverage 2014-01-01 17:59:22 -05:00
Matthias Clasen
3de604d438 Improve GDate test coverage 2014-01-01 17:59:22 -05:00
Matthias Clasen
5e6d86877d Improve GIOChannel test coverage 2014-01-01 17:59:22 -05:00
Matthias Clasen
5ec36cd02a Improve hostutils test coverage 2014-01-01 17:59:22 -05:00
Matthias Clasen
baceea9582 Improve GVariant test coverage 2014-01-01 17:59:22 -05:00
Matthias Clasen
ec0d6d7812 Test stdio wrappers 2014-01-01 17:59:22 -05:00
Matthias Clasen
93dad4808e Trivial typo fix 2014-01-01 17:59:22 -05:00
Matthias Clasen
90aa4ed0a0 Improve charset test coverage 2014-01-01 17:59:22 -05:00
Matthias Clasen
4f0a13effc Add tests for g_malloc 2014-01-01 17:59:22 -05:00
Matthias Clasen
58cdf0b474 Drop memory-related trap variables
These are just more lo-tech conditional breakpoint wannabes.
Debuggers can be trusted to support conditional breakpoints
nowadays.
2014-01-01 17:59:22 -05:00
Matthias Clasen
6d3b83a8c1 Improve GAsyncQueue test coverage 2014-01-01 17:59:22 -05:00
Matthias Clasen
9a2c8d89c7 Improve test coverage of g_utf8_collate_key_for_filename
The existing tests were accidentally using the same test data
twice. Fix that, and add another set of tests that exercise
the filename collation special cases.
2014-01-01 17:59:22 -05:00
Matthias Clasen
32e0499c56 Add tests for g_spaced_primes_closest 2014-01-01 17:59:22 -05:00
Matthias Clasen
4989cb4dde Improve GOptionContext test coverage 2014-01-01 17:59:22 -05:00
Matthias Clasen
d6bd36c699 Improve GBookmarkFile test coverage 2014-01-01 17:59:22 -05:00
Matthias Clasen
14359e17c9 GBookmarkFile: Streamline error handling a bit 2014-01-01 17:59:22 -05:00
Matthias Clasen
228a2c82f6 GBookmarkFile: Remove dead code
The icon element is actually parsed further up, and this
case is never hit, so remove it.
2014-01-01 17:59:22 -05:00
Matthias Clasen
0f746070d8 Make a bookmark testfile roundtrippable
This will be used in new tests in the following commit.
2014-01-01 17:59:22 -05:00
Matthias Clasen
95f13ded92 Trivial formatting fixes 2014-01-01 17:59:21 -05:00
Matthias Clasen
d264d32d3b Improve glib-unix test coverage 2014-01-01 17:59:21 -05:00
Matthias Clasen
6814f7ebd9 Improve GHashTable test coverage 2014-01-01 17:59:21 -05:00
Matthias Clasen
95d4856760 Add a test for g_markup_parse_context_get_element_stack 2014-01-01 17:59:21 -05:00
Matthias Clasen
27e352985b Remove broken attempt at parsing date-only
g_time_val_from_iso8601 was attempting to parse strings
having only a date, but failed to actually set the timeval
despite returning TRUE. Since the docs state that the function
only parses strings containing a date and a time, just return
FALSE in this case.

Also remove an incomplete testcase for this behaviour that was
just checking the boolean return value, but not timeval.
2014-01-01 17:59:21 -05:00
Matthias Clasen
680c348bb4 Add missing includes
config.h needs to be included in every source file, first.
2014-01-01 17:59:21 -05:00
Matthias Clasen
cc8c1541c9 Improve mainloop test coverage 2014-01-01 17:59:21 -05:00
Matthias Clasen
24d992f8a1 Add tests for GTimer and GTimeVal 2014-01-01 17:59:21 -05:00
Matthias Clasen
2ded47e955 Improve GTree test coverage 2014-01-01 17:59:21 -05:00
Matthias Clasen
6e23e6c641 Improve logging test coverage 2014-01-01 17:59:21 -05:00
Matthias Clasen
cdb14a194e Improve testing test coverage
In particular, test the just-fixed g_test_trap_reached_timeout.
2014-01-01 17:59:21 -05:00
Matthias Clasen
3343bc3385 Fix g_test_trap_reached_timeout
The function was returning the opposite of what the
documentation says.
2014-01-01 17:59:21 -05:00
Matthias Clasen
e013cf9cad Improve GSlice test coverage 2014-01-01 17:59:21 -05:00
Matthias Clasen
19ad8dbfa6 Improve GNode test coverage 2014-01-01 17:59:21 -05:00
Matthias Clasen
6fe85aee8d Improve fileutils test coverage
Add some tests for g_file_read_link.
2014-01-01 17:59:21 -05:00
Matthias Clasen
f16753cfe0 Unify error reporting in gfileutils.c
Use the set_file_error helper function in more places,
saving some 50 lines.
2014-01-01 17:59:21 -05:00
Matthias Clasen
2299bcd88d Improve GResourceFile test coverage 2014-01-01 17:59:21 -05:00
Matthias Clasen
3eeeb7aaa7 Improve gsettings test coverage 2014-01-01 17:59:21 -05:00
Matthias Clasen
1041fc2190 Improve gdbus test coverage 2014-01-01 17:59:21 -05:00
Matthias Clasen
df3ac947ac Improve converter test coverage 2014-01-01 17:59:21 -05:00
Matthias Clasen
354ae1d61c Add tests for remote actions
This improves the GApplication test coverage.
2014-01-01 17:59:21 -05:00
Matthias Clasen
8aeb391a77 Improve GIOModule test coverage
Add a dedicated test for GIOModule.
2014-01-01 17:59:21 -05:00
Matthias Clasen
7bea4bd89a Correct a doc comment 2014-01-01 17:59:21 -05:00
Matthias Clasen
5bcbb98f45 GIOModule: Add some more details to the docs 2014-01-01 17:59:21 -05:00
Matthias Clasen
0356d7f4c3 Fix a typo in a comment
The D-Bus interface is org.freedesktop.DBus.Peer, not
org.freedesktop.DBus.
2014-01-01 17:59:21 -05:00
Matthias Clasen
b5ba22f163 Add a generic property test
This test is inspired by its namesake in GTK+. We instantiate
all types, and check the default values of their properties,
with some exceptions for types that are known not to work.
2014-01-01 17:59:21 -05:00
Matthias Clasen
290b46cd24 GTlsPassword: Make declared defaults match
String properties typically start out with a value of NULL.
No reason to deviate from that convention here.
2014-01-01 17:59:20 -05:00
Matthias Clasen
3a37e403e6 Make GFileIcon more robust
No reason not to survive g_object_unref (g_object_new (...))
2014-01-01 17:59:20 -05:00
Matthias Clasen
34de9189f6 Make GEmblem more robust
No reason not to survive g_object_unref (g_object_new (...)).
2014-01-01 17:59:20 -05:00