83 Commits

Author SHA1 Message Date
Matthias Clasen
53fc10d269 Fix a lot of clang complaints
Mostly dead assignments.
2009-09-18 19:20:06 -04:00
Hans Breuer
4a50bab276 Define fstat() for msvc build 2009-05-30 15:33:14 +02:00
Christian Persch
37bd225d7b Fix grammar in error message
Bug #583198.
2009-05-23 18:00:06 +02:00
Matthias Clasen
2dfce32422 Accept NULL as empty string list
Fixes bug 580656.
2009-05-02 22:41:19 -04:00
Matthias Clasen
0f6b25ca96 Fix some compiler warnings
svn path=/trunk/; revision=7755
2008-12-31 05:51:47 +00:00
Matthias Clasen
20bc7adfb8 Some more documentation additions
svn path=/trunk/; revision=7726
2008-12-02 05:53:48 +00:00
Matthias Clasen
0be828b4f8 Explain the difference to g_key_file_get_value(). Pointed out by Mart
* glib/gkeyfile.c (g_key_file_get_string): Explain the difference
        to g_key_file_get_value(). Pointed out by Mart Raudsepp.



svn path=/trunk/; revision=7705
2008-11-28 21:22:21 +00:00
Matthias Clasen
a2830c774d Improve docs
svn path=/trunk/; revision=7704
2008-11-28 20:29:42 +00:00
Christian Persch
da8591c7a8 Bug 560568 – gkeyfile docs buglet
svn path=/trunk/; revision=7674
2008-11-23 21:16:01 +00:00
Christian Persch
47d6d6a451 Bug 560569 – gkeyfile doesn't use the set list_separator in some cases
svn path=/trunk/; revision=7673
2008-11-23 21:15:57 +00:00
Christian Persch
9c17697b56 Use g_set_error_literal where appropriate. Patch from bug #535947.
svn path=/trunk/; revision=7051
2008-06-16 16:53:58 +00:00
Matthias Clasen
1d7f670632 Improve the docs
svn path=/trunk/; revision=7002
2008-06-11 15:58:02 +00:00
Matthias Clasen
a24587ad09 Return NULL when the key is not found. (#513171, Дилян
2008-02-23  Matthias Clasen  <mclasen@redhat.com> 

        * glib/gkeyfile.c (g_key_file_get_string_list): Return
        NULL when the key is not found.  (#513171, Дилян Палаузов)



svn path=/trunk/; revision=6563
2008-02-23 05:25:27 +00:00
Matthias Clasen
2a7f1a1a9c Remove wrong documentation about start group handling. (#476856, Areg
2007-12-22  Matthias Clasen  <mclasen@redhat.com>

        * glib/gkeyfile.c: Remove wrong documentation about start group
        handling.  (#476856, Areg Beketovski)



svn path=/trunk/; revision=6190
2007-12-23 04:57:23 +00:00
Matthias Clasen
20d002d466 Free group_hash. (#503420, Christian Persch)
2007-12-13  Matthias Clasen  <mclasen@redhat.com>

        * glib/gkeyfile.c (g_key_file_clear): Free group_hash.
        (#503420, Christian Persch)


svn path=/trunk/; revision=6107
2007-12-13 13:56:08 +00:00
15:08:59 Tim Janik
cc3de68e21 http://mail.gnome.org/archives/gtk-devel-list/2007-October/msg00089.html
2007-12-10 15:08:59  Tim Janik  <timj@imendio.com>

        * let g_warn_if_fail replace g_assert as discussed here:
          http://mail.gnome.org/archives/gtk-devel-list/2007-October/msg00089.html

        * fix bug #502498: Test framework assertion failures should follow
        gcc error format.

        * gmessages.h, gmessages.c: deprecated g_assert_warning() which is
        unused now. removed g_assert*() definitions whcih are provided by 
        gtestutils.h now. added g_warn_if_reached() and g_warn_if_fail()  
        which are recommended as g_assert/g_assert_not_reached replacements
        for non-test programs.
        added g_warn_message() to implement g_warn_*() macros.
        use emacs-next-error friendly formatting for file:line: for warnings.

        * gtestutils.h, gtestutils.c: use emacs-next-error friendly formatting.
        implement g_assert_not_reached() with g_assertion_message() and
        g_assert() in terms of g_assertion_message_expr() so we'll be able to
        provide assertion messages in test logs.

        * gkeyfile.c, gbookmarkfile.c: changed g_assert*() to g_warn_if_fail()
        or g_return_if_fail() where suitable.

        * gio/: changed g_assert to g_warn_if_fail.



svn path=/trunk/; revision=6086
2007-12-10 14:07:42 +00:00
Matthias Clasen
2efc55c68e Don't call g_get_language_names() per-key. (#500638, Michael Meeks)
2007-12-03  Matthias Clasen  <mclasen@redhat.com>

        * glib/gkeyfile.c: Don't call g_get_language_names() per-key.
        (#500638, Michael Meeks)


svn path=/trunk/; revision=6023
2007-12-03 18:56:33 +00:00
Matthias Clasen
8e2e557633 Speed up group lookups
svn path=/trunk/; revision=6018
2007-12-03 15:43:20 +00:00
Matthias Clasen
ccf93c8693 Set length out param in list-returning functions to 0 when returning NULL.
2007-11-22  Matthias Clasen  <mclasen@redhat.com>

        * glib/gkeyfile.c: Set length out param in list-returning functions
        to 0 when returning NULL.  (#498728, Christian Persch)



svn path=/trunk/; revision=5915
2007-11-23 04:17:58 +00:00
Matthias Clasen
dbe4c82b65 One more
svn path=/trunk/; revision=5853
2007-11-10 01:47:51 +00:00
Matthias Clasen
662f9e46d1 Coding style cleanups and doc improvements. (#491979, Areg Beketovski)
2007-11-09  Matthias Clasen <mclasen@redhat.com>

        * glib/gkeyfile.c: Coding style cleanups and doc
        improvements.  (#491979, Areg Beketovski)



svn path=/trunk/; revision=5852
2007-11-10 01:45:12 +00:00
Matthias Clasen
1dc3d6f088 Make some functions that take a GError return boolean instead of void.
2007-11-07  Matthias Clasen <mclasen@redhat.com>

        * glib/gkeyfile.[hc]: Make some functions that take
        a GError return boolean instead of void.  (#375651, Matt Barnes)



svn path=/trunk/; revision=5815
2007-11-08 03:19:37 +00:00
Matthias Clasen
0911f2e907 Don't assume the string is valid UTF-8, since it may be user data.
2007-06-05  Matthias Clasen  <mclasen@redhat.com>

        * glib/gkeyfile.c (g_key_file_is_key_name):
        (g_key_file_is_group_name): Don't assume the string is
        valid UTF-8, since it may be user data.  (#444161, Ben Combee)



svn path=/trunk/; revision=5537
2007-06-05 19:14:46 +00:00
Matthias Clasen
f69d1b7439 2.13.3
svn path=/trunk/; revision=5531
2007-06-04 15:40:33 +00:00
Dan Winship
4b6a5ee2e0 Document the error return values rather than calling them undefined.
* glib/gkeyfile.c (g_key_file_get_boolean)
	(g_key_file_get_boolean_list, g_key_file_get_integer)
	(g_key_file_get_integer_list, g_key_file_get_double)
	(g_key_file_get_double_list): Document the error return values
	rather than calling them undefined. #435885.

svn path=/trunk/; revision=5484
2007-05-04 19:14:47 +00:00
William Jon McCann
fc161a7058 Add g_key_file_load_from_dirs for looking through a search path for a
2007-04-19  William Jon McCann  <mccann@jhu.edu>

	* glib/gkeyfile.[ch]: (find_file_in_data_dirs),
	(g_key_file_load_from_dirs), (g_key_file_load_from_data_dirs):
	Add g_key_file_load_from_dirs for looking through a search
	path for a key-file. (#355334)


svn path=/trunk/; revision=5453
2007-04-19 20:48:22 +00:00
Chris Wilson
033e54e8a4 Track whether the last key=value pair in a group is a blank line and
2007-03-22  Chris Wilson  <chris@chris-wilson.co.uk>

	* glib/gkeyfile.c: Track whether the last key=value pair in a group
	is a blank line and during to_data() only insert a new blank line
	betweens group in its absence. This allows the beautification of the
	GKeyFile and prevents newlines being inserted indefinitely. (#420686)

	* tests/keyfile-test.c (test_reload_idempotency): Test that after a 
	single beautification pass, g_key_file_to_data() does not alter its
	input data.


svn path=/trunk/; revision=5431
2007-03-22 08:58:59 +00:00
Chris Wilson
003dbec6c8 Convert to GSlice and check for redundant clears. (#418637)
2007-03-16  Chris Wilson  <chris@chris-wilson.co.uk>

	* glib/gkeyfile.c: Convert to GSlice and check for redundant
	clears. (#418637)


svn path=/trunk/; revision=5413
2007-03-16 01:16:56 +00:00
Matthias Clasen
b2eed3f16c Fix a small typo. (#417947, Bobby Jack)
2007-03-14  Matthias Clasen  <mclasen@redhat.com>

        * glib/gkeyfile.c (g_key_file_get_double): Fix a
        small typo.  (#417947, Bobby Jack)



svn path=/trunk/; revision=5404
2007-03-15 03:08:08 +00:00
Matthias Clasen
2a6150bc06 Remove a NULL check that didn't do any good. (#360904, Paolo Borelli)
2007-03-06  Matthias Clasen  <mclasen@redhat.com>

        * glib/gkeyfile.c (g_key_file_parse_value_as_boolean):
        Remove a NULL check that didn't do any good.  (#360904,
        Paolo Borelli)



svn path=/trunk/; revision=5375
2007-03-06 07:22:04 +00:00
Matthias Clasen
38b9221961 Rework the handling of invalid keys/groups again. We are back to being
2007-01-12  Matthias Clasen  <mclasen@redhat.com>

        * glib/gkeyfile.c: Rework the handling of invalid
        keys/groups again. We are back to being liberal about
        what we accept, and only reject things that would lead
        to non-rereadable keyfiles.

        * tests/keyfile-test.c: Adapt tests.



svn path=/trunk/; revision=5254
2007-01-12 20:25:57 +00:00
Matthias Clasen
b021642caf Grr, allow '*' in keys, too. (#394262)
2007-01-10  Matthias Clasen  <mclasen@redhat.com>

        * glib/gkeyfile.c (g_key_file_is_key_name): Grr, allow '*' in keys,
        too.  (#394262)



svn path=/trunk/; revision=5239
2007-01-10 13:46:45 +00:00
Matthias Clasen
01f78fa7f5 Accept '/', '+' and '.' in key names, since gnome-vfs uses mime types as
2006-12-19  Matthias Clasen  <mclasen@redhat.com>

        * glib/gkeyfile.c (g_key_file_is_key_name): Accept
        '/', '+' and '.' in key names, since gnome-vfs uses
        mime types as keys in some cache.

2
2006-12-19 21:08:32 +00:00
Matthias Clasen
52ef9438ca Accept '@' in locale names.
2006-12-18  Matthias Clasen  <mclasen@redhat.com>

        * glib/gkeyfile.c: Accept '@' in locale names.
2006-12-18 14:13:34 +00:00
Matthias Clasen
6b52690bb5 Tighten up the check for allowed key and group names. (#343191, Tommi
2006-12-18  Matthias Clasen  <mclasen@redhat.com>

        * glib/gkeyfile.c: Tighten up the check for allowed
        key and group names.  (#343191, Tommi Komulainen)

        * tests/keyfile-test.c: Test handling of key and group names.
2006-12-18 07:29:56 +00:00
Matthias Clasen
966872d789 If the group is already there, make it current. (#385910, Joe Halliwell)
2006-12-14  Matthias Clasen  <mclasen@redhat.com>

        * glib/gkeyfile.c (g_key_file_add_group): If the group
        is already there, make it current.  (#385910, Joe Halliwell)

        * tests/keyfile-test.c: Add a test for duplicate groups/keys.
2006-12-14 23:19:28 +00:00
Matthias Clasen
8f05c1da81 Fix the pthread compiler flag detection.
2006-08-25  Matthias Clasen  <mclasen@redhat.com>

	* configure.in: Fix the pthread compiler flag detection.

	* glib/gunicode.h:
	* glib/gutf8.c (_g_utf8_make_valid): Rename make_valid_utf8
	from gconvert.c, move it to gutf8.c, and export it privately.

	* glib/gconvert.c (g_filename_display_name): Adjust callers.

	* glib/gkeyfile.c: Use _g_utf8_make_valid() in a number of
	places to ensure error messages are valid UTF-8.  (#351853,
	Simon Budig)
2006-08-26 03:44:45 +00:00
Matthias Clasen
58ea1db43e Add Since tags. Fix Since tag. (#351583, Brian Cameron)
2006-08-15  Matthias Clasen  <mclasen@redhat.com>

        * glib/gbookmarkfile.c (g_bookmark_file_get_groups):
        * glib/gmain.c (g_source_is_destroyed): Add Since tags.
        * glib/gkeyfile.c (g_key_file_get_double_list): Fix
        Since tag.  (#351583, Brian Cameron)
2006-08-16 03:33:57 +00:00
Matthias Clasen
e94c42bd46 Don't insert unnecessary newlines in keyfiles. (#349825, Chris Wilson)
2006-08-05  Matthias Clasen  <mclasen@redhat.com>

	* glib/gkeyfile.c (g_key_file_to_data): Don't insert unnecessary
	newlines in keyfiles.  (#349825, Chris Wilson)
2006-08-05 21:57:35 +00:00
Matthias Clasen
99998793d5 Fix 344868 2006-06-14 13:48:27 +00:00
Behdad Esfahbod
38b53eed54 Cleanup. Use return value of g_string_free(...). (#343548, Chris Wilson)
2006-06-01  Behdad Esfahbod  <behdad@gnome.org>

        * glib/gkeyfile.c (g_key_file_to_data),
        (g_key_file_parse_value_as_comment),
        (g_key_file_parse_comment_as_value):
        * glib/gscanner.c (g_scanner_get_token_ll): Cleanup. Use return
        value of g_string_free(...). (#343548, Chris Wilson)
2006-06-01 04:51:25 +00:00
Matthias Clasen
eda3af5546 Add some tests for invalid floating point numbers.
2006-05-08  Matthias Clasen  <mclasen@redhat.com>

	* tests/keyfile-test.c (test_number): Add some tests for
	invalid floating point numbers.
2006-05-08 16:48:47 +00:00
Matthias Clasen
6fbcec14dc Fix invalid memory reads. (#340816, Nick Treleaven)
2006-05-06  Matthias Clasen  <mclasen@redhat.com>

	* glib/gkeyfile.c (g_key_file_set_string_list)
	(g_key_file_set_locale_string_list): Fix invalid memory
	reads.  (#340816, Nick Treleaven)
2006-05-07 04:02:06 +00:00
Matthias Clasen
3916fe18d6 Remove redundant code. (g_key_file_get_group_comment): Don't dereference
2006-04-25  Matthias Clasen  <mclasen@redhat.com>

	* glib/gkeyfile.c (g_key_file_lookup_group_node): Remove
	redundant code.
	(g_key_file_get_group_comment): Don't dereference before
	checking for NULL.  (#338572, Coverity, Pascal Terjan)
2006-04-25 20:30:59 +00:00
Matthias Clasen
22ec64756c Add api to get and set doubles and lists of doubles. (#164719, Maurizio
2006-04-18  Matthias Clasen  <mclasen@redhat.com>

	* glib/gkeyfile.h:
	* glib/glib.symbols:
	* glib/gkeyfile.c: Add api to get and set doubles and
	lists of doubles.  (#164719, Maurizio Monge, Dom Lachowicz)

	* tests/keyfile-test.c: Add tests for new api.
2006-04-19 02:59:37 +00:00
Matthias Clasen
64434acfe1 Accept duplicate groups. (#157877, Sebastien Bacher)
2006-04-18  Matthias Clasen  <mclasen@redhat.com>

	* glib/gkeyfile.c (g_key_file_add_group): Accept duplicate
	groups.  (#157877, Sebastien Bacher)

	* tests/keyfile-test.c: Add tests for duplicate key and
	duplicate group handling.
2006-04-19 02:39:37 +00:00
Matthias Clasen
b58fb2bdb5 Move short_month_names and long_month_names to bss.
2006-04-04  Matthias Clasen  <mclasen@redhat.com>

        * glib/gdate.c: Move short_month_names and long_month_names
        to bss.

        * glib/gspawn-win32.c (g_spawn_error_quark):
        * glib/gspawn.c (g_spawn_error_quark):
        * glib/gshell.c (g_shell_error_quark):
        * glib/gmarkup.c (g_markup_error_quark):
        * glib/goption.c (g_option_error_quark):
        * glib/gkeyfile.c (g_key_file_error_quark):
        * glib/giochannel.c (g_io_channel_error_quark):
        * glib/gfileutils.c (g_file_error_quark):
        * glib/gconvert.c (g_convert_error_quark):
        * glib/gbookmarkfile.c (g_bookmark_file_error_quark):
        * glib/gthread.c (g_thread_error_quark): No point in making
        the error path fast by caching quarks.

        * glib/gbookmarkfile.c: Make the parser struct const.
2006-04-04 04:37:39 +00:00
Matthias Clasen
402a1081ae Add a note about casting the results of g_new() and g_new0().
2006-01-17  Matthias Clasen  <mclasen@redhat.com>

	* glib/tmpl/memory.sgml: Add a note about casting the results
	of g_new() and g_new0().
2006-01-18 03:51:39 +00:00
Matthias Clasen
81719cc164 Add a test for grup names of length 1.
2005-09-14  Matthias Clasen  <mclasen@redhat.com>

	* tests/keyfile-test.c: Add a test for grup names of length 1.

	* glib/gkeyfile.c (g_key_file_line_is_group): Accept group names
	of length 1.  (#316309)
2005-09-14 18:04:53 +00:00
Matthias Clasen
1c0b689399 The return value of read() is signed. (#315273, Kjartan Maraas)
2005-09-05  Matthias Clasen  <mclasen@redhat.com>

	* glib/gkeyfile.c (g_key_file_load_from_fd): The return value
	of read() is signed.  (#315273, Kjartan Maraas)
2005-09-05 17:55:11 +00:00