Ravi Sankar Guntur
0ed2cdb0d9
Use g_queue_free_full() convenience function.
...
https://bugzilla.gnome.org/show_bug.cgi?id=667331
Signed-off-by: Ravi Sankar Guntur <ravi.g@samsung.com >
2012-01-09 19:27:39 -05:00
Matthias Clasen
ddf9633d95
fix a compiler warning
2012-01-09 15:27:07 -05:00
Matthias Clasen
39dc681fc7
Realign the hash set example with added api
...
Change the name of set_insert to set_add, to better match the
newly added g_hash_table_add.
2012-01-09 15:23:25 -05:00
Dan Vrátil
7678b10703
Fix GHashTable GDB pretty printing (bug #667420 )
2012-01-09 09:29:20 +01:00
Jasper St. Pierre
d141940bc6
gthread-posix: Remove misleading documentation comments
...
g_thread_init() has done nothing since 2.32, so while the function
still can be used if "g_thread_init() has not yet been called",
it won't do nothing in that case, it will just perform normally.
2012-01-06 14:41:08 -05:00
Jasper St. Pierre
021e116f05
gbacktrace: g_get_prgname () isn't called for a NULL argument
...
https://bugzilla.gnome.org/show_bug.cgi?id=658871
2012-01-06 14:41:08 -05:00
Ryan Lortie
21d2c49f82
minor fixup to last commit
2012-01-06 10:25:03 -05:00
Ryan Lortie
752f0cac15
GHashTable: new 'add' and 'contains' APIs
...
These are both convenience APIs that make it slightly nicer to use
GHashTable as a set (which is something we document as officially
supported).
2012-01-06 10:18:41 -05:00
Simon McVittie
2fe964eeb1
Mention g_test_undefined() when documenting assert_failed, assert_stderr
...
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=666116
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk >
Reviewed-by: Colin Walters <walters@verbum.org >
2012-01-05 15:47:50 +00:00
Javier Jardón
e3d53d5529
glib/*: Use g_slist_free_full() convenience function
2012-01-05 04:57:48 +01:00
Matthias Clasen
1b919d2e56
Clarify g_utf8_strlen docs a bit
2012-01-04 00:10:11 -05:00
Paolo Borelli
d64b4c4887
Add a testcase for an old regex bug.
...
Add a testcase for bug #455640 , which was fixed in PCRE versions newer
than 7.2.
2012-01-03 21:17:48 +01:00
Javier Jardón
2ae83e116b
glib/*: Use g_list_free_full()
2012-01-03 16:53:47 +01:00
Stef Walter
411259ddd3
gvariant: Never break out of g_variant_iter_loop
...
* Document how to break out of g_variant_iter_loop style loops.
https://bugzilla.gnome.org/show_bug.cgi?id=664069
2012-01-02 18:34:08 +01:00
Simon McVittie
1425aa664d
GBitLock: turn assumptions of g_futex_int_address into a static assertion
...
We'll probably never encounter a platform where these fail, but that's
what static assertions are for...
https://bugzilla.gnome.org/show_bug.cgi?id=548954
2012-01-02 12:23:01 -05:00
Ryan Lortie
fc731de929
gthread.h: avoid anonymous union
...
This is a GNU extension.
https://bugzilla.gnome.org/show_bug.cgi?id=666978
2012-01-02 11:39:01 -05:00
Matthias Clasen
8558ae9ad4
Correct some Since tags
...
As pointed out in bug 666951, g_mkdtemp and g_mkdtemp_full
were only added in 2.30.
2011-12-29 11:57:42 -05:00
Ravi Sankar Guntur
8ca2647c74
Fix to handle '\v' (vertical tab) by g_strescape() and g_strcompress().
...
fix enables g_strescape() and g_strcompress() to handle '\v' along with other
special characters - '\b', '\f', '\n', '\r', '\t', '\'.
https://bugzilla.gnome.org/show_bug.cgi?id=664830
Signed-off-by: Ravi Sankar Guntur <ravi.g@samsung.com >
2011-12-27 21:49:19 -05:00
Simon McVittie
993de34a77
Add undefined/no-undefined mode options to GTester
...
https://bugzilla.gnome.org/show_bug.cgi?id=666116
2011-12-27 17:51:11 -05:00
Simon McVittie
fa4792c35e
various tests: do not provoke SIGTRAP with -m no-undefined
...
Some of the GLib tests deliberately provoke warnings (or even fatal
errors) in a forked child. Normally, this is fine, but under valgrind
it's somewhat undesirable. We do want to follow fork(), so we can check
for leaks in child processes that exit gracefully; but we don't want to
be told about "leaks" in processes that are crashing, because there'd
be no point in cleaning those up anyway.
https://bugzilla.gnome.org/show_bug.cgi?id=666116
2011-12-27 17:51:09 -05:00
Simon McVittie
5cb29d7909
Clarify documentation of fast/slow/thorough and quiet/verbose tests
...
It turns out that there is no middle setting between fast and
slow/thorough, but there *is* a middle setting between quiet and verbose.
https://bugzilla.gnome.org/show_bug.cgi?id=666116
2011-12-27 17:51:04 -05:00
Matthias Clasen
8cea99741b
Don't put documentation in glibconfig.h
2011-12-27 16:22:13 -05:00
Matthias Clasen
4576a459fc
Remove obsolescent AC_HEADER_STDC macro
...
We only used the resulting define in one place, and really,
these headers just have to be around or its not worth trying.
2011-12-27 15:55:04 -05:00
Thomas Hindoe Paaboel Andersen
49a4de3ea4
docs: g_atexit: do not point in a direction for where to find details
...
https://bugzilla.gnome.org/show_bug.cgi?id=666804
2011-12-27 10:18:41 -05:00
Benjamin Otte
c4fc258424
docs: Clarify non-NUL requirement in g_utf8_validate()
...
UTF8 validation is not about your character on a dating site, so don't
talk about meeting.
https://bugzilla.gnome.org/show_bug.cgi?id=666803
2011-12-24 14:26:24 +01:00
rodrigorivascosta
1b03377442
Bug 666551-Fix a few dangling pointers
...
When removing an item from the list, check the next one's my_owner,
and fix it accordingly. And take this case into account when last
of the list is deleted.
Also, assign NULL to 'my_owner' in g_thread_xp_WakeConditionVariable.
2011-12-22 10:51:31 +08:00
Chun-wei Fan
76bc1ab280
glib/tests/private.c: Fix compilation on Windows
...
-process.h must be included for _beginthreadex
-Use a cast to HANDLE on _beginthreadex to silence warnings on different
types
2011-12-22 10:39:05 +08:00
Ryan Lortie
541693f42d
winxp threads: fix some condition variable races
...
There are some races in the condition variable emulation code for
Windows XP with respect to timeouts while waiting.
First, in the event of a timeout, we never remove the waiter from the
condition variable. This can cause crashes later. That problem was
found by Rodrigo Rivas Costa.
Second, if the waiting thread times out and exits just as we were about
to call SetEvent() on its waiter event, we could end up trying to access
the waiter after it was closed/freed. We need to hold on to the lock a
little bit longer to ensure that that's not possible.
https://bugzilla.gnome.org/show_bug.cgi?id=666551
2011-12-19 17:40:08 -05:00
Ryan Lortie
11015f1652
windows XP threads: fix hilariously obvious race
...
I tried to do a double-checked lock without the double check.
Rodrigo Rivas Costa caught the problem and suggested the (obviously
correct) fix.
https://bugzilla.gnome.org/show_bug.cgi?id=666296
2011-12-16 10:54:42 -05:00
Ravi Sankar Guntur
1d4009e6f7
Added API g_queue_free_full().
...
g_queue_free_full(), to free a Queue including its dynamically-allocated elements.
On similar lines to List and Slist.
void g_queue_free_full (GQueue *queue, GDestroyNotify free_func);
Test case covering g_queue_free_full() is added.
Added export symbol to glib.symbols.
Closes Bug: https://bugzilla.gnome.org/show_bug.cgi?id=657433
Signed-off-by: Ravi Sankar Guntur <ravi.g@samsung.com >
2011-12-16 09:51:16 -05:00
Stef Walter
14fb10d14b
GBytes: add a size argument to g_bytes_get_data
...
* An out size argument so that this is more easily bindable
by gobject-introspection.
https://bugzilla.gnome.org/show_bug.cgi?id=665879
2011-12-15 07:22:37 +01:00
Simon McVittie
e129deb017
g_array_free, g_ptr_array_free: decrement refcount if not the last ref
...
foo_free is conceptually "worth" one unref; not decrementing the
refcount here means the GArray or GPtrArray wrapper (but not its
contents) would leak in the following call sequence:
p = g_ptr_array_new ();
g_ptr_array_ref (p);
g_ptr_array_free (p, TRUE);
g_ptr_array_unref (p);
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk >
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=666113
Reviewed-by: Emmanuele Bassi <ebassi@linux.intel.com >
2011-12-14 18:10:31 +00:00
Simon McVittie
df9d9cc72f
GArray, GPtrArray: factor out the actual freeing
...
Depending how the array is freed, we may want to free the underlying
array (the "segment"), the struct wrapper or both.
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk >
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=666113
Reviewed-by: Emmanuele Bassi <ebassi@linux.intel.com >
2011-12-14 18:10:25 +00:00
Simon McVittie
6457677b7d
g_key_file_get_string_list: don't leak the pieces on error
...
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk >
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=666113
Reviewed-by: Emmanuele Bassi <ebassi@linux.intel.com >
2011-12-14 18:09:48 +00:00
Ryan Lortie
a2e9318d4a
two test fixes for ARM
...
First, some ARM systems are not fast enough to meet the 30 second
deadline in gwakeuptest.c, so increase that to 60.
Second, we have some signed/unsigned woes in the gparam transform tests.
2011-12-14 09:33:30 -05:00
Simon McVittie
f6b2847e57
hash test: avoid leaking various keys and values
...
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk >
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=666115
Reviewed-by: Matthias Clasen <mclasen@redhat.com >
2011-12-14 12:40:57 +00:00
Simon McVittie
5dca72fe67
GOptionContext test: free all arguments, not just the remaining ones
...
On success, g_option_context_parse alters argv by removing options that
it understood, so g_strfreev is insufficient. Instead, take a shallow
copy and free all of the arguments in that, then free the array argv
but not its contents.
Also, improve the checks in error cases, by checking that argv has
not been altered in this way.
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk >
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=666115
Reviewed-by: Matthias Clasen <mclasen@redhat.com >
2011-12-14 12:40:39 +00:00
Simon McVittie
29f2ced8eb
various GLib tests: plug memory leaks
...
These don't really matter, since it's test code, but they do obscure
real leaks in the library.
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk >
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=666115
Acked-by: Matthias Clasen <mclasen@redhat.com >
2011-12-14 12:40:16 +00:00
Simon McVittie
93f8f8158f
g_variant_byteswap: don't leak serialised.data
...
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk >
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=666113
Reviewed-by: Matthias Clasen <mclasen@redhat.com >
2011-12-14 12:26:17 +00:00
Simon McVittie
c49a4dba82
g_data_set_internal: avoid use-after-free if datalist is in dataset
...
Removing the last thing in a dataset frees the dataset, and if the
datalist was in a dataset, we can't safely unlock it after the dataset
has been freed. Unlock it sooner.
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk >
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=666113
Reviewed-by: Matthias Clasen <mclasen@redhat.com >
2011-12-14 12:26:17 +00:00
Simon McVittie
0bf8378840
g_strcompress: check that source is non-NULL rather than just crashing
...
Calling this function with a NULL argument is considered to be invalid,
but one of the regression tests does it anyway (to watch it crash), which
seems a good indication that it's expected to be somewhat common.
Let's check it rather than segfaulting.
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk >
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=666113
Reviewed-by: Emmanuele Bassi <ebassi@linux.intel.com >
Reviewed-by: Matthias Clasen <mclasen@redhat.com >
2011-12-14 12:26:17 +00:00
Simon McVittie
90baa7e460
GKeyFile: free group comments when the group is removed
...
These were leaked. Valgrind was sad.
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk >
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=666113
Reviewed-by: Emmanuele Bassi <ebassi@linux.intel.com >
2011-12-14 12:26:16 +00:00
Simon McVittie
9ddb2f8091
g_hmac_get_string: don't allocate and leak an unused buffer
...
Also document why we're not actually using the buffer for anything.
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk >
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=666113
Reviewed-by: Emmanuele Bassi <ebassi@linux.intel.com >
2011-12-14 12:26:16 +00:00
Simon McVittie
64ca85ceae
g_hmac_copy: initialize the refcount
...
In practice, the uninitialized refcount will typically mean that the copy is
never freed, and leaks.
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk >
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=666113
Reviewed-by: Emmanuele Bassi <ebassi@linux.intel.com >
2011-12-14 12:26:16 +00:00
Matthias Clasen
edfab83c07
Add an explicit deprecation note to g_thread_init
...
https://bugzilla.gnome.org/show_bug.cgi?id=666145
2011-12-14 07:16:45 -05:00
Stef Walter
7e92997539
documentation fixes
...
Fixes for gtk-doc warnings.
http://bugzilla.gnome.org/show_bug.cgi?id=66469
https://bugzilla.gnome.org/show_bug.cgi?id=664699
2011-12-13 23:01:51 -05:00
Matthias Clasen
042954de9f
Fix since tag
2011-12-10 21:49:10 -05:00
Ryan Lortie
a8927732c9
GDate: gtk-doc fixup
2011-12-10 14:09:54 -05:00
Philip Withnall
386bb0faad
unicode: Fix a few issues with G_UNICHAR_MAX_DECOMPOSITION_LENGTH
...
Raised by Matthias in bgo#665685 but which I didn't spot until after pushing
commit 3ac7c35656
.
Renames G_UNICHAR_MAX_DECOMPOSITION_LEN to G_UNICHAR_MAX_DECOMPOSITION_LENGTH
and fixes a few documentation issues.
See: bgo#665685
2011-12-06 19:41:31 +00:00
Philip Withnall
3ac7c35656
Bug 665685 — Add a #define for the max length of a Unicode decomposition
...
Add G_UNICHAR_MAX_DECOMPOSITION_LEN for the maximum length of the
decomposition of a single Unicode character.
Closes: bgo#665685
2011-12-06 19:09:01 +00:00