mirror of
https://gitlab.gnome.org/GNOME/glib.git
synced 2025-09-28 01:57:14 +02:00
592082ef1d
This commit has the potential to close a thousand Coverity issues. On generated code from gdbus-codegen, Coverity typically warns on skeleton->priv->changed_properties_idle_source happening outside the skeleketon->priv->lock during finalize(), while it's protected by this mutex in other parts. Presumably if the object is in finalization, there should be no other threads poking at it, so the code is actually safe for the intended use and the warning moot. To address this, change gdbus-codegen to prefer g_clear_pointer() with glib >= 2.38 (should be most often the case nowadays) so this access is reserved to a single line of code, and mark this line of code with a Coverity code annotation in order to suppress the warning.