glib/gobject
Philip Withnall 0932f71460 gobject: Change GObject notify semantics under static analysis
Coverity notices the `g_object_unref()` call in `g_object_notify()`, but
not the paired `g_object_ref()` call. It therefore incorrectly assumes
that every call to `g_object_notify()` frees the object. This causes a
lot (hundreds) of false positive reports about double-frees or
use-after-frees.

I can’t find a way to fix this using a model file, so the other options
are:
 * Manually mark every report as a false positive and keep updating them
   as the code changes over time. This would take a lot of maintainer
   effort.
 * Comment out the `g_object_ref()`/`g_object_unref()` calls when
   running static analysis (but not in a normal production build). This
   is ugly, but cheap and shouldn’t impact maintainability much.

So this commit implements option 2.

Signed-off-by: Philip Withnall <pwithnall@endlessos.org>
2022-06-14 11:25:50 +01:00
..
2022-01-28 16:01:22 -08:00
2022-01-28 16:01:22 -08:00
2017-05-24 11:58:19 +02:00
2017-05-24 11:58:19 +02:00
2021-07-29 10:09:27 -04:00
2020-11-17 15:50:07 +00:00
2022-06-07 12:39:58 -04:00
2022-05-23 15:48:28 -04:00
2022-05-23 15:48:28 -04:00
2022-05-20 09:08:09 -04:00