Philip Withnall 153fa8884b glocalfileoutputstream: Fix CREATE_REPLACE_DESTINATION with symlinks ...

The `G_FILE_CREATE_REPLACE_DESTINATION` flag is equivalent to unlinking
the destination file and re-creating it from scratch. That did
previously work, but in the process the code would call `open(O_CREAT)`
on the file. If the file was a dangling symlink, this would create the
destination file (empty). That’s not an intended side-effect, and has
security implications if the symlink is controlled by a lower-privileged
process.

Fix that by not opening the destination file if it’s a symlink, and
adjusting the rest of the code to cope with
 - the fact that `fd == -1` is not an error iff `is_symlink` is true,
 - and that `original_stat` will contain the `lstat()` results for the
   symlink now, rather than the `stat()` results for its target (again,
   iff `is_symlink` is true).

This means that the target of the dangling symlink is no longer created,
which was the bug. The symlink itself continues to be replaced (as
before) with the new file — this is the intended behaviour of
`g_file_replace()`.

The behaviour for non-symlink cases, or cases where the symlink was not
dangling, should be unchanged.

Includes a unit test.

Signed-off-by: Philip Withnall <pwithnall@endlessos.org>

Fixes: #2325

2021-07-01 16:05:25 -05:00

..

cert-tests

Add certificate chain construction test

2015-08-29 08:43:29 -05:00

de/LC_MESSAGES

meson add missing gio/tests subdirectory/file

2017-07-13 19:03:39 -04:00

desktop-files

Exec=true (seach via PATH) instead of hardcoding /bin/true

2017-11-03 20:16:52 +00:00

gdbus-object-manager-example

Remove HAVE_CONFIG_H defs and uses

2018-02-21 13:57:10 +00:00

modules

gio: tests: modules: declare _get_type prototype

2018-02-21 10:56:31 +00:00

schema-tests

Don't skip invalid enum values in schemas

2017-10-11 10:22:23 +01:00

services

Adding test coverage for GTestDBus activating in-tree services.

2012-12-28 21:28:28 -05:00

thumbnails

tests: Add tests for the thumbnail verification code in GIO

2013-10-24 13:55:33 -04:00

x-content

Add tests for x-content type sniffing

2014-01-01 17:59:20 -05:00

.gitignore

gio: tests: rename generated giotypefunc.c to giotypefuncs.inc

2017-07-13 19:03:39 -04:00

actions.c

Allow property actions to invert booleans

2015-06-10 21:59:28 -04:00

appinfo-test2.desktop

Cleanups

2010-07-05 00:56:12 -04:00

appinfo-test-actions.desktop

Add missing file

2013-07-11 13:49:20 -04:00

appinfo-test-gnome.desktop

Add some more appinfo tests

2010-07-04 20:51:06 -04:00

appinfo-test-notgnome.desktop

Add some more appinfo tests

2010-07-04 20:51:06 -04:00

appinfo-test.c

Fix up the appinfo test

2013-11-23 22:21:29 -05:00

appinfo-test.desktop

gdesktopappinfo: Add g_desktop_app_info_get_locale_string()

2018-01-08 16:28:34 +01:00

appinfo.c

gio/tests/appinfo: New test for launch with "appId-less" applications

2017-12-08 13:47:23 +00:00

appmonitor.c

tests: Add temporary working directory for appmonitor test

2017-08-23 11:26:57 +01:00

apps.c

apps test: add new "monitor" subcommand

2014-09-09 14:11:38 -04:00

async-close-output-stream.c

gio: Use g_memdup2() instead of g_memdup() in obvious places

2021-07-01 16:05:25 -05:00

async-splice-output-stream.c

tests: Add testcases for g_output_stream_splice_async()

2013-09-29 17:48:40 -04:00

autoptr.c

tests: Add many autoptr tests

2015-02-23 10:40:40 -05:00

basic-application.c

Avoid a compiler warning

2014-01-01 22:01:15 -05:00

buffered-input-stream.c

gio/tests: add some more async stream tests

2013-01-16 10:17:15 -05:00

buffered-output-stream.c

Update tests for new truncate behavior

2013-12-15 21:07:12 -05:00

cancellable.c

gio/tests/: LGPLv2+ -> LGPLv2.1+

2017-05-29 19:53:34 +02:00

contenttype.c

gio: Show icons based on file's mime type on OS X

2017-11-03 12:04:33 +00:00

contexts.c

GContextSpecificGroup: add testcase

2016-04-26 15:20:16 +02:00

converter-stream.c

gtestutils: add g_assert_cmpmem()

2015-08-31 13:59:48 -04:00

credentials.c

gcredentials: add NetBSD support

2014-06-28 14:06:36 -04:00

data-input-stream.c

tests: data-input-stream: fix -Wduplicated-branches

2018-02-16 17:38:26 +00:00

data-output-stream.c

Update tests for new truncate behavior

2013-12-15 21:07:12 -05:00

dbus-appinfo.c

gio/tests/: LGPLv2+ -> LGPLv2.1+

2017-05-29 19:53:34 +02:00

dbus-launch.c

Replace all instances of ssize_t with gssize

2017-10-11 12:56:11 +01:00

de.po

…

defaultvalue.c

gio: tests: rename generated giotypefunc.c to giotypefuncs.inc

2017-07-13 19:03:39 -04:00

desktop-app-info.c

gdesktopappinfo: Add g_desktop_app_info_get_locale_string()

2018-01-08 16:28:34 +01:00

echo-server.c

Remove g_type_init() calls

2012-10-16 09:39:24 -04:00

enums.xml.template

…

file.c

glocalfileoutputstream: Fix CREATE_REPLACE_DESTINATION with symlinks

2021-07-01 16:05:25 -05:00

fileattributematcher.c

Simplify fileattributematcher tests a bit

2014-01-01 17:59:20 -05:00

filter-cat.c

gio/tests/: LGPLv2+ -> LGPLv2.1+

2017-05-29 19:53:34 +02:00

filter-streams.c

gio/tests/: LGPLv2+ -> LGPLv2.1+

2017-05-29 19:53:34 +02:00

g-file-info-filesystem-readonly.c

gio/tests: Add testcase for bug 787731

2017-09-22 20:28:44 +05:00

g-file-info.c

W32: Add a stat() implementation for private use

2017-11-01 12:46:38 +00:00

g-file.c

tests: replace most g_print() with g_printerr()

2015-05-11 20:24:56 +01:00

g-icon.c

g-icon: Fix memory leak in test

2013-11-11 07:11:29 +01:00

gapplication-example-actions.c

Don't use deprecated GApplication api in examples

2011-12-08 18:05:15 -05:00

gapplication-example-cmdline2.c

Remove g_type_init() calls

2012-10-16 09:39:24 -04:00

gapplication-example-cmdline3.c

e G_SOURCE_CONTINUE/REMOVE internally

2012-01-25 16:15:18 -05:00

gapplication-example-cmdline4.c

Bug-790839 GApplication command line --help enhancements

2018-01-03 11:08:37 +00:00

gapplication-example-cmdline.c

Tweak GApplication docs

2010-11-02 23:02:05 -04:00

gapplication-example-dbushooks.c

Remove g_type_init() calls

2012-10-16 09:39:24 -04:00

gapplication-example-open.c

Tweak GApplication docs

2010-11-02 23:02:05 -04:00

gapplication.c

gapplication: Tighten up application ID validation

2018-03-13 12:51:38 +00:00

gdbus-addresses.c

g_dbus_is_supported_address(): set error if returning FALSE

2018-06-13 13:35:35 +01:00

gdbus-auth.c

gio/tests/: LGPLv2+ -> LGPLv2.1+

2017-05-29 19:53:34 +02:00

gdbus-bz627724.c

gio/tests/: LGPLv2+ -> LGPLv2.1+

2017-05-29 19:53:34 +02:00

gdbus-close-pending.c

gio/tests/: LGPLv2+ -> LGPLv2.1+

2017-05-29 19:53:34 +02:00

gdbus-connection-flush-helper.c

gio/tests/: LGPLv2+ -> LGPLv2.1+

2017-05-29 19:53:34 +02:00

gdbus-connection-flush.c

gio/tests/: LGPLv2+ -> LGPLv2.1+

2017-05-29 19:53:34 +02:00

gdbus-connection-loss.c

gio/tests/: LGPLv2+ -> LGPLv2.1+

2017-05-29 19:53:34 +02:00

gdbus-connection-slow.c

gio/tests/: LGPLv2+ -> LGPLv2.1+

2017-05-29 19:53:34 +02:00

gdbus-connection.c

gio/tests/: LGPLv2+ -> LGPLv2.1+

2017-05-29 19:53:34 +02:00

gdbus-daemon.c

Remove g_type_init() calls

2012-10-16 09:39:24 -04:00

gdbus-error.c

gio/tests/: LGPLv2+ -> LGPLv2.1+

2017-05-29 19:53:34 +02:00

gdbus-example-export.c

Drop trailing semi-colon from G_DEFINE_ macro

2017-04-10 10:38:31 +01:00

gdbus-example-objectmanager-client.c

Rework the build system for a new tests approach

2013-05-31 23:12:15 -04:00

gdbus-example-objectmanager-server.c

Rework the build system for a new tests approach

2013-05-31 23:12:15 -04:00

gdbus-example-own-name.c

Remove g_type_init() calls

2012-10-16 09:39:24 -04:00

gdbus-example-peer.c

Remove g_type_init() calls

2012-10-16 09:39:24 -04:00

gdbus-example-proxy-subclass.c

Drop trailing semi-colon from G_DEFINE_ macro

2017-04-10 10:38:31 +01:00

gdbus-example-server.c

Remove g_type_init() calls

2012-10-16 09:39:24 -04:00

gdbus-example-subtree.c

Use 'dumb quotes' rather than `really dumb quotes'

2013-05-21 11:23:22 -03:00

gdbus-example-unix-fd-client.c

gdbus-example-unix-fd-client: avoid strftime %c specifier

2016-08-15 14:04:43 +01:00

gdbus-example-watch-name.c

Remove g_type_init() calls

2012-10-16 09:39:24 -04:00

gdbus-example-watch-proxy.c

Remove g_type_init() calls

2012-10-16 09:39:24 -04:00

gdbus-exit-on-close.c

gio/tests/: LGPLv2+ -> LGPLv2.1+

2017-05-29 19:53:34 +02:00

gdbus-export.c

gio: Use g_memdup2() instead of g_memdup() in obvious places

2021-07-01 16:05:25 -05:00

gdbus-introspection.c

gio/tests/: LGPLv2+ -> LGPLv2.1+

2017-05-29 19:53:34 +02:00

gdbus-message.c

gio/tests/: LGPLv2+ -> LGPLv2.1+

2017-05-29 19:53:34 +02:00

gdbus-names.c

gio/tests/: LGPLv2+ -> LGPLv2.1+

2017-05-29 19:53:34 +02:00

gdbus-non-socket.c

gio/tests/: LGPLv2+ -> LGPLv2.1+

2017-05-29 19:53:34 +02:00

gdbus-overflow.c

gio/tests/: LGPLv2+ -> LGPLv2.1+

2017-05-29 19:53:34 +02:00

gdbus-peer-object-manager.c

Consistently save errno immediately after the operation setting it

2017-08-03 10:21:13 +01:00

gdbus-peer.c

Allow running gdbus-peer inside a container

2018-02-20 13:49:21 +00:00

gdbus-proxy-threads.c

gio/tests/: LGPLv2+ -> LGPLv2.1+

2017-05-29 19:53:34 +02:00

gdbus-proxy-well-known-name.c

gio/tests/: LGPLv2+ -> LGPLv2.1+

2017-05-29 19:53:34 +02:00

gdbus-proxy.c

gdbus-proxy: Fix erroneous timeout during following tests

2017-10-26 12:01:05 +01:00

gdbus-serialization.c

tests: Use g_assert_null() in gdbus-serialization test

2018-11-06 12:07:47 +00:00

gdbus-sessionbus.c

gio/tests/: LGPLv2+ -> LGPLv2.1+

2017-05-29 19:53:34 +02:00

gdbus-sessionbus.h

gio/tests/: LGPLv2+ -> LGPLv2.1+

2017-05-29 19:53:34 +02:00

gdbus-test-codegen.c

gdbus-codegen: honor "Property.EmitsChangedSignal" annotations

2021-06-23 10:05:44 -05:00

gdbus-test-fixture.c

Rework the build system for a new tests approach

2013-05-31 23:12:15 -04:00

gdbus-tests.c

gio/tests/: LGPLv2+ -> LGPLv2.1+

2017-05-29 19:53:34 +02:00

gdbus-tests.h

gio/tests/: LGPLv2+ -> LGPLv2.1+

2017-05-29 19:53:34 +02:00

gdbus-testserver.c

Add a C version of gdbus-testserver.py

2013-01-03 13:14:26 -05:00

gdbus-threading.c

gdbus-threading test: Allow even longer for test_method_calls_in_thread

2018-01-09 13:10:38 +00:00

gdbus-unix-addresses.c

gdbus unix addresses test: don't g_debug when also testing stdout

2021-06-23 10:03:59 -05:00

gengiotypefuncs.py

meson: gio/tests: add more missing tests

2017-07-13 19:03:39 -04:00

gio-du.c

win32: Replace usage of __wgetmainargs()

2015-07-23 04:22:59 -04:00

giomodule.c

giomodule test: fix again

2014-01-13 16:12:31 -05:00

glistmodel.c

gio/tests/: LGPLv2+ -> LGPLv2.1+

2017-05-29 19:53:34 +02:00

gmenumodel.c

gmenumodel test: Wait for the expected events to happen

2017-12-18 18:56:35 +00:00

gnotification-server.c

gio/tests/: LGPLv2+ -> LGPLv2.1+

2017-05-29 19:53:34 +02:00

gnotification-server.h

gio/tests/: LGPLv2+ -> LGPLv2.1+

2017-05-29 19:53:34 +02:00

gnotification.c

gio/tests/: LGPLv2+ -> LGPLv2.1+

2017-05-29 19:53:34 +02:00

gschema-compile.c

tests: Fix case of a string comparison

2017-10-11 14:05:21 +01:00

gsettings.c

keyfile settings: Accept unquoted strings

2021-06-23 10:05:44 -05:00

gsubprocess-testprog.c

Consistently save errno immediately after the operation setting it

2017-08-03 10:21:13 +01:00

gsubprocess.c

tests, subprocess: units for cancelled communications

2018-08-30 13:25:35 +01:00

gtesttlsbackend.c

gio/tests/: LGPLv2+ -> LGPLv2.1+

2017-05-29 19:53:34 +02:00

gtesttlsbackend.h

gio/tests/: LGPLv2+ -> LGPLv2.1+

2017-05-29 19:53:34 +02:00

gtlsconsoleinteraction.c

gio/tests/: LGPLv2+ -> LGPLv2.1+

2017-05-29 19:53:34 +02:00

gtlsconsoleinteraction.h

gio/tests/: LGPLv2+ -> LGPLv2.1+

2017-05-29 19:53:34 +02:00

httpd.c

Avoid setting unused variables (-Wself-assign)

2017-09-11 22:14:18 +01:00

inet-address.c

Fix gio/tests/inet-address on OS X

2016-07-11 17:42:41 -04:00

io-stream.c

tests: add GSimpleIOStream async close tests

2015-02-17 16:27:46 -05:00

live-g-file.c

tests: replace most g_print() with g_printerr()

2015-05-11 20:24:56 +01:00

live-g-file.txt

…

Makefile.am

Add a test for per-desktop overrides

2021-06-23 10:03:59 -05:00

memory-input-stream.c

Improve GMemoryInputStream test coverage

2013-06-02 01:44:49 -04:00

memory-output-stream.c

Expand the truncate tests

2013-12-15 21:07:12 -05:00

meson.build

tests: Increase timeout for network-monitor-race test

2018-08-22 11:22:02 +01:00

mimeapps.c

tests: use mimeapps.list over defaults.list

2014-04-15 11:36:39 -04:00

monitor.c

tests: Add temporary working directory for monitor test

2017-08-23 11:26:57 +01:00

network-address.c

tests: Drop a slightly suspect GResolver test

2018-04-26 09:55:14 +01:00

network-monitor-race.c

gnetworkmonitor: Fix use-after-free when using from another thread

2018-08-16 16:53:53 -04:00

network-monitor.c

tests/network-monitor: Always use the dummy proxy resolver

2018-04-10 10:36:42 +01:00

org.gtk.schemasourcecheck.gschema.xml

Add test case and fix some bugs

2011-11-17 14:03:39 +00:00

org.gtk.test.dbusappinfo.desktop

Make a test desktop file a little less invalid

2013-07-14 11:36:45 -04:00

org.gtk.test.gschema.override.orig

Add a test for per-desktop overrides

2021-06-23 10:03:59 -05:00

org.gtk.test.gschema.xml.orig

Add a test for per-desktop overrides

2021-06-23 10:03:59 -05:00

permission.c

Remove g_type_init() calls

2012-10-16 09:39:24 -04:00

pollable.c

gio/tests/: LGPLv2+ -> LGPLv2.1+

2017-05-29 19:53:34 +02:00

proxy-test.c

gio/tests/: LGPLv2+ -> LGPLv2.1+

2017-05-29 19:53:34 +02:00

proxy.c

gio/tests/: LGPLv2+ -> LGPLv2.1+

2017-05-29 19:53:34 +02:00

readwrite.c

gtestutils: add g_assert_cmpmem()

2015-08-31 13:59:48 -04:00

resolver.c

gio/tests/: LGPLv2+ -> LGPLv2.1+

2017-05-29 19:53:34 +02:00

resourceplugin.c

visibility: Use a separate CFLAGS variable

2013-01-14 23:31:59 -05:00

resources.c

gresource: avoid allocations in enumerate_children()

2017-11-15 03:24:29 -08:00

send-data.c

Remove g_type_init() calls

2012-10-16 09:39:24 -04:00

simple-async-result.c

gio/tests/: LGPLv2+ -> LGPLv2.1+

2017-05-29 19:53:34 +02:00

simple-proxy.c

GSimpleProxyResolver: Add test case for broken hostname

2018-02-01 14:58:28 +00:00

sleepy-stream.c

gio/tests/: LGPLv2+ -> LGPLv2.1+

2017-05-29 19:53:34 +02:00

socket-address.c

gsocketconnectable: Add a to_string() virtual method

2015-10-13 15:42:14 +01:00

socket-client.c

Remove g_type_init() calls

2012-10-16 09:39:24 -04:00

socket-common.c

gio/tests/socket-common.c: add a missing #ifdef G_OS_UNIX

2012-02-03 12:58:53 -05:00

socket-listener.c

gio/tests/: LGPLv2+ -> LGPLv2.1+

2017-05-29 19:53:34 +02:00

socket-server.c

Remove g_type_init() calls

2012-10-16 09:39:24 -04:00

socket-service.c

gio/tests/: LGPLv2+ -> LGPLv2.1+

2017-05-29 19:53:34 +02:00

socket.c

tests: Skip GSocket tests if setting up a server fails

2018-04-26 09:55:06 +01:00

srvtarget.c

Remove g_type_init() calls

2012-10-16 09:39:24 -04:00

stream-rw_all.c

gio/tests/: LGPLv2+ -> LGPLv2.1+

2017-05-29 19:53:34 +02:00

task.c

gio/tests/: LGPLv2+ -> LGPLv2.1+

2017-05-29 19:53:34 +02:00

test1.txt

Add tests for GResource

2012-01-13 17:12:53 +01:00

test2.gresource.xml

Add tests for GResource

2012-01-13 17:12:53 +01:00

test2.txt

Add tests for GResource

2012-01-13 17:12:53 +01:00

test3.gresource.xml

Add tests for GResource

2012-01-13 17:12:53 +01:00

test3.txt

Add tests for GResource

2012-01-13 17:12:53 +01:00

test4.gresource.xml

Add tests for GResource

2012-01-13 17:12:53 +01:00

test-codegen.xml

gdbus-codegen: honor "Property.EmitsChangedSignal" annotations

2021-06-23 10:05:44 -05:00

test-io-stream.c

gio/tests/: LGPLv2+ -> LGPLv2.1+

2017-05-29 19:53:34 +02:00

test-io-stream.h

gio/tests/: LGPLv2+ -> LGPLv2.1+

2017-05-29 19:53:34 +02:00

test-pipe-unix.c

docs: Drop unnecessary <!-- -->s from gtk-doc comments

2017-11-29 17:50:27 +00:00

test-pipe-unix.h

gio/tests/: LGPLv2+ -> LGPLv2.1+

2017-05-29 19:53:34 +02:00

test.gresource.xml

glib-compile-resources: correct resource compiler dependency for generated files

2016-06-04 08:24:22 -04:00

testenum.h

Bug 622124 - implement flags for GSettings

2010-07-01 19:06:02 -04:00

testfilemonitor.c

tests: Fix a minor memory leak in the GFileMonitor tests

2018-04-18 15:37:33 +01:00

thumbnail-verification.c

Fix the thumbnail-verification Test

2015-04-22 18:56:50 +08:00

tls-certificate.c

gio/tests/: LGPLv2+ -> LGPLv2.1+

2017-05-29 19:53:34 +02:00

tls-interaction.c

gio/tests/: LGPLv2+ -> LGPLv2.1+

2017-05-29 19:53:34 +02:00

unix-fd.c

Add gnetworking.h

2012-12-12 15:20:22 +01:00

unix-mounts.c

Merge branch 'cifs-is-not-a-system-fs' into 'master'

2018-06-29 07:11:54 +00:00

unix-streams.c

Improve unix stream test coverage

2013-06-02 01:47:19 -04:00

vfs.c

vfs: Fix return value of get_supported_uri_schemes()

2016-06-28 15:57:49 +02:00

volumemonitor.c

Remove g_type_init() calls

2012-10-16 09:39:24 -04:00

win32-streams.c

Fix tests to compile again - add missing headers to W32, call correct process-id-getting function

2014-08-02 12:41:14 +00:00