mirror of
https://gitlab.gnome.org/GNOME/glib.git
synced 2024-09-20 17:26:14 +02:00
79d4ba9438
2002-01-23 Tor Lillqvist <tml@iki.fi>
* glib/gconvert.c: (strdup_len): Not used on Windows, don't even
compile it then.
(acceptable): Improve comments for the _acceptable_ table: put
each ASCII char above the hex number for it.
(g_escape_file_uri): On Windows, turn backslashes in the file name
into plain ("forward") slashes.
(g_filename_from_uri): On Windows, don't return the hostname
"localhost", because we can not be 100% sure it will be recognized
in all cases anyway, so simpler to turn it into a null
hostname.
Change slashes in the filename into backslashes, as that is the
more canonical separator.
Recognize drive letters (either followed by a colon or a vertical
bar, as used by some browsers), and if the filename part starts
with a such, don't include any (back)slash.
Don't drop any extra leading slash in the filename on Unix.
(g_filename_to_uri): On Windows, if the hostname is "localhost",
don't use it, for consistency with g_filename_from_uri().
tests/uri-test.c: Change accordingly, so that all tests pass on
Windows. Unix, too, I hope, though I couldn't check that now.
(main): Unset the G_BROKEN_FILENAMES environment variable on Unix,
as some tests require that filenames are in UTF-8. Is unsetenv()
portable?
These changes should fix bugs #59387, #59652, #59657 and #59658.
325 lines
11 KiB
C
325 lines
11 KiB
C
/* GLIB - Library of useful routines for C programming
|
||
* Copyright (C) 1995-1997 Peter Mattis, Spencer Kimball and Josh MacDonald
|
||
*
|
||
* This library is free software; you can redistribute it and/or
|
||
* modify it under the terms of the GNU Lesser General Public
|
||
* License as published by the Free Software Foundation; either
|
||
* version 2 of the License, or (at your option) any later version.
|
||
*
|
||
* This library is distributed in the hope that it will be useful,
|
||
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
||
* Lesser General Public License for more details.
|
||
*
|
||
* You should have received a copy of the GNU Lesser General Public
|
||
* License along with this library; if not, write to the
|
||
* Free Software Foundation, Inc., 59 Temple Place - Suite 330,
|
||
* Boston, MA 02111-1307, USA.
|
||
*/
|
||
|
||
/*
|
||
* Modified by the GLib Team and others 1997-2000. See the AUTHORS
|
||
* file for a list of people on the GLib Team. See the ChangeLog
|
||
* files for a list of changes. These files are distributed with
|
||
* GLib at ftp://ftp.gtk.org/pub/gtk/.
|
||
*/
|
||
|
||
#undef G_DISABLE_ASSERT
|
||
#undef G_LOG_DOMAIN
|
||
|
||
#include <glib.h>
|
||
#include <stdio.h>
|
||
#include <string.h>
|
||
#include <stdlib.h>
|
||
|
||
typedef struct
|
||
{
|
||
char *filename;
|
||
char *hostname;
|
||
char *expected_result;
|
||
GConvertError expected_error; /* If failed */
|
||
} ToUriTest;
|
||
|
||
ToUriTest
|
||
to_uri_tests[] = {
|
||
{ "/etc", NULL, "file:///etc"},
|
||
{ "/etc", "", "file:///etc"},
|
||
{ "/etc", "otherhost", "file://otherhost/etc"},
|
||
#ifdef G_OS_WIN32
|
||
{ "/etc", "localhost", "file:///etc"},
|
||
{ "c:\\windows", NULL, "file:///c:/windows"},
|
||
{ "c:\\windows", "localhost", "file:///c:/windows"},
|
||
{ "c:\\windows", "otherhost", "file://otherhost/c:/windows"},
|
||
{ "\\\\server\\share\\dir", NULL, "file:////server/share/dir"},
|
||
{ "\\\\server\\share\\dir", "localhost", "file:////server/share/dir"},
|
||
#else
|
||
{ "/etc", "localhost", "file://localhost/etc"},
|
||
{ "c:\\windows", NULL, NULL, G_CONVERT_ERROR_NOT_ABSOLUTE_PATH}, /* it's important to get this error on Unix */
|
||
{ "c:\\windows", "localhost", NULL, G_CONVERT_ERROR_NOT_ABSOLUTE_PATH},
|
||
{ "c:\\windows", "otherhost", NULL, G_CONVERT_ERROR_NOT_ABSOLUTE_PATH},
|
||
#endif
|
||
{ "etc", "localhost", NULL, G_CONVERT_ERROR_NOT_ABSOLUTE_PATH},
|
||
#ifndef G_OS_WIN32
|
||
/* g_filename_to_utf8 uses current code page on Win32, these tests assume that
|
||
* local filenames *are* in UTF-8.
|
||
*/
|
||
{ "/etc/<2F><><EFBFBD>", NULL, NULL, G_CONVERT_ERROR_ILLEGAL_SEQUENCE},
|
||
{ "/etc/öäå", NULL, "file:///etc/%C3%B6%C3%A4%C3%A5"},
|
||
#endif
|
||
{ "/etc", "öäå", "file://%C3%B6%C3%A4%C3%A5/etc"},
|
||
{ "/etc", "<EFBFBD><EFBFBD><EFBFBD>", NULL, G_CONVERT_ERROR_ILLEGAL_SEQUENCE},
|
||
{ "/etc/file with #%", NULL, "file:///etc/file%20with%20%23%25"},
|
||
{ "", NULL, NULL, G_CONVERT_ERROR_NOT_ABSOLUTE_PATH},
|
||
{ "", "", NULL, G_CONVERT_ERROR_NOT_ABSOLUTE_PATH},
|
||
{ "", "localhost", NULL, G_CONVERT_ERROR_NOT_ABSOLUTE_PATH},
|
||
{ "", "otherhost", NULL, G_CONVERT_ERROR_NOT_ABSOLUTE_PATH},
|
||
{ "/0123456789", NULL, "file:///0123456789"},
|
||
{ "/ABCDEFGHIJKLMNOPQRSTUVWXYZ", NULL, "file:///ABCDEFGHIJKLMNOPQRSTUVWXYZ"},
|
||
{ "/abcdefghijklmnopqrstuvwxyz", NULL, "file:///abcdefghijklmnopqrstuvwxyz"},
|
||
{ "/-_.!~*'()", NULL, "file:///-_.!~*'()"},
|
||
#ifdef G_OS_WIN32
|
||
/* As '\\' is a path separator on Win32, it gets turned into '/' in the URI */
|
||
{ "/\"#%<>[\\]^`{|}\x7F", NULL, "file:///%22%23%25%3C%3E%5B/%5D%5E%60%7B%7C%7D%7F"},
|
||
#else
|
||
/* On Unix, '\\' is a normal character in the file name */
|
||
{ "/\"#%<>[\\]^`{|}\x7F", NULL, "file:///%22%23%25%3C%3E%5B%5C%5D%5E%60%7B%7C%7D%7F"},
|
||
#endif
|
||
{ "/;@+$,", NULL, "file:///%3B%40%2B%24%2C"},
|
||
/* This and some of the following are of course as such illegal file names on Windows,
|
||
* and would not occur in real life.
|
||
*/
|
||
{ "/:", NULL, "file:///:"},
|
||
{ "/?&=", NULL, "file:///?&="}, /* these are not escaped and other reserved characters are -- is that really what we want? */
|
||
{ "/", "0123456789", "file://0123456789/"},
|
||
{ "/", "ABCDEFGHIJKLMNOPQRSTUVWXYZ", "file://ABCDEFGHIJKLMNOPQRSTUVWXYZ/"},
|
||
{ "/", "abcdefghijklmnopqrstuvwxyz", "file://abcdefghijklmnopqrstuvwxyz/"},
|
||
{ "/", "-_.!~*'()", "file://-_.!~*'()/"},
|
||
{ "/", "\"#%<>[\\]^`{|}\x7F", "file://%22%23%25%3C%3E%5B%5C%5D%5E%60%7B%7C%7D%7F/"},
|
||
{ "/", ";?&=+$,", "file://%3B%3F%26%3D%2B%24%2C/"},
|
||
{ "/", "/", "file:////"}, /* should be "file://%2F/" or an error */
|
||
{ "/", "@:", "file://@:/"}, /* these are not escaped and other reserved characters are -- is that really what we want? */
|
||
{ "/", "\x80\xFF", NULL, G_CONVERT_ERROR_ILLEGAL_SEQUENCE},
|
||
{ "/", "\xC3\x80\xC3\xBF", "file://%C3%80%C3%BF/"},
|
||
};
|
||
|
||
|
||
typedef struct
|
||
{
|
||
char *uri;
|
||
char *expected_filename;
|
||
char *expected_hostname;
|
||
GConvertError expected_error; /* If failed */
|
||
} FromUriTest;
|
||
|
||
FromUriTest
|
||
from_uri_tests[] = {
|
||
{ "file:///etc", "/etc"},
|
||
{ "file:/etc", "/etc"},
|
||
#ifdef G_OS_WIN32
|
||
/* On Win32 we don't return "localhost" hostames, just in case
|
||
* it isn't recognized anyway.
|
||
*/
|
||
{ "file://localhost/etc", "/etc", NULL},
|
||
{ "file://localhost/etc/%23%25%20file", "/etc/#% file", NULL},
|
||
#else
|
||
{ "file://localhost/etc", "/etc", "localhost"},
|
||
{ "file://localhost/etc/%23%25%20file", "/etc/#% file", "localhost"},
|
||
#endif
|
||
{ "file://otherhost/etc", "/etc", "otherhost"},
|
||
{ "file://otherhost/etc/%23%25%20file", "/etc/#% file", "otherhost"},
|
||
{ "file://%C3%B6%C3%A4%C3%A5/etc", "/etc", "öäå"},
|
||
{ "file:////etc/%C3%B6%C3%C3%C3%A5", NULL, NULL, G_CONVERT_ERROR_BAD_URI},
|
||
{ "file://localhost/<2F><><EFBFBD>", NULL, NULL, G_CONVERT_ERROR_BAD_URI},
|
||
{ "file://<2F><><EFBFBD>/etc", NULL, NULL, G_CONVERT_ERROR_BAD_URI},
|
||
{ "file:///some/file#bad", NULL, NULL, G_CONVERT_ERROR_BAD_URI},
|
||
{ "file://some", NULL, NULL, G_CONVERT_ERROR_BAD_URI},
|
||
{ "", NULL, NULL, G_CONVERT_ERROR_BAD_URI},
|
||
{ "file:test", NULL, NULL, G_CONVERT_ERROR_BAD_URI},
|
||
{ "http://www.yahoo.com/", NULL, NULL, G_CONVERT_ERROR_BAD_URI},
|
||
{ "file:////etc", "//etc"},
|
||
{ "file://///etc", "///etc"},
|
||
#ifdef G_OS_WIN32
|
||
/* URIs with backslashes come from some nonstandard application, but accept them anyhow */
|
||
{ "file:///c:\\foo", "c:\\foo"},
|
||
{ "file:///c:/foo\\bar", "c:\\foo\\bar"},
|
||
/* Accept also the old Netscape drive-letter-and-vertical bar convention */
|
||
{ "file:///c|/foo", "c:\\foo"},
|
||
{ "file:////server/share/dir", "\\\\server\\share\\dir"},
|
||
{ "file://localhost//server/share/foo", "\\\\server\\share\\foo"},
|
||
{ "file://otherhost//server/share/foo", "\\\\server\\share\\foo", "otherhost"},
|
||
#else
|
||
{ "file:///c:\\foo", "/c:\\foo"},
|
||
{ "file:///c:/foo", "/c:/foo"},
|
||
{ "file:////c:/foo", "//c:/foo"},
|
||
#endif
|
||
{ "file://0123456789/", "/", "0123456789"},
|
||
{ "file://ABCDEFGHIJKLMNOPQRSTUVWXYZ/", "/", "ABCDEFGHIJKLMNOPQRSTUVWXYZ"},
|
||
{ "file://abcdefghijklmnopqrstuvwxyz/", "/", "abcdefghijklmnopqrstuvwxyz"},
|
||
{ "file://-_.!~*'()/", "/", "-_.!~*'()"},
|
||
{ "file://\"<>[\\]^`{|}\x7F/", "/", "\"<>[\\]^`{|}\x7F"},
|
||
{ "file://;?&=+$,/", "/", ";?&=+$,"},
|
||
{ "file://%C3%80%C3%BF/", "/", "\xC3\x80\xC3\xBF"},
|
||
{ "file://@/", "/", "@"},
|
||
{ "file://:/", "/", ":"},
|
||
{ "file://#/", NULL, NULL, G_CONVERT_ERROR_BAD_URI},
|
||
{ "file://%23/", "/", "#"}, /* is it dangerous to return a hostname with a "#" character in it? */
|
||
{ "file://%2F/", "/", "/"}, /* is it dangerous to return a hostname with a "/" character in it? */
|
||
};
|
||
|
||
|
||
static gboolean any_failed = FALSE;
|
||
|
||
static void
|
||
run_to_uri_tests (void)
|
||
{
|
||
int i;
|
||
gchar *res;
|
||
GError *error;
|
||
|
||
for (i = 0; i < G_N_ELEMENTS (to_uri_tests); i++)
|
||
{
|
||
error = NULL;
|
||
res = g_filename_to_uri (to_uri_tests[i].filename,
|
||
to_uri_tests[i].hostname,
|
||
&error);
|
||
|
||
if (to_uri_tests[i].expected_result == NULL)
|
||
{
|
||
if (res != NULL)
|
||
{
|
||
g_print ("\ng_filename_to_uri() test %d failed, expected to return NULL, actual result: %s\n", i, res);
|
||
any_failed = TRUE;
|
||
}
|
||
else
|
||
{
|
||
if (error == NULL)
|
||
{
|
||
g_print ("\ng_filename_to_uri() test %d failed, returned NULL, but didn't set error\n", i);
|
||
any_failed = TRUE;
|
||
}
|
||
else if (error->domain != G_CONVERT_ERROR)
|
||
{
|
||
g_print ("\ng_filename_to_uri() test %d failed, returned NULL, set non G_CONVERT_ERROR error\n", i);
|
||
any_failed = TRUE;
|
||
}
|
||
else if (error->code != to_uri_tests[i].expected_error)
|
||
{
|
||
g_print ("\ng_filename_to_uri() test %d failed as expected, but set wrong errorcode %d instead of expected %d \n",
|
||
i, error->code, to_uri_tests[i].expected_error);
|
||
any_failed = TRUE;
|
||
}
|
||
}
|
||
}
|
||
else if (res == NULL || strcmp (res, to_uri_tests[i].expected_result) != 0)
|
||
{
|
||
g_print ("\ng_filename_to_uri() test %d failed, expected result: %s, actual result: %s\n",
|
||
i, to_uri_tests[i].expected_result, (res) ? res : "NULL");
|
||
if (error)
|
||
g_print ("Error message: %s\n", error->message);
|
||
any_failed = TRUE;
|
||
}
|
||
|
||
/* Give some output */
|
||
g_print (".");
|
||
}
|
||
}
|
||
|
||
static void
|
||
run_from_uri_tests (void)
|
||
{
|
||
int i;
|
||
gchar *res;
|
||
gchar *hostname;
|
||
GError *error;
|
||
|
||
for (i = 0; i < G_N_ELEMENTS (from_uri_tests); i++)
|
||
{
|
||
error = NULL;
|
||
res = g_filename_from_uri (from_uri_tests[i].uri,
|
||
&hostname,
|
||
&error);
|
||
|
||
if (from_uri_tests[i].expected_filename == NULL)
|
||
{
|
||
if (res != NULL)
|
||
{
|
||
g_print ("\ng_filename_from_uri() test %d failed, expected to return NULL, actual result: %s\n", i, res);
|
||
any_failed = TRUE;
|
||
}
|
||
else
|
||
{
|
||
if (error == NULL)
|
||
{
|
||
g_print ("\ng_filename_from_uri() test %d failed, returned NULL, but didn't set error\n", i);
|
||
any_failed = TRUE;
|
||
}
|
||
else if (error->domain != G_CONVERT_ERROR)
|
||
{
|
||
g_print ("\ng_filename_from_uri() test %d failed, returned NULL, set non G_CONVERT_ERROR error\n", i);
|
||
any_failed = TRUE;
|
||
}
|
||
else if (error->code != from_uri_tests[i].expected_error)
|
||
{
|
||
g_print ("\ng_filename_from_uri() test %d failed as expected, but set wrong errorcode %d instead of expected %d \n",
|
||
i, error->code, from_uri_tests[i].expected_error);
|
||
any_failed = TRUE;
|
||
}
|
||
}
|
||
}
|
||
else
|
||
{
|
||
#ifdef G_OS_WIN32
|
||
gchar *slash, *p;
|
||
|
||
p = from_uri_tests[i].expected_filename = g_strdup (from_uri_tests[i].expected_filename);
|
||
while ((slash = strchr (p, '/')) != NULL)
|
||
{
|
||
*slash = '\\';
|
||
p = slash + 1;
|
||
}
|
||
#endif
|
||
if (res == NULL || strcmp (res, from_uri_tests[i].expected_filename) != 0)
|
||
{
|
||
g_print ("\ng_filename_from_uri() test %d failed, expected result: %s, actual result: %s\n",
|
||
i, from_uri_tests[i].expected_filename, (res) ? res : "NULL");
|
||
any_failed = TRUE;
|
||
}
|
||
|
||
if (from_uri_tests[i].expected_hostname == NULL)
|
||
{
|
||
if (hostname != NULL)
|
||
{
|
||
g_print ("\ng_filename_from_uri() test %d failed, expected no hostname, got: %s\n",
|
||
i, hostname);
|
||
any_failed = TRUE;
|
||
}
|
||
}
|
||
else if (hostname == NULL ||
|
||
strcmp (hostname, from_uri_tests[i].expected_hostname) != 0)
|
||
{
|
||
g_print ("\ng_filename_from_uri() test %d failed, expected hostname: %s, actual result: %s\n",
|
||
i, from_uri_tests[i].expected_hostname, (hostname) ? hostname : "NULL");
|
||
any_failed = TRUE;
|
||
}
|
||
}
|
||
|
||
/* Give some output */
|
||
g_print (".");
|
||
}
|
||
g_print ("\n");
|
||
}
|
||
|
||
int
|
||
main (int argc,
|
||
char *argv[])
|
||
{
|
||
#ifdef G_OS_UNIX
|
||
unsetenv ("G_BROKEN_FILENAMES");
|
||
#endif
|
||
|
||
run_to_uri_tests ();
|
||
run_from_uri_tests ();
|
||
|
||
return any_failed ? 1 : 0;
|
||
}
|