mirror of
https://gitlab.gnome.org/GNOME/glib.git
synced 2024-12-27 16:06:16 +01:00
30e102518a
The `g_content_type_guess_for_tree` function segfaults currently when processing filenames that are not valid unicode strings. Let's use the `g_filename_to_utf8` and `g_utf8_make_valid` functions before other processing to prevent that. Let's also add a test for it to avoid this in future. Fixes: https://gitlab.gnome.org/GNOME/glib/-/issues/3168
503 lines
15 KiB
C
503 lines
15 KiB
C
#include <gio/gio.h>
|
||
#include <string.h>
|
||
|
||
#define g_assert_content_type_equals(s1, s2) \
|
||
do { \
|
||
const char *__s1 = (s1), *__s2 = (s2); \
|
||
if (g_content_type_equals (__s1, __s2)) ; \
|
||
else \
|
||
g_assertion_message_cmpstr (G_LOG_DOMAIN, \
|
||
__FILE__, __LINE__, \
|
||
G_STRFUNC, \
|
||
#s1 " == " #s2, \
|
||
__s1, " == ", __s2); \
|
||
} while (0)
|
||
|
||
static void
|
||
test_guess (void)
|
||
{
|
||
gchar *res;
|
||
gchar *expected;
|
||
gchar *existing_directory;
|
||
gboolean uncertain;
|
||
guchar data[] =
|
||
"[Desktop Entry]\n"
|
||
"Type=Application\n"
|
||
"Name=appinfo-test\n"
|
||
"Exec=./appinfo-test --option\n";
|
||
|
||
#ifdef G_OS_WIN32
|
||
existing_directory = (gchar *) g_getenv ("SYSTEMROOT");
|
||
|
||
if (existing_directory)
|
||
existing_directory = g_strdup_printf ("%s" G_DIR_SEPARATOR_S, existing_directory);
|
||
#else
|
||
existing_directory = g_strdup ("/etc/");
|
||
#endif
|
||
|
||
res = g_content_type_guess (existing_directory, NULL, 0, &uncertain);
|
||
g_free (existing_directory);
|
||
expected = g_content_type_from_mime_type ("inode/directory");
|
||
g_assert_content_type_equals (expected, res);
|
||
g_assert_true (uncertain);
|
||
g_free (res);
|
||
g_free (expected);
|
||
|
||
res = g_content_type_guess ("foo.txt", NULL, 0, &uncertain);
|
||
expected = g_content_type_from_mime_type ("text/plain");
|
||
g_assert_content_type_equals (expected, res);
|
||
g_free (res);
|
||
g_free (expected);
|
||
|
||
res = g_content_type_guess ("foo.txt", data, sizeof (data) - 1, &uncertain);
|
||
expected = g_content_type_from_mime_type ("text/plain");
|
||
g_assert_content_type_equals (expected, res);
|
||
g_assert_false (uncertain);
|
||
g_free (res);
|
||
g_free (expected);
|
||
|
||
/* Sadly win32 & OSX just don't have as large and robust of a mime type database as Linux */
|
||
#ifndef G_OS_WIN32
|
||
#ifndef __APPLE__
|
||
res = g_content_type_guess ("foo", data, sizeof (data) - 1, &uncertain);
|
||
expected = g_content_type_from_mime_type ("text/plain");
|
||
g_assert_content_type_equals (expected, res);
|
||
g_assert_false (uncertain);
|
||
g_free (res);
|
||
g_free (expected);
|
||
|
||
res = g_content_type_guess ("foo.desktop", data, sizeof (data) - 1, &uncertain);
|
||
expected = g_content_type_from_mime_type ("application/x-desktop");
|
||
g_assert_content_type_equals (expected, res);
|
||
g_assert_false (uncertain);
|
||
g_free (res);
|
||
g_free (expected);
|
||
|
||
res = g_content_type_guess (NULL, data, sizeof (data) - 1, &uncertain);
|
||
expected = g_content_type_from_mime_type ("application/x-desktop");
|
||
g_assert_content_type_equals (expected, res);
|
||
g_assert_false (uncertain);
|
||
g_free (res);
|
||
g_free (expected);
|
||
|
||
/* this is potentially ambiguous: it does not match the PO template format,
|
||
* but looks like text so it can't be Powerpoint */
|
||
res = g_content_type_guess ("test.pot", (guchar *)"ABC abc", 7, &uncertain);
|
||
expected = g_content_type_from_mime_type ("text/x-gettext-translation-template");
|
||
g_assert_content_type_equals (expected, res);
|
||
g_assert_false (uncertain);
|
||
g_free (res);
|
||
g_free (expected);
|
||
|
||
res = g_content_type_guess ("test.pot", (guchar *)"msgid \"", 7, &uncertain);
|
||
expected = g_content_type_from_mime_type ("text/x-gettext-translation-template");
|
||
g_assert_content_type_equals (expected, res);
|
||
g_assert_false (uncertain);
|
||
g_free (res);
|
||
g_free (expected);
|
||
|
||
res = g_content_type_guess ("test.pot", (guchar *)"\xCF\xD0\xE0\x11", 4, &uncertain);
|
||
expected = g_content_type_from_mime_type ("application/vnd.ms-powerpoint");
|
||
g_assert_content_type_equals (expected, res);
|
||
/* we cannot reliably detect binary powerpoint files as long as there is no
|
||
* defined MIME magic, so do not check uncertain here
|
||
*/
|
||
g_free (res);
|
||
g_free (expected);
|
||
|
||
res = g_content_type_guess ("test.otf", (guchar *)"OTTO", 4, &uncertain);
|
||
expected = g_content_type_from_mime_type ("application/x-font-otf");
|
||
g_assert_content_type_equals (expected, res);
|
||
g_assert_false (uncertain);
|
||
g_free (res);
|
||
g_free (expected);
|
||
#endif /* __APPLE__ */
|
||
|
||
res = g_content_type_guess (NULL, (guchar *)"%!PS-Adobe-2.0 EPSF-1.2", 23, &uncertain);
|
||
expected = g_content_type_from_mime_type ("image/x-eps");
|
||
g_assert_content_type_equals (expected, res);
|
||
g_assert_false (uncertain);
|
||
g_free (res);
|
||
g_free (expected);
|
||
|
||
/* The data below would be detected as a valid content type, but shouldn’t be read at all. */
|
||
res = g_content_type_guess (NULL, (guchar *)"%!PS-Adobe-2.0 EPSF-1.2", 0, &uncertain);
|
||
expected = g_content_type_from_mime_type ("application/x-zerosize");
|
||
g_assert_content_type_equals (expected, res);
|
||
g_assert_false (uncertain);
|
||
g_free (res);
|
||
g_free (expected);
|
||
#endif /* G_OS_WIN32 */
|
||
}
|
||
|
||
static void
|
||
test_unknown (void)
|
||
{
|
||
gchar *unknown;
|
||
gchar *str;
|
||
|
||
unknown = g_content_type_from_mime_type ("application/octet-stream");
|
||
g_assert_true (g_content_type_is_unknown (unknown));
|
||
str = g_content_type_get_mime_type (unknown);
|
||
g_assert_cmpstr (str, ==, "application/octet-stream");
|
||
g_free (str);
|
||
g_free (unknown);
|
||
}
|
||
|
||
static void
|
||
test_subtype (void)
|
||
{
|
||
gchar *plain;
|
||
gchar *xml;
|
||
|
||
plain = g_content_type_from_mime_type ("text/plain");
|
||
xml = g_content_type_from_mime_type ("application/xml");
|
||
|
||
g_assert_true (g_content_type_is_a (xml, plain));
|
||
g_assert_true (g_content_type_is_mime_type (xml, "text/plain"));
|
||
|
||
g_free (plain);
|
||
g_free (xml);
|
||
}
|
||
|
||
static gint
|
||
find_mime (gconstpointer a, gconstpointer b)
|
||
{
|
||
if (g_content_type_equals (a, b))
|
||
return 0;
|
||
return 1;
|
||
}
|
||
|
||
static void
|
||
test_list (void)
|
||
{
|
||
GList *types;
|
||
gchar *plain;
|
||
gchar *xml;
|
||
|
||
#ifdef __APPLE__
|
||
g_test_skip ("The OSX backend does not implement g_content_types_get_registered()");
|
||
return;
|
||
#endif
|
||
|
||
plain = g_content_type_from_mime_type ("text/plain");
|
||
xml = g_content_type_from_mime_type ("application/xml");
|
||
|
||
types = g_content_types_get_registered ();
|
||
|
||
g_assert_cmpuint (g_list_length (types), >, 1);
|
||
|
||
/* just check that some types are in the list */
|
||
g_assert_nonnull (g_list_find_custom (types, plain, find_mime));
|
||
g_assert_nonnull (g_list_find_custom (types, xml, find_mime));
|
||
|
||
g_list_free_full (types, g_free);
|
||
|
||
g_free (plain);
|
||
g_free (xml);
|
||
}
|
||
|
||
static void
|
||
test_executable (void)
|
||
{
|
||
gchar *type;
|
||
|
||
#ifdef G_OS_WIN32
|
||
type = g_content_type_from_mime_type ("application/vnd.microsoft.portable-executable");
|
||
/* FIXME: the MIME is not in the default `MIME\Database\Content Type` registry.
|
||
* g_assert_true (g_content_type_can_be_executable (type));
|
||
*/
|
||
g_free (type);
|
||
#else
|
||
type = g_content_type_from_mime_type ("application/x-executable");
|
||
g_assert_true (g_content_type_can_be_executable (type));
|
||
g_free (type);
|
||
|
||
type = g_content_type_from_mime_type ("text/plain");
|
||
g_assert_true (g_content_type_can_be_executable (type));
|
||
g_free (type);
|
||
#endif
|
||
type = g_content_type_from_mime_type ("image/png");
|
||
g_assert_false (g_content_type_can_be_executable (type));
|
||
g_free (type);
|
||
}
|
||
|
||
static void
|
||
test_description (void)
|
||
{
|
||
gchar *type;
|
||
gchar *desc;
|
||
|
||
type = g_content_type_from_mime_type ("text/plain");
|
||
desc = g_content_type_get_description (type);
|
||
g_assert_nonnull (desc);
|
||
|
||
g_free (desc);
|
||
g_free (type);
|
||
}
|
||
|
||
static void
|
||
test_icon (void)
|
||
{
|
||
gchar *type;
|
||
GIcon *icon;
|
||
|
||
type = g_content_type_from_mime_type ("text/plain");
|
||
icon = g_content_type_get_icon (type);
|
||
g_assert_true (G_IS_ICON (icon));
|
||
if (G_IS_THEMED_ICON (icon))
|
||
{
|
||
const gchar *const *names;
|
||
|
||
names = g_themed_icon_get_names (G_THEMED_ICON (icon));
|
||
#ifdef __APPLE__
|
||
g_assert_true (g_strv_contains (names, "text-*"));
|
||
#elif defined(G_OS_WIN32)
|
||
g_assert_cmpuint (g_strv_length ((GStrv) names), >, 0);
|
||
#else
|
||
g_assert_true (g_strv_contains (names, "text-plain"));
|
||
g_assert_true (g_strv_contains (names, "text-x-generic"));
|
||
#endif
|
||
}
|
||
g_object_unref (icon);
|
||
g_free (type);
|
||
|
||
type = g_content_type_from_mime_type ("application/rtf");
|
||
icon = g_content_type_get_icon (type);
|
||
g_assert_true (G_IS_ICON (icon));
|
||
if (G_IS_THEMED_ICON (icon))
|
||
{
|
||
const gchar *const *names;
|
||
|
||
names = g_themed_icon_get_names (G_THEMED_ICON (icon));
|
||
#ifdef G_OS_WIN32
|
||
g_assert_true (g_strv_contains (names, "text-x-generic"));
|
||
#else
|
||
g_assert_true (g_strv_contains (names, "application-rtf"));
|
||
#ifndef __APPLE__
|
||
g_assert_true (g_strv_contains (names, "x-office-document"));
|
||
#endif
|
||
#endif
|
||
}
|
||
g_object_unref (icon);
|
||
g_free (type);
|
||
}
|
||
|
||
static void
|
||
test_symbolic_icon (void)
|
||
{
|
||
#ifndef G_OS_WIN32
|
||
gchar *type;
|
||
GIcon *icon;
|
||
|
||
type = g_content_type_from_mime_type ("text/plain");
|
||
icon = g_content_type_get_symbolic_icon (type);
|
||
g_assert_true (G_IS_ICON (icon));
|
||
if (G_IS_THEMED_ICON (icon))
|
||
{
|
||
const gchar *const *names;
|
||
|
||
names = g_themed_icon_get_names (G_THEMED_ICON (icon));
|
||
#ifdef __APPLE__
|
||
g_assert_true (g_strv_contains (names, "text-*-symbolic"));
|
||
g_assert_true (g_strv_contains (names, "text-*"));
|
||
#else
|
||
g_assert_true (g_strv_contains (names, "text-plain-symbolic"));
|
||
g_assert_true (g_strv_contains (names, "text-x-generic-symbolic"));
|
||
g_assert_true (g_strv_contains (names, "text-plain"));
|
||
g_assert_true (g_strv_contains (names, "text-x-generic"));
|
||
#endif
|
||
}
|
||
g_object_unref (icon);
|
||
g_free (type);
|
||
|
||
type = g_content_type_from_mime_type ("application/rtf");
|
||
icon = g_content_type_get_symbolic_icon (type);
|
||
g_assert_true (G_IS_ICON (icon));
|
||
if (G_IS_THEMED_ICON (icon))
|
||
{
|
||
const gchar *const *names;
|
||
|
||
names = g_themed_icon_get_names (G_THEMED_ICON (icon));
|
||
g_assert_true (g_strv_contains (names, "application-rtf-symbolic"));
|
||
g_assert_true (g_strv_contains (names, "application-rtf"));
|
||
#ifndef __APPLE__
|
||
g_assert_true (g_strv_contains (names, "x-office-document-symbolic"));
|
||
g_assert_true (g_strv_contains (names, "x-office-document"));
|
||
#endif
|
||
}
|
||
g_object_unref (icon);
|
||
g_free (type);
|
||
#endif
|
||
}
|
||
|
||
static void
|
||
test_tree (void)
|
||
{
|
||
const gchar *tests[] = {
|
||
"x-content/image-dcf",
|
||
"x-content/unix-software",
|
||
"x-content/win32-software"
|
||
};
|
||
const gchar *path;
|
||
GFile *file;
|
||
gchar **types;
|
||
gsize i;
|
||
|
||
#if defined(__APPLE__) || defined(G_OS_WIN32)
|
||
g_test_skip ("The OSX & Windows backends do not implement g_content_type_guess_for_tree()");
|
||
return;
|
||
#endif
|
||
|
||
for (i = 0; i < G_N_ELEMENTS (tests); i++)
|
||
{
|
||
path = g_test_get_filename (G_TEST_DIST, tests[i], NULL);
|
||
file = g_file_new_for_path (path);
|
||
types = g_content_type_guess_for_tree (file);
|
||
g_assert_content_type_equals (types[0], tests[i]);
|
||
g_strfreev (types);
|
||
g_object_unref (file);
|
||
}
|
||
}
|
||
|
||
static void
|
||
test_tree_invalid_encoding (void)
|
||
{
|
||
gchar *path;
|
||
gchar *name;
|
||
GFile *tmpdir;
|
||
GFile *file;
|
||
gchar **types;
|
||
GError *error = NULL;
|
||
|
||
g_test_bug ("https://gitlab.gnome.org/GNOME/glib/-/issues/3168");
|
||
|
||
#if defined(__APPLE__) || defined(G_OS_WIN32)
|
||
g_test_skip ("The OSX & Windows backends do not implement g_content_type_guess_for_tree()");
|
||
return;
|
||
#endif
|
||
|
||
path = g_dir_make_tmp ("gio-test-tree-invalid-encoding-XXXXXX", &error);
|
||
g_assert_no_error (error);
|
||
tmpdir = g_file_new_for_path (path);
|
||
g_free (path);
|
||
|
||
name = g_strdup_printf ("\260");
|
||
file = g_file_get_child (tmpdir, name);
|
||
g_free (name);
|
||
|
||
g_file_replace_contents (file, "", 0, NULL, FALSE, 0, NULL, NULL, &error);
|
||
if (g_error_matches (error, G_IO_ERROR, G_IO_ERROR_INVALID_ARGUMENT))
|
||
{
|
||
g_test_skip ("Unable to create testing file with non-ASCII characters.");
|
||
|
||
g_object_unref (tmpdir);
|
||
g_object_unref (file);
|
||
g_clear_error (&error);
|
||
|
||
return;
|
||
}
|
||
g_assert_no_error (error);
|
||
|
||
types = g_content_type_guess_for_tree (tmpdir);
|
||
g_strfreev (types);
|
||
|
||
g_file_delete (file, NULL, &error);
|
||
g_assert_no_error (error);
|
||
g_object_unref (file);
|
||
|
||
g_file_delete (tmpdir, NULL, &error);
|
||
g_assert_no_error (error);
|
||
g_object_unref (tmpdir);
|
||
}
|
||
|
||
static void
|
||
test_type_is_a_special_case (void)
|
||
{
|
||
gboolean res;
|
||
|
||
g_test_bug ("https://bugzilla.gnome.org/show_bug.cgi?id=782311");
|
||
|
||
/* Everything but the inode type is application/octet-stream */
|
||
res = g_content_type_is_a ("inode/directory", "application/octet-stream");
|
||
g_assert_false (res);
|
||
#if !defined(__APPLE__) && !defined(G_OS_WIN32)
|
||
res = g_content_type_is_a ("anything", "application/octet-stream");
|
||
g_assert_true (res);
|
||
#endif
|
||
}
|
||
|
||
static void
|
||
test_guess_svg_from_data (void)
|
||
{
|
||
const gchar svgfilecontent[] = "<svg xmlns=\"http://www.w3.org/2000/svg\"\
|
||
xmlns:xlink=\"http://www.w3.org/1999/xlink\">\n\
|
||
<rect x=\"10\" y=\"10\" height=\"100\" width=\"100\"\n\
|
||
style=\"stroke:#ff0000; fill: #0000ff\"/>\n\
|
||
</svg>\n";
|
||
|
||
gboolean uncertain = TRUE;
|
||
gchar *res = g_content_type_guess (NULL, (guchar *)svgfilecontent,
|
||
sizeof (svgfilecontent) - 1, &uncertain);
|
||
#ifdef __APPLE__
|
||
g_assert_cmpstr (res, ==, "public.svg-image");
|
||
#elif defined(G_OS_WIN32)
|
||
g_test_skip ("svg type detection from content is not implemented on WIN32");
|
||
#else
|
||
g_assert_cmpstr (res, ==, "image/svg+xml");
|
||
#endif
|
||
g_assert_false (uncertain);
|
||
g_free (res);
|
||
}
|
||
|
||
static void
|
||
test_mime_from_content (void)
|
||
{
|
||
#ifdef __APPLE__
|
||
gchar *mime_type;
|
||
mime_type = g_content_type_get_mime_type ("com.microsoft.bmp");
|
||
g_assert_cmpstr (mime_type, ==, "image/bmp");
|
||
g_free (mime_type);
|
||
mime_type = g_content_type_get_mime_type ("com.compuserve.gif");
|
||
g_assert_cmpstr (mime_type, ==, "image/gif");
|
||
g_free (mime_type);
|
||
mime_type = g_content_type_get_mime_type ("public.png");
|
||
g_assert_cmpstr (mime_type, ==, "image/png");
|
||
g_free (mime_type);
|
||
mime_type = g_content_type_get_mime_type ("public.text");
|
||
g_assert_cmpstr (mime_type, ==, "text/*");
|
||
g_free (mime_type);
|
||
mime_type = g_content_type_get_mime_type ("public.svg-image");
|
||
g_assert_cmpstr (mime_type, ==, "image/svg+xml");
|
||
g_free (mime_type);
|
||
#elif defined(G_OS_WIN32)
|
||
g_test_skip ("mime from content type test not implemented on WIN32");
|
||
#else
|
||
g_test_skip ("mime from content type test not implemented on UNIX");
|
||
#endif
|
||
}
|
||
|
||
int
|
||
main (int argc, char *argv[])
|
||
{
|
||
g_test_init (&argc, &argv, NULL);
|
||
|
||
g_test_add_func ("/contenttype/guess", test_guess);
|
||
g_test_add_func ("/contenttype/guess_svg_from_data", test_guess_svg_from_data);
|
||
g_test_add_func ("/contenttype/mime_from_content", test_mime_from_content);
|
||
g_test_add_func ("/contenttype/unknown", test_unknown);
|
||
g_test_add_func ("/contenttype/subtype", test_subtype);
|
||
g_test_add_func ("/contenttype/list", test_list);
|
||
g_test_add_func ("/contenttype/executable", test_executable);
|
||
g_test_add_func ("/contenttype/description", test_description);
|
||
g_test_add_func ("/contenttype/icon", test_icon);
|
||
g_test_add_func ("/contenttype/symbolic-icon", test_symbolic_icon);
|
||
g_test_add_func ("/contenttype/tree", test_tree);
|
||
g_test_add_func ("/contenttype/tree_invalid_encoding",
|
||
test_tree_invalid_encoding);
|
||
g_test_add_func ("/contenttype/test_type_is_a_special_case",
|
||
test_type_is_a_special_case);
|
||
|
||
return g_test_run ();
|
||
}
|