mirror of
https://gitlab.gnome.org/GNOME/glib.git
synced 2024-11-14 05:16:18 +01:00
2ec660b2ea
The C standard does not specify whether the underlying type of an enum
is signed or unsigned, and until C23 there was no way to control this
explicitly. GCC appears to make enums unsigned unless there is a
negative value among cases of the enum, in which case it becomes signed.
MSCV appears to make enums signed by default.
A bitfield of an enum type (which is not specificied in the C standard
either) behaves as if it was an instance of a numeric type with a
reduced value range. Specifically, a 'signed int val : 2;' bitfield will
have the possible values of -2, -1, 0, and 1, with the usual wraparound
behavior for the values that don't fit (although this too is
implementation-defined).
This causes the following issue, if we have:
typedef enum
{
G_ZERO,
G_ONE,
G_TWO
} GFoo;
struct _GBar
{
GFoo foo : 2;
};
and then assign bar.foo = G_TWO and read it back, it will have the
expected value of 2 (aka G_TWO) on GCC, but a value of -2 (not matching
any of the enum variants) on MSVC.
There does not seem to be any way to influence signedness of an enum
prior to C23, nor is there a 'unsigned GFoo foo : 2;' syntax. The only
remaining options seems to be never using enums in bitfields, which is
what this change implements.
This corresponds to https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/6467
in GTK.
Signed-off-by: Sergey Bugaev <bugaevc@gmail.com>
94 lines
4.3 KiB
C
94 lines
4.3 KiB
C
/* GIO - GLib Input, Output and Streaming Library
|
|
*
|
|
* Copyright (C) 2006-2007 Red Hat, Inc.
|
|
*
|
|
* SPDX-License-Identifier: LGPL-2.1-or-later
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General
|
|
* Public License along with this library; if not, see <http://www.gnu.org/licenses/>.
|
|
*
|
|
* Author: Alexander Larsson <alexl@redhat.com>
|
|
*/
|
|
|
|
#ifndef __G_FILE_ATTRIBUTE_PRIV_H__
|
|
#define __G_FILE_ATTRIBUTE_PRIV_H__
|
|
|
|
#include "gfileattribute.h"
|
|
#include "gfileinfo.h"
|
|
|
|
#define G_FILE_ATTRIBUTE_VALUE_INIT {0}
|
|
|
|
typedef struct {
|
|
guint type : 8; /* GFileAttributeType */
|
|
guint status : 8; /* GFileAttributeStatus */
|
|
union {
|
|
gboolean boolean;
|
|
gint32 int32;
|
|
guint32 uint32;
|
|
gint64 int64;
|
|
guint64 uint64;
|
|
char *string;
|
|
GObject *obj;
|
|
char **stringv;
|
|
} u;
|
|
} GFileAttributeValue;
|
|
|
|
GFileAttributeValue *_g_file_attribute_value_new (void);
|
|
void _g_file_attribute_value_free (GFileAttributeValue *attr);
|
|
void _g_file_attribute_value_clear (GFileAttributeValue *attr);
|
|
void _g_file_attribute_value_set (GFileAttributeValue *attr,
|
|
const GFileAttributeValue *new_value);
|
|
GFileAttributeValue *_g_file_attribute_value_dup (const GFileAttributeValue *other);
|
|
gpointer _g_file_attribute_value_peek_as_pointer (GFileAttributeValue *attr);
|
|
|
|
char * _g_file_attribute_value_as_string (const GFileAttributeValue *attr);
|
|
|
|
const char * _g_file_attribute_value_get_string (const GFileAttributeValue *attr);
|
|
const char * _g_file_attribute_value_get_byte_string (const GFileAttributeValue *attr);
|
|
gboolean _g_file_attribute_value_get_boolean (const GFileAttributeValue *attr);
|
|
guint32 _g_file_attribute_value_get_uint32 (const GFileAttributeValue *attr);
|
|
gint32 _g_file_attribute_value_get_int32 (const GFileAttributeValue *attr);
|
|
guint64 _g_file_attribute_value_get_uint64 (const GFileAttributeValue *attr);
|
|
gint64 _g_file_attribute_value_get_int64 (const GFileAttributeValue *attr);
|
|
GObject * _g_file_attribute_value_get_object (const GFileAttributeValue *attr);
|
|
char ** _g_file_attribute_value_get_stringv (const GFileAttributeValue *attr);
|
|
|
|
void _g_file_attribute_value_set_from_pointer(GFileAttributeValue *attr,
|
|
GFileAttributeType type,
|
|
gpointer value_p,
|
|
gboolean dup);
|
|
void _g_file_attribute_value_set_string (GFileAttributeValue *attr,
|
|
const char *string);
|
|
void _g_file_attribute_value_set_byte_string (GFileAttributeValue *attr,
|
|
const char *string);
|
|
void _g_file_attribute_value_set_boolean (GFileAttributeValue *attr,
|
|
gboolean value);
|
|
void _g_file_attribute_value_set_uint32 (GFileAttributeValue *attr,
|
|
guint32 value);
|
|
void _g_file_attribute_value_set_int32 (GFileAttributeValue *attr,
|
|
gint32 value);
|
|
void _g_file_attribute_value_set_uint64 (GFileAttributeValue *attr,
|
|
guint64 value);
|
|
void _g_file_attribute_value_set_int64 (GFileAttributeValue *attr,
|
|
gint64 value);
|
|
void _g_file_attribute_value_set_object (GFileAttributeValue *attr,
|
|
GObject *obj);
|
|
void _g_file_attribute_value_set_stringv (GFileAttributeValue *attr,
|
|
char **value);
|
|
|
|
|
|
GFileAttributeValue *_g_file_info_get_attribute_value (GFileInfo *info,
|
|
const char *attribute);
|
|
|
|
#endif /* __G_FILE_ATTRIBUTE_PRIV_H__ */
|