mirror of
https://gitlab.gnome.org/GNOME/glib.git
synced 2024-09-20 09:16:15 +02:00
3f51963b2d
Using the same approach as we have for code style checks (the `style-check-diff` CI job), check the diff for any banned keywords like ‘TODO’, and also check the commit messages. The keyword ‘TODO’ is often used by developers to indicate a part of a commit which needs further work, and hence which shouldn’t yet be merged. Signed-off-by: Philip Withnall <withnall@endlessm.com> Fixes: #1551
17 lines
908 B
Bash
Executable File
17 lines
908 B
Bash
Executable File
#!/bin/bash
|
||
|
||
set +e
|
||
|
||
# We need to add a new remote for the upstream master, since this script could
|
||
# be running in a personal fork of the repository which has out of date branches.
|
||
git remote add upstream https://gitlab.gnome.org/GNOME/glib.git
|
||
git fetch upstream
|
||
|
||
# Work out the newest common ancestor between the detached HEAD that this CI job
|
||
# has checked out, and the upstream target branch (which will typically be
|
||
# `upstream/master` or `upstream/glib-2-62`).
|
||
# `${CI_MERGE_REQUEST_TARGET_BRANCH_NAME}` is only defined if we’re running in
|
||
# a merge request pipeline; fall back to `${CI_DEFAULT_BRANCH}` otherwise.
|
||
newest_common_ancestor_sha=$(diff --old-line-format='' --new-line-format='' <(git rev-list --first-parent upstream/${CI_MERGE_REQUEST_TARGET_BRANCH_NAME:-${CI_DEFAULT_BRANCH}}) <(git rev-list --first-parent HEAD) | head -1)
|
||
./.gitlab-ci/check-todos.py "${newest_common_ancestor_sha}"
|