Simon McVittie
7f3bfcb891
cancellable: Don't assert if finalization races with cancellation
...
Commit 281e3010 narrowed the race between GCancellable::cancelled and
GCancellableSource's finalize(), but did not prevent it: there was
nothing to stop cancellation from occurring after the refcount drops
to 0, but before g_source_unref_internal() bumps it back up to 1 to
run finalize().
GCancellable cannot be expected to detect that situation, because the
only way it has to detect last-unref is finalize(), but in that
situation finalize() hasn't happened yet.
Instead of detecting last-unref, relax the precondition a little
to make it detect finalization: priv is only poisoned (set to NULL)
after the finalize() function has been called, so we can assume that
GCancellable has already seen finalize() by then.
Signed-off-by: Simon McVittie <smcv@collabora.com>
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=791754
Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=884654
2018-01-05 20:42:06 +00:00
..
2017-05-24 11:58:19 +02:00
2017-01-04 19:12:57 +01:00
2017-11-24 12:41:53 +05:30
2017-12-19 14:56:11 -05:00
2017-10-06 12:49:12 +01:00
2017-12-21 16:12:55 +01:00
2017-07-10 11:22:40 +01:00
2017-07-10 11:22:40 +01:00
2017-12-21 16:12:55 +01:00
2017-05-24 11:58:19 +02:00
2017-11-16 11:12:32 +00:00
2017-05-24 11:58:19 +02:00
2017-05-24 11:58:19 +02:00
2017-05-24 11:58:19 +02:00
2017-05-24 11:58:19 +02:00
2017-05-24 11:58:19 +02:00
2017-05-24 11:58:19 +02:00
2017-05-24 11:58:19 +02:00
2017-11-16 10:36:13 +00:00
2017-09-11 20:44:39 +01:00
2017-05-24 11:58:19 +02:00
2017-05-24 11:58:19 +02:00
2017-05-24 11:58:19 +02:00
2017-09-11 21:01:15 +01:00
2017-05-24 11:58:19 +02:00
2013-11-20 09:16:16 -05:00
2017-12-07 10:27:59 +00:00
2017-05-24 11:58:19 +02:00
2017-05-24 11:58:19 +02:00
2017-05-24 11:58:19 +02:00
2017-05-24 11:58:19 +02:00
2017-05-24 11:58:19 +02:00
2017-05-24 11:58:19 +02:00
2015-11-12 15:01:54 +08:00
2017-11-12 16:36:16 +01:00
2017-09-11 20:47:11 +01:00
2017-11-16 11:12:32 +00:00
2017-05-24 11:58:19 +02:00
2017-05-24 11:58:19 +02:00
2017-10-11 12:13:20 +01:00
2017-10-11 12:13:20 +01:00
2017-11-28 14:21:06 +00:00
2017-09-11 19:29:34 +01:00
2017-05-24 11:58:19 +02:00
2017-05-24 11:58:19 +02:00
2016-09-21 18:30:52 +02:00
2017-10-26 18:51:51 +02:00
2017-05-24 11:58:19 +02:00
2018-01-05 19:36:07 +00:00
2017-05-24 11:58:19 +02:00
2017-11-07 08:25:28 -08:00
2017-11-07 08:25:28 -08:00
2017-05-24 11:58:19 +02:00
2017-05-24 11:58:19 +02:00
2017-05-24 11:58:19 +02:00
2017-05-24 11:58:19 +02:00
2017-05-24 11:58:19 +02:00
2017-05-24 11:58:19 +02:00
2017-11-12 16:36:16 +01:00
2017-05-24 11:58:19 +02:00
2017-05-24 11:58:19 +02:00
2017-05-24 11:58:19 +02:00
2017-05-24 11:58:19 +02:00
2017-05-24 11:58:19 +02:00
2017-10-06 12:49:12 +01:00
2017-05-24 11:58:19 +02:00
2017-09-08 15:40:15 +01:00
2017-10-05 14:49:49 +01:00
2017-11-12 16:36:16 +01:00
2017-05-24 11:58:19 +02:00
2016-05-23 10:52:10 -04:00
2016-09-23 22:46:30 -07:00
2017-05-24 11:58:19 +02:00
2017-05-24 11:58:19 +02:00
2017-05-24 11:58:19 +02:00
2017-05-24 11:58:19 +02:00
2017-05-24 11:58:19 +02:00
2017-11-01 12:46:38 +00:00
2017-11-01 12:46:38 +00:00
2017-11-07 14:51:12 +00:00
2017-05-24 11:58:19 +02:00
2017-05-24 11:58:19 +02:00
2018-01-04 22:19:30 +01:00
2016-11-23 10:50:39 +00:00
2018-01-04 22:21:40 +01:00
2017-09-15 12:50:50 +08:00
2013-01-13 13:11:57 -05:00
2017-11-16 11:12:32 +00:00
2017-05-24 11:58:19 +02:00
2017-12-22 15:03:07 +00:00
2017-05-24 11:58:19 +02:00
2018-01-05 20:42:06 +00:00
2017-11-29 13:20:40 -06:00
2017-05-24 11:58:19 +02:00
2017-05-24 11:58:19 +02:00
2017-05-24 11:58:19 +02:00
2017-05-24 11:58:19 +02:00
2017-10-03 09:36:08 +01:00
2017-05-24 11:58:19 +02:00
2017-12-02 13:15:30 +00:00
2017-11-10 10:27:26 +00:00
2008-04-08 02:59:05 +00:00
2017-11-28 14:16:25 +00:00
2017-05-24 11:58:19 +02:00
2017-11-07 14:51:12 +00:00
2017-05-24 11:58:19 +02:00
2017-05-24 11:58:19 +02:00
2017-05-24 11:58:19 +02:00
2017-11-07 14:51:12 +00:00
2017-05-24 11:58:19 +02:00
2017-05-24 11:58:19 +02:00
2017-05-24 11:58:19 +02:00
2017-10-05 15:02:39 +01:00
2017-05-24 11:58:19 +02:00
2017-05-24 11:58:19 +02:00
2017-05-24 11:58:19 +02:00
2017-05-24 11:58:19 +02:00
2017-05-24 11:58:19 +02:00
2017-05-24 11:58:19 +02:00
2017-11-16 11:12:32 +00:00
2017-05-24 11:58:19 +02:00
2017-05-24 11:58:19 +02:00
2017-05-24 11:58:19 +02:00
2017-10-05 15:07:09 +01:00
2017-10-06 12:49:12 +01:00
2017-10-26 12:27:17 +01:00
2017-05-24 11:58:19 +02:00
2017-07-05 17:53:07 +02:00
2017-11-16 11:12:32 +00:00
2017-05-24 11:58:19 +02:00
2017-10-26 18:51:51 +02:00
2017-05-24 11:58:19 +02:00
2017-11-12 16:36:16 +01:00
2017-05-24 11:58:19 +02:00
2017-11-28 14:11:29 +00:00
2017-05-24 11:58:19 +02:00
2017-05-24 11:58:19 +02:00
2017-07-12 23:36:18 +02:00
2017-11-07 14:51:12 +00:00
2017-09-11 21:07:08 +01:00
2017-11-12 16:36:16 +01:00
2017-09-12 12:12:27 +01:00
2017-11-01 12:46:38 +00:00
2017-11-13 10:37:11 +00:00
2017-05-24 11:58:19 +02:00
2017-05-24 11:58:19 +02:00
2017-05-24 11:58:19 +02:00
2017-10-26 12:27:17 +01:00
2017-05-24 11:58:19 +02:00
2017-12-06 10:07:10 +00:00
2017-11-28 15:36:06 +01:00
2017-12-18 18:55:46 +00:00
2017-12-13 13:15:37 +00:00
2017-11-12 16:36:16 +01:00
2017-05-24 11:58:19 +02:00
2017-05-24 11:58:19 +02:00
2017-05-24 11:58:19 +02:00
2017-05-24 11:58:19 +02:00
2017-05-24 11:58:19 +02:00
2017-05-24 11:58:19 +02:00
2017-05-24 11:58:19 +02:00
2017-05-24 11:58:19 +02:00
2017-05-24 11:58:19 +02:00
2017-05-24 11:58:19 +02:00
2014-02-20 18:27:24 -05:00
2017-05-24 11:58:19 +02:00
2017-05-24 11:58:19 +02:00
2017-05-24 11:58:19 +02:00
2017-05-24 11:58:19 +02:00
2017-05-24 11:58:19 +02:00
2017-10-02 15:31:20 +01:00
2017-05-24 11:58:19 +02:00
2017-07-05 17:53:07 +02:00
2017-07-05 17:53:07 +02:00
2017-11-07 14:51:12 +00:00
2017-05-24 11:58:19 +02:00
2017-05-24 11:58:19 +02:00
2014-06-28 12:49:38 -04:00
2017-05-24 11:58:19 +02:00
2017-07-05 17:53:07 +02:00
2017-07-05 17:53:07 +02:00
2017-05-24 11:58:19 +02:00
2017-05-24 11:58:19 +02:00
2017-10-25 10:33:48 +01:00
2017-11-06 10:31:52 +00:00
2017-11-02 13:39:19 +00:00
2017-02-06 14:40:38 +01:00
2017-02-06 14:40:38 +01:00
2017-05-24 11:58:19 +02:00
2017-05-24 11:58:19 +02:00
2017-05-24 11:58:19 +02:00
2017-11-08 12:36:26 +00:00
2017-05-24 11:58:19 +02:00
2017-05-24 11:58:19 +02:00
2017-12-03 20:01:39 +00:00
2017-05-24 11:58:19 +02:00
2017-05-24 11:58:19 +02:00
2017-05-24 11:58:19 +02:00
2017-05-24 11:58:19 +02:00
2017-05-24 11:58:19 +02:00
2017-05-24 11:58:19 +02:00
2017-05-24 11:58:19 +02:00
2017-09-11 19:24:06 +01:00
2017-05-24 11:58:19 +02:00
2017-05-24 11:58:19 +02:00
2017-07-13 01:49:38 +00:00
2017-07-12 22:36:30 +02:00
2016-05-23 10:52:10 -04:00
2017-11-03 20:11:56 +00:00
2018-01-05 15:29:00 +01:00
2014-02-20 18:27:24 -05:00
2014-12-12 11:01:37 -05:00
2016-08-13 10:31:26 +02:00