mirror of
https://gitlab.gnome.org/GNOME/glib.git
synced 2024-12-25 15:06:14 +01:00
09c019a4f0
Previously, kqueue file monitor only add event sources for directories regardless of the type of the file being monitored. Doing so may be possible on inotify, but it is not sufficient on kqueue. Watching a directory on kqueue doesn't report changes made to files under it, and we must watch files themselves to get notified. This problem is fixed by adding a second watch for non-directory file monitors, and the result is that we are now able to receive 'CHANGED' and 'ATTRIBUTE_CHANGED' events for non-directory files. Since having two watches on one file monitor requires many code changes to work properly, this commit also changes the following things: - NOTE_ALL macro is now replaced by note_all inline function. Since the kqueue backend is shared by all BSD operating systems, there are a few difference between these systems. It is easier to do '#ifdef' check in a function than in a macro. - Both g_kqueue_file_monitor_callback and g_kqueue_file_monitor_cancel now holds a lock before accessing kqueue_sub structs. This fixes a crash when these two functions are called from different threads, causing g_kqueue_file_monitor_callback to access freed memory. - 'mask' variable in g_kqueue_file_monitor_callback is now removed. The usage of 'mask' was wrong because of the 'mask > 0' check. 'CHANGED' event has value 0 so the 'mask > 0' check made it impossible to emit 'CHANGED' events. - kqueue-missing scans can now be triggered from the kqueue event callback instead of always waiting for 4 seconds. - Don't remove a file from kqueue on unlink unless its hard link count has dropped to zero. - Don't use 'else if' in the check of 'fflags'. It is possible for a kevent to have multiple flags set. - Don't use g_file_monitor_emit_event directly. Always use g_file_monitor_source_handle_event to report events. Events submitted to g_file_monitor_emit_event are delivered immediately, but events sent to g_file_monitor_source_handle_event are scheduled by GLocalFileMonitor. If we mix the two, the order of events will be wrong and tests will fail. - Report 'CHANGES_DONE_HINT' immediately after 'CREATED' if the file created is not a regular file. This is copied from ih_event_callback.
61 lines
2.3 KiB
C
61 lines
2.3 KiB
C
/*******************************************************************************
|
|
Copyright (c) 2011, 2012 Dmitry Matveev <me@dmitrymatveev.co.uk>
|
|
|
|
Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
of this software and associated documentation files (the "Software"), to deal
|
|
in the Software without restriction, including without limitation the rights
|
|
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
copies of the Software, and to permit persons to whom the Software is
|
|
furnished to do so, subject to the following conditions:
|
|
|
|
The above copyright notice and this permission notice shall be included in
|
|
all copies or substantial portions of the Software.
|
|
|
|
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
THE SOFTWARE.
|
|
*******************************************************************************/
|
|
|
|
#ifndef __KQUEUE_HELPER_H
|
|
#define __KQUEUE_HELPER_H
|
|
|
|
#include <gio/glocalfilemonitor.h>
|
|
#include <gio/gfilemonitor.h>
|
|
|
|
#include "dep-list.h"
|
|
|
|
typedef struct _GKqueueFileMonitor GKqueueFileMonitor;
|
|
|
|
/**
|
|
* kqueue_sub:
|
|
* @mon: a pointer to the GKqueueFileMonitor which holds this subscription
|
|
* @filename: a name of the file to monitor
|
|
* @fd: the associated file descriptor (used by kqueue)
|
|
*
|
|
* Represents a subscription on a file or directory. To check whether a
|
|
* subscription is active, check the fd field. If fd is not -1, it is an
|
|
* active subscription which can emit events from kqueue.
|
|
*/
|
|
typedef struct
|
|
{
|
|
GKqueueFileMonitor *mon;
|
|
GFileMonitorSource *source;
|
|
gchar* filename;
|
|
gchar* basename;
|
|
int fd;
|
|
dep_list* deps;
|
|
int is_dir;
|
|
} kqueue_sub;
|
|
|
|
gboolean _kqsub_start_watching (kqueue_sub *sub);
|
|
void _kh_dir_diff (kqueue_sub *sub, gboolean handle_deleted);
|
|
void _km_add_missing (kqueue_sub *sub);
|
|
gboolean _km_scan_missing (kqueue_sub *check_this_sub_only);
|
|
void _km_remove (kqueue_sub *sub);
|
|
|
|
#endif /* __KQUEUE_HELPER_H */
|