mirror of
https://gitlab.gnome.org/GNOME/glib.git
synced 2024-11-11 03:46:17 +01:00
9f070db4c5
1) When parsing the executable name out of the command line, see if the executable is rundll32.exe. If that is the case, use the DLL name from its first argument as the "executable" (this is used only for matching, and Windows Registry matches these programs by their DLLs, so this is correct; for running the application GLib would still use the command line, with rundll32). 2) If an app runs with rundll32, ensure that rundll32 arguments can be safely quoted. Otherwise GLib will break them with its protective quotation.
471 lines
13 KiB
C
471 lines
13 KiB
C
/* GLib testing framework examples and tests
|
|
* Copyright (C) 2019 Руслан Ижбулатов <lrn1986@gmail.com>
|
|
*
|
|
* This work is provided "as is"; redistribution and modification
|
|
* in whole or in part, in any medium, physical or electronic is
|
|
* permitted without restriction.
|
|
*
|
|
* This work is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
|
|
*
|
|
* In no event shall the authors or contributors be liable for any
|
|
* direct, indirect, incidental, special, exemplary, or consequential
|
|
* damages (including, but not limited to, procurement of substitute
|
|
* goods or services; loss of use, data, or profits; or business
|
|
* interruption) however caused and on any theory of liability, whether
|
|
* in contract, strict liability, or tort (including negligence or
|
|
* otherwise) arising in any way out of the use of this software, even
|
|
* if advised of the possibility of such damage.
|
|
*/
|
|
|
|
#include <glib/glib.h>
|
|
#include <gio/gio.h>
|
|
#include <malloc.h>
|
|
|
|
#include "../giowin32-private.c"
|
|
|
|
static int
|
|
g_utf16_cmp0 (const gunichar2 *str1,
|
|
const gunichar2 *str2)
|
|
{
|
|
if (!str1)
|
|
return -(str1 != str2);
|
|
if (!str2)
|
|
return str1 != str2;
|
|
|
|
while (TRUE)
|
|
{
|
|
if (str1[0] > str2[0])
|
|
return 1;
|
|
else if (str1[0] < str2[0])
|
|
return -1;
|
|
else if (str1[0] == 0 && str2[0] == 0)
|
|
return 0;
|
|
|
|
str1++;
|
|
str2++;
|
|
}
|
|
}
|
|
|
|
#define g_assert_cmputf16(s1, cmp, s2, s1u8, s2u8) \
|
|
G_STMT_START { \
|
|
const gunichar2 *__s1 = (s1), *__s2 = (s2); \
|
|
if (g_utf16_cmp0 (__s1, __s2) cmp 0) ; else \
|
|
g_assertion_message_cmpstr (G_LOG_DOMAIN, __FILE__, __LINE__, G_STRFUNC, \
|
|
#s1u8 " " #cmp " " #s2u8, s1u8, #cmp, s2u8); \
|
|
} G_STMT_END
|
|
|
|
static void
|
|
test_utf16_strfuncs (void)
|
|
{
|
|
gsize i;
|
|
|
|
struct {
|
|
gsize len;
|
|
const gunichar2 utf16[10];
|
|
const gchar *utf8;
|
|
const gchar *utf8_folded;
|
|
} string_cases[] = {
|
|
{
|
|
0,
|
|
{ 0x0000 },
|
|
"",
|
|
"",
|
|
},
|
|
{
|
|
1,
|
|
{ 0x0020, 0x0000 },
|
|
" ",
|
|
" ",
|
|
},
|
|
{
|
|
2,
|
|
{ 0x0020, 0xd800, 0x0000 },
|
|
NULL,
|
|
NULL,
|
|
},
|
|
};
|
|
|
|
for (i = 0; i < G_N_ELEMENTS (string_cases); i++)
|
|
{
|
|
gsize len;
|
|
gunichar2 *str;
|
|
gboolean success;
|
|
gchar *utf8;
|
|
gchar *utf8_folded;
|
|
|
|
len = g_utf16_len (string_cases[i].utf16);
|
|
g_assert_cmpuint (len, ==, string_cases[i].len);
|
|
|
|
str = (gunichar2 *) g_utf16_find_basename (string_cases[i].utf16, -1);
|
|
/* This only works because all testcases lack separators */
|
|
g_assert_true (string_cases[i].utf16 == str);
|
|
|
|
str = g_wcsdup (string_cases[i].utf16, string_cases[i].len);
|
|
g_assert_cmpmem (string_cases[i].utf16, len, str, len);
|
|
g_free (str);
|
|
|
|
str = g_wcsdup (string_cases[i].utf16, -1);
|
|
g_assert_cmpmem (string_cases[i].utf16, len, str, len);
|
|
g_free (str);
|
|
|
|
success = g_utf16_to_utf8_and_fold (string_cases[i].utf16, -1, NULL, NULL);
|
|
|
|
if (string_cases[i].utf8 == NULL)
|
|
g_assert_false (success);
|
|
else
|
|
g_assert_true (success);
|
|
|
|
utf8 = NULL;
|
|
success = g_utf16_to_utf8_and_fold (string_cases[i].utf16, -1, &utf8, NULL);
|
|
|
|
if (string_cases[i].utf8 != NULL)
|
|
{
|
|
g_assert_true (success);
|
|
g_assert_cmpstr (string_cases[i].utf8, ==, utf8);
|
|
/* This only works because all testcases lack separators */
|
|
g_assert_true (utf8 == g_utf8_find_basename (utf8, len));
|
|
}
|
|
|
|
g_free (utf8);
|
|
|
|
utf8 = NULL;
|
|
utf8_folded = NULL;
|
|
success = g_utf16_to_utf8_and_fold (string_cases[i].utf16, -1, &utf8, &utf8_folded);
|
|
|
|
if (string_cases[i].utf8 != NULL)
|
|
{
|
|
g_assert_true (success);
|
|
g_assert_cmpstr (string_cases[i].utf8_folded, ==, utf8_folded);
|
|
}
|
|
|
|
g_free (utf8);
|
|
g_free (utf8_folded);
|
|
}
|
|
}
|
|
|
|
struct {
|
|
const char *orig;
|
|
const char *executable;
|
|
const char *executable_basename;
|
|
gboolean is_rundll32;
|
|
const char *fixed;
|
|
} rundll32_commandlines[] = {
|
|
{
|
|
"%SystemRoot%\\System32\\rundll32.exe \"%ProgramFiles%\\Windows Photo Viewer\\PhotoViewer.dll\", ImageView_Fullscreen %1",
|
|
"%SystemRoot%\\System32\\rundll32.exe",
|
|
"rundll32.exe",
|
|
TRUE,
|
|
"%SystemRoot%\\System32\\rundll32.exe \"%ProgramFiles%\\Windows Photo Viewer\\PhotoViewer.dll\" ImageView_Fullscreen %1",
|
|
},
|
|
{
|
|
"%SystemRoot%/System32/rundll32.exe \"%ProgramFiles%/Windows Photo Viewer/PhotoViewer.dll\", ImageView_Fullscreen %1",
|
|
"%SystemRoot%/System32/rundll32.exe",
|
|
"rundll32.exe",
|
|
TRUE,
|
|
"%SystemRoot%/System32/rundll32.exe \"%ProgramFiles%/Windows Photo Viewer/PhotoViewer.dll\" ImageView_Fullscreen %1",
|
|
},
|
|
{
|
|
"%SystemRoot%\\System32/rundll32.exe \"%ProgramFiles%\\Windows Photo Viewer\\PhotoViewer.dll\", ImageView_Fullscreen %1",
|
|
"%SystemRoot%\\System32/rundll32.exe",
|
|
"rundll32.exe",
|
|
TRUE,
|
|
"%SystemRoot%\\System32/rundll32.exe \"%ProgramFiles%\\Windows Photo Viewer\\PhotoViewer.dll\" ImageView_Fullscreen %1",
|
|
},
|
|
{
|
|
"\"some path with spaces\\rundll32.exe\" \"%ProgramFiles%\\Windows Photo Viewer\\PhotoViewer.dll\", ImageView_Fullscreen %1",
|
|
"some path with spaces\\rundll32.exe",
|
|
"rundll32.exe",
|
|
TRUE,
|
|
"\"some path with spaces\\rundll32.exe\" \"%ProgramFiles%\\Windows Photo Viewer\\PhotoViewer.dll\" ImageView_Fullscreen %1",
|
|
},
|
|
{
|
|
" \"some path with spaces\\rundll32.exe\"\"%ProgramFiles%\\Windows Photo Viewer\\PhotoViewer.dll\",ImageView_Fullscreen %1",
|
|
"some path with spaces\\rundll32.exe",
|
|
"rundll32.exe",
|
|
TRUE,
|
|
" \"some path with spaces\\rundll32.exe\"\"%ProgramFiles%\\Windows Photo Viewer\\PhotoViewer.dll\" ImageView_Fullscreen %1",
|
|
},
|
|
{
|
|
"rundll32.exe foo.bar,baz",
|
|
"rundll32.exe",
|
|
"rundll32.exe",
|
|
TRUE,
|
|
"rundll32.exe foo.bar baz",
|
|
},
|
|
{
|
|
" rundll32.exe foo.bar,baz",
|
|
"rundll32.exe",
|
|
"rundll32.exe",
|
|
TRUE,
|
|
" rundll32.exe foo.bar baz",
|
|
},
|
|
{
|
|
"rundll32.exe",
|
|
"rundll32.exe",
|
|
"rundll32.exe",
|
|
FALSE,
|
|
NULL,
|
|
},
|
|
{
|
|
"rundll32.exe ,foobar",
|
|
"rundll32.exe",
|
|
"rundll32.exe",
|
|
FALSE,
|
|
NULL,
|
|
},
|
|
{
|
|
"rundll32.exe ,foobar",
|
|
"rundll32.exe",
|
|
"rundll32.exe",
|
|
FALSE,
|
|
NULL,
|
|
},
|
|
{
|
|
"rundll32.exe foo.dll",
|
|
"rundll32.exe",
|
|
"rundll32.exe",
|
|
FALSE,
|
|
NULL,
|
|
},
|
|
{
|
|
"rundll32.exe \"foo bar\",baz",
|
|
"rundll32.exe",
|
|
"rundll32.exe",
|
|
TRUE,
|
|
"rundll32.exe \"foo bar\" baz",
|
|
},
|
|
{
|
|
"\"rundll32.exe\" \"foo bar\",baz",
|
|
"rundll32.exe",
|
|
"rundll32.exe",
|
|
TRUE,
|
|
"\"rundll32.exe\" \"foo bar\" baz",
|
|
},
|
|
{
|
|
"\"rundll32.exe\" \"foo bar\",, , ,,, , ,,baz",
|
|
"rundll32.exe",
|
|
"rundll32.exe",
|
|
TRUE,
|
|
"\"rundll32.exe\" \"foo bar\" , , ,,, , ,,baz",
|
|
},
|
|
{
|
|
"\"rundll32.exe\" foo.bar,,,,,,,,,baz",
|
|
"rundll32.exe",
|
|
"rundll32.exe",
|
|
TRUE,
|
|
"\"rundll32.exe\" foo.bar ,,,,,,,,baz",
|
|
},
|
|
{
|
|
"\"rundll32.exe\" foo.bar baz",
|
|
"rundll32.exe",
|
|
"rundll32.exe",
|
|
TRUE,
|
|
"\"rundll32.exe\" foo.bar baz",
|
|
},
|
|
{
|
|
"\"RuNdlL32.exe\" foo.bar baz",
|
|
"RuNdlL32.exe",
|
|
"RuNdlL32.exe",
|
|
TRUE,
|
|
"\"RuNdlL32.exe\" foo.bar baz",
|
|
},
|
|
{
|
|
"%SystemRoot%\\System32\\rundll32.exe \"%ProgramFiles%\\Windows Photo Viewer\\PhotoViewer.dll,\" ImageView_Fullscreen %1",
|
|
"%SystemRoot%\\System32\\rundll32.exe",
|
|
"rundll32.exe",
|
|
TRUE,
|
|
"%SystemRoot%\\System32\\rundll32.exe \"%ProgramFiles%\\Windows Photo Viewer\\PhotoViewer.dll,\" ImageView_Fullscreen %1",
|
|
},
|
|
{
|
|
"\"rundll32.exe\" \"foo bar,\"baz",
|
|
"rundll32.exe",
|
|
"rundll32.exe",
|
|
TRUE,
|
|
"\"rundll32.exe\" \"foo bar,\"baz",
|
|
},
|
|
{
|
|
"\"rundll32.exe\" some,thing",
|
|
"rundll32.exe",
|
|
"rundll32.exe",
|
|
TRUE,
|
|
"\"rundll32.exe\" some thing",
|
|
},
|
|
{
|
|
"\"rundll32.exe\" some,",
|
|
"rundll32.exe",
|
|
"rundll32.exe",
|
|
FALSE,
|
|
"\"rundll32.exe\" some,",
|
|
},
|
|
/* These filenames are not allowed on Windows, but our function doesn't care about that */
|
|
{
|
|
"run\"dll32.exe foo\".bar,baz",
|
|
"run\"dll32.exe",
|
|
"run\"dll32.exe",
|
|
FALSE,
|
|
NULL,
|
|
},
|
|
{
|
|
"run,dll32.exe foo.bar,baz",
|
|
"run,dll32.exe",
|
|
"run,dll32.exe",
|
|
FALSE,
|
|
NULL,
|
|
},
|
|
{
|
|
"\"rundll32.exe\" some, thing",
|
|
"rundll32.exe",
|
|
"rundll32.exe",
|
|
TRUE,
|
|
"\"rundll32.exe\" some thing",
|
|
},
|
|
/* Commands with "rundll32" (without the .exe suffix) do exist,
|
|
* but GLib currently does not recognize them, so there's no point
|
|
* in testing these.
|
|
*/
|
|
};
|
|
|
|
static void
|
|
test_win32_rundll32_fixup (void)
|
|
{
|
|
gsize i;
|
|
|
|
for (i = 0; i < G_N_ELEMENTS (rundll32_commandlines); i++)
|
|
{
|
|
gunichar2 *argument;
|
|
gunichar2 *expected;
|
|
|
|
if (!rundll32_commandlines[i].is_rundll32)
|
|
continue;
|
|
|
|
argument = g_utf8_to_utf16 (rundll32_commandlines[i].orig, -1, NULL, NULL, NULL);
|
|
expected = g_utf8_to_utf16 (rundll32_commandlines[i].fixed, -1, NULL, NULL, NULL);
|
|
|
|
g_assert_nonnull (argument);
|
|
g_assert_nonnull (expected);
|
|
_g_win32_fixup_broken_microsoft_rundll_commandline (argument);
|
|
|
|
g_assert_cmputf16 (argument, ==, expected, rundll32_commandlines[i].orig, rundll32_commandlines[i].fixed);
|
|
|
|
g_free (argument);
|
|
g_free (expected);
|
|
}
|
|
}
|
|
|
|
static void
|
|
test_win32_extract_executable (void)
|
|
{
|
|
gsize i;
|
|
|
|
for (i = 0; i < G_N_ELEMENTS (rundll32_commandlines); i++)
|
|
{
|
|
gunichar2 *argument;
|
|
gchar *dll_function;
|
|
gchar *executable;
|
|
gchar *executable_basename;
|
|
gchar *executable_folded;
|
|
gchar *executable_folded_basename;
|
|
|
|
argument = g_utf8_to_utf16 (rundll32_commandlines[i].orig, -1, NULL, NULL, NULL);
|
|
|
|
_g_win32_extract_executable (argument, NULL, NULL, NULL, NULL, &dll_function);
|
|
|
|
if (rundll32_commandlines[i].is_rundll32)
|
|
g_assert_nonnull (dll_function);
|
|
else
|
|
g_assert_null (dll_function);
|
|
|
|
g_free (dll_function);
|
|
|
|
executable = NULL;
|
|
executable_basename = NULL;
|
|
executable_folded = NULL;
|
|
executable_folded_basename = NULL;
|
|
_g_win32_extract_executable (argument, &executable, &executable_basename, &executable_folded, &executable_folded_basename, NULL);
|
|
|
|
g_assert_cmpstr (rundll32_commandlines[i].executable, ==, executable);
|
|
g_assert_cmpstr (rundll32_commandlines[i].executable_basename, ==, executable_basename);
|
|
g_assert_nonnull (executable_folded);
|
|
|
|
g_free (executable);
|
|
g_free (executable_folded);
|
|
|
|
/* Check the corner-case where we don't want to know where basename is */
|
|
executable = NULL;
|
|
executable_folded = NULL;
|
|
_g_win32_extract_executable (argument, &executable, NULL, &executable_folded, NULL, NULL);
|
|
|
|
g_assert_cmpstr (rundll32_commandlines[i].executable, ==, executable);
|
|
g_assert_nonnull (executable_folded);
|
|
|
|
g_free (executable);
|
|
g_free (executable_folded);
|
|
|
|
g_free (argument);
|
|
}
|
|
}
|
|
|
|
static void
|
|
test_win32_parse_filename (void)
|
|
{
|
|
gsize i;
|
|
|
|
for (i = 0; i < G_N_ELEMENTS (rundll32_commandlines); i++)
|
|
{
|
|
gunichar2 *argument;
|
|
argument = g_utf8_to_utf16 (rundll32_commandlines[i].orig, -1, NULL, NULL, NULL);
|
|
/* Just checking that it doesn't blow up on various (sometimes incorrect) strings */
|
|
_g_win32_parse_filename (argument, FALSE, NULL, NULL, NULL, NULL);
|
|
g_free (argument);
|
|
}
|
|
}
|
|
|
|
static void
|
|
do_fail_on_broken_utf16_1 (void)
|
|
{
|
|
const gunichar2 utf16[] = { 0xd800, 0x0000 };
|
|
_g_win32_extract_executable (utf16, NULL, NULL, NULL, NULL, NULL);
|
|
}
|
|
|
|
static void
|
|
do_fail_on_broken_utf16_2 (void)
|
|
{
|
|
/* "rundll32.exe <invalid utf16> r" */
|
|
gchar *dll_function;
|
|
const gunichar2 utf16[] = { 0x0072, 0x0075, 0x006E, 0x0064, 0x006C, 0x006C, 0x0033, 0x0032,
|
|
0x002E, 0x0065, 0x0078, 0x0065, 0x0020, 0xd800, 0x0020, 0x0072, 0x0000 };
|
|
_g_win32_extract_executable (utf16, NULL, NULL, NULL, NULL, &dll_function);
|
|
}
|
|
|
|
static void
|
|
test_fail_on_broken_utf16 (void)
|
|
{
|
|
g_test_trap_subprocess ("/appinfo/subprocess/win32-assert-broken-utf16_1", 0, 0);
|
|
g_test_trap_assert_failed ();
|
|
g_test_trap_assert_stderr ("*GLib-GIO:ERROR:*giowin32-private.c:*:_g_win32_extract_executable: assertion failed: (folded)*");
|
|
g_test_trap_subprocess ("/appinfo/subprocess/win32-assert-broken-utf16_2", 0, 0);
|
|
g_test_trap_assert_failed ();
|
|
g_test_trap_assert_stderr ("*GLib-GIO:ERROR:*giowin32-private.c:*:_g_win32_extract_executable: assertion failed: (folded)*");
|
|
}
|
|
|
|
int
|
|
main (int argc,
|
|
char *argv[])
|
|
{
|
|
g_test_init (&argc, &argv, NULL);
|
|
|
|
g_test_add_func ("/appinfo/utf16-strfuncs", test_utf16_strfuncs);
|
|
g_test_add_func ("/appinfo/win32-extract-executable", test_win32_extract_executable);
|
|
g_test_add_func ("/appinfo/win32-rundll32-fixup", test_win32_rundll32_fixup);
|
|
g_test_add_func ("/appinfo/win32-parse-filename", test_win32_parse_filename);
|
|
g_test_add_func ("/appinfo/win32-utf16-conversion-fail", test_fail_on_broken_utf16);
|
|
|
|
g_test_add_func ("/appinfo/subprocess/win32-assert-broken-utf16_1", do_fail_on_broken_utf16_1);
|
|
g_test_add_func ("/appinfo/subprocess/win32-assert-broken-utf16_2", do_fail_on_broken_utf16_2);
|
|
|
|
return g_test_run ();
|
|
}
|
|
|