mirror of
https://gitlab.gnome.org/GNOME/glib.git
synced 2025-01-13 07:56:17 +01:00
a412ffe4d3
The problem occurs because we keep a pointer inside the allocated block, instead of a pointer to the start of the block: ``` ==180238== 16 bytes in 1 blocks are possibly lost in loss record 3,086 of 16,075 ==180238== at 0x483980B: malloc (vg_replace_malloc.c:309) ==180238== by 0x548942C: g_malloc (gmem.c:102) ==180238== by 0x54A4748: g_slice_alloc (gslice.c:1025) ==180238== by 0x53D0AAF: freelist_alloc (gatomicarray.c:77) ==180238== by 0x53D0B85: _g_atomic_array_copy (gatomicarray.c:133) ==180238== by 0x53F8E6D: iface_node_set_offset_L (gtype.c:1347) ==180238== by 0x53F91F1: type_node_add_iface_entry_W (gtype.c:1444) ==180238== by 0x53F93DF: type_add_interface_Wm (gtype.c:1477) ==180238== by 0x53FC946: g_type_add_interface_static (gtype.c:2852) ==180238== by 0x4A3D53A: gtk_menu_shell_accessible_get_type_once (gtkmenushellaccessible.c:26) ==180238== by 0x4A3D495: gtk_menu_shell_accessible_get_type (gtkmenushellaccessible.c:26) ==180238== by 0x4C8AC44: gtk_menu_shell_class_init (gtkmenushell.c:424) ``` Note we cannot use VALGRIND_FREELIKE_BLOCK() in freelist_free() because we have not actually freed the FreeListNode and need to dereference it in freelist_alloc() to decide whether to reuse the block. That would result in a use-after-free warning before we would get a chance to call VALGRIND_MALLOCLIKE_BLOCK() in the reuse path. Also note that this free list only ever grows: it never shrinks for the lifetime of the application, so nothing here will ever be truely freed, although unused elements are eligible for reuse. Fix suggested by Philip Withnall Related: #2076 |
||
|---|---|---|
| .. | ||
| tests | ||
| gatomicarray.c | ||
| gatomicarray.h | ||
| gbinding.c | ||
| gbinding.h | ||
| gboxed.c | ||
| gboxed.h | ||
| gclosure.c | ||
| gclosure.h | ||
| genums.c | ||
| genums.h | ||
| glib-enumtypes.c.template | ||
| glib-enumtypes.h.template | ||
| glib-genmarshal.in | ||
| glib-mkenums.in | ||
| glib-types.h | ||
| gmarshal.c | ||
| gmarshal.h | ||
| gobject_gdb.py | ||
| gobject_probes.d | ||
| gobject_trace.h | ||
| gobject-autocleanups.h | ||
| gobject-query.c | ||
| gobject.c | ||
| gobject.h | ||
| gobject.rc.in | ||
| gobject.stp.in | ||
| gobjectnotifyqueue.c | ||
| gparam.c | ||
| gparam.h | ||
| gparamspecs.c | ||
| gparamspecs.h | ||
| gsignal.c | ||
| gsignal.h | ||
| gsourceclosure.c | ||
| gsourceclosure.h | ||
| gtype-private.h | ||
| gtype.c | ||
| gtype.h | ||
| gtypemodule.c | ||
| gtypemodule.h | ||
| gtypeplugin.c | ||
| gtypeplugin.h | ||
| gvalue.c | ||
| gvalue.h | ||
| gvaluearray.c | ||
| gvaluearray.h | ||
| gvaluecollector.h | ||
| gvaluetransform.c | ||
| gvaluetypes.c | ||
| gvaluetypes.h | ||
| libgobject-gdb.py.in | ||
| meson.build | ||