glib/gio/gportalsupport.c
Robert Ancell 216d7ba042 portal: Check for snap plugs before accessing portals
This is of particular use in the gsettings backend, which is currently using
dconf for all snaps.
Fully confined snaps should use the keyfile backend, as Flatpaks do.

Co-Authored-by: Marco Trevisan <mail@3v1n0.net>
2022-11-24 20:00:18 +01:00

159 lines
4.3 KiB
C

/* GIO - GLib Input, Output and Streaming Library
*
* Copyright 2016 Red Hat, Inc.
*
* SPDX-License-Identifier: LGPL-2.1-or-later
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
* License as published by the Free Software Foundation; either
* version 2.1 of the License, or (at your option) any later version.
*
* This library is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Lesser General Public License for more details.
*
* You should have received a copy of the GNU Lesser General
* Public License along with this library; if not, see <http://www.gnu.org/licenses/>.
*/
#include "config.h"
#include "glib-private.h"
#include "gportalsupport.h"
#include "gsandbox.h"
static GSandboxType sandbox_type = G_SANDBOX_TYPE_UNKNOWN;
static gboolean use_portal;
static gboolean network_available;
static gboolean dconf_access;
static gboolean
snap_plug_is_connected (const gchar *plug_name)
{
const gchar *argv[] = { "snapctl", "is-connected", plug_name, NULL };
gint wait_status;
/* Bail out if our process is privileged - we don't want to pass those
* privileges to snapctl. It could be overridden using PATH and this would
* allow arbitrary code execution.
*/
if (GLIB_PRIVATE_CALL (g_check_setuid) ())
return FALSE;
if (!g_spawn_sync (NULL, (gchar **) argv, NULL,
G_SPAWN_SEARCH_PATH |
G_SPAWN_STDOUT_TO_DEV_NULL |
G_SPAWN_STDERR_TO_DEV_NULL,
NULL, NULL, NULL, NULL, &wait_status,
NULL))
return FALSE;
return g_spawn_check_wait_status (wait_status, NULL);
}
static void
sandbox_info_read (void)
{
static gsize sandbox_info_is_read = 0;
/* Sandbox type and Flatpak info is static, so only read once */
if (!g_once_init_enter (&sandbox_info_is_read))
return;
sandbox_type = glib_get_sandbox_type ();
switch (sandbox_type)
{
case G_SANDBOX_TYPE_FLATPAK:
{
GKeyFile *keyfile;
use_portal = TRUE;
network_available = FALSE;
dconf_access = FALSE;
keyfile = g_key_file_new ();
if (g_key_file_load_from_file (keyfile, "/.flatpak-info", G_KEY_FILE_NONE, NULL))
{
char **shared = NULL;
char *dconf_policy = NULL;
shared = g_key_file_get_string_list (keyfile, "Context", "shared", NULL, NULL);
if (shared)
{
network_available = g_strv_contains ((const char *const *) shared, "network");
g_strfreev (shared);
}
dconf_policy = g_key_file_get_string (keyfile, "Session Bus Policy", "ca.desrt.dconf", NULL);
if (dconf_policy)
{
if (strcmp (dconf_policy, "talk") == 0)
dconf_access = TRUE;
g_free (dconf_policy);
}
}
g_key_file_unref (keyfile);
}
break;
case G_SANDBOX_TYPE_SNAP:
break;
case G_SANDBOX_TYPE_UNKNOWN:
{
const char *var;
var = g_getenv ("GTK_USE_PORTAL");
if (var && var[0] == '1')
use_portal = TRUE;
network_available = TRUE;
dconf_access = TRUE;
}
break;
}
g_once_init_leave (&sandbox_info_is_read, 1);
}
gboolean
glib_should_use_portal (void)
{
sandbox_info_read ();
if (sandbox_type == G_SANDBOX_TYPE_SNAP)
return snap_plug_is_connected ("desktop");
return use_portal;
}
gboolean
glib_network_available_in_sandbox (void)
{
sandbox_info_read ();
if (sandbox_type == G_SANDBOX_TYPE_SNAP)
{
/* FIXME: This is inefficient doing multiple calls to check connections.
* See https://github.com/snapcore/snapd/pull/12301 for a proposed
* improvement to snapd for this.
*/
return snap_plug_is_connected ("desktop") ||
snap_plug_is_connected ("network-status");
}
return network_available;
}
gboolean
glib_has_dconf_access_in_sandbox (void)
{
sandbox_info_read ();
if (sandbox_type == G_SANDBOX_TYPE_SNAP)
return snap_plug_is_connected ("gsettings");
return dconf_access;
}