mirror of
https://gitlab.gnome.org/GNOME/glib.git
synced 2024-11-10 03:16:17 +01:00
e0a0749268
When using a GDBus client in a non-trivial user namespace, the result of
geteuid() can differ from the uid in the namespace where the server is
running. This would result in connection attempts being rejected, because
the identity that the client claims to have does not match the identity
that the server derives from its credentials.
RFC 4422 allows us to send an empty authorization identity, which means we
want to authenticate as whatever identity the server can derive from our
out-of-band credentials. In particular, this resolves the authentication
failure when crossing between different Linux user namespaces.
Because D-Bus does not have a way to represent an empty initial response
as distinct from the absence of an initial response, we cannot use the
initial-response optimization (RFC 4422 §4.3.a) in this case, and must
fall back to waiting for the server to send a challenge.
Unfortunately, GDBus versions older than glib!2826 did not implement
the server side of this protocol correctly, and would respond to the
missing initial response in a way that breaks the SASL state machine
(expecting a response without sending a challenge), causing client and
server to deadlock with each waiting for the other to respond. Until
fixed versions of GDBus are widespread, we can't rely on having a server
that can cope with this, so gate it behind a flag, which can be set for
connections that are known to cross non-trivial namespace boundaries.
Originally inspired by
<1ed4723d38>,
and based on earlier work by Giuseppe Scrivano (in which the
cross-namespace behaviour was unconditional, rather than gated by a
flag).
Co-authored-by: Giuseppe Scrivano <giuseppe@scrivano.org>
Signed-off-by: Simon McVittie <smcv@collabora.com>
90 lines
3.5 KiB
C
90 lines
3.5 KiB
C
/* GDBus - GLib D-Bus Library
|
|
*
|
|
* Copyright (C) 2008-2010 Red Hat, Inc.
|
|
*
|
|
* SPDX-License-Identifier: LGPL-2.1-or-later
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General
|
|
* Public License along with this library; if not, see <http://www.gnu.org/licenses/>.
|
|
*
|
|
* Author: David Zeuthen <davidz@redhat.com>
|
|
*/
|
|
|
|
#ifndef __G_DBUS_AUTH_H__
|
|
#define __G_DBUS_AUTH_H__
|
|
|
|
#if !defined (GIO_COMPILATION)
|
|
#error "gdbusauth.h is a private header file."
|
|
#endif
|
|
|
|
#include <gio/giotypes.h>
|
|
|
|
G_BEGIN_DECLS
|
|
|
|
#define G_TYPE_DBUS_AUTH (_g_dbus_auth_get_type ())
|
|
#define G_DBUS_AUTH(o) (G_TYPE_CHECK_INSTANCE_CAST ((o), G_TYPE_DBUS_AUTH, GDBusAuth))
|
|
#define G_DBUS_AUTH_CLASS(k) (G_TYPE_CHECK_CLASS_CAST((k), G_TYPE_DBUS_AUTH, GDBusAuthClass))
|
|
#define G_DBUS_AUTH_GET_CLASS(o) (G_TYPE_INSTANCE_GET_CLASS ((o), G_TYPE_DBUS_AUTH, GDBusAuthClass))
|
|
#define G_IS_DBUS_AUTH(o) (G_TYPE_CHECK_INSTANCE_TYPE ((o), G_TYPE_DBUS_AUTH))
|
|
#define G_IS_DBUS_AUTH_CLASS(k) (G_TYPE_CHECK_CLASS_TYPE ((k), G_TYPE_DBUS_AUTH))
|
|
|
|
typedef struct _GDBusAuth GDBusAuth;
|
|
typedef struct _GDBusAuthClass GDBusAuthClass;
|
|
typedef struct _GDBusAuthPrivate GDBusAuthPrivate;
|
|
|
|
struct _GDBusAuthClass
|
|
{
|
|
/*< private >*/
|
|
GObjectClass parent_class;
|
|
};
|
|
|
|
struct _GDBusAuth
|
|
{
|
|
GObject parent_instance;
|
|
GDBusAuthPrivate *priv;
|
|
};
|
|
|
|
GType _g_dbus_auth_get_type (void) G_GNUC_CONST;
|
|
GDBusAuth *_g_dbus_auth_new (GIOStream *stream);
|
|
|
|
/* TODO: need a way to set allowed authentication mechanisms */
|
|
|
|
/* TODO: need a way to convey credentials etc. */
|
|
|
|
/* TODO: need a way to convey negotiated features (e.g. returning flags from e.g. GDBusConnectionFeatures) */
|
|
|
|
/* TODO: need to expose encode()/decode() from the AuthMechanism (and whether it is needed at all) */
|
|
|
|
gboolean _g_dbus_auth_run_server (GDBusAuth *auth,
|
|
GDBusAuthObserver *observer,
|
|
const gchar *guid,
|
|
gboolean allow_anonymous,
|
|
gboolean require_same_user,
|
|
GDBusCapabilityFlags offered_capabilities,
|
|
GDBusCapabilityFlags *out_negotiated_capabilities,
|
|
GCredentials **out_received_credentials,
|
|
GCancellable *cancellable,
|
|
GError **error);
|
|
|
|
gchar *_g_dbus_auth_run_client (GDBusAuth *auth,
|
|
GDBusAuthObserver *observer,
|
|
GDBusConnectionFlags conn_flags,
|
|
GDBusCapabilityFlags offered_capabilities,
|
|
GDBusCapabilityFlags *out_negotiated_capabilities,
|
|
GCancellable *cancellable,
|
|
GError **error);
|
|
|
|
G_END_DECLS
|
|
|
|
#endif /* __G_DBUS_AUTH_H__ */
|